Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Unit test and builder cleanups #5465

Merged

Conversation

killianmuldoon
Copy link
Contributor

This is a set of small cleanups for unit tests and the builder package:

  1. create a spec for unstructured objects at build time and remove unnecessary setting inside tests.
  2. remove resourceVersion where it was still set unnecessarily.
  3. Add WithSpecFields comments throughout to make it consistent
  4. Removed a TODO which is unnecessary (WILLNOTDO!)

Fixes #5207

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 20, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 20, 2021
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@killianmuldoon Could it be that there is something missing? I couldn't find 2. and 4. (and probably also not 3.)

internal/builder/builders.go Outdated Show resolved Hide resolved
internal/builder/builders.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 21, 2021
@killianmuldoon
Copy link
Contributor Author

@killianmuldoon Could it be that there is something missing? I couldn't find 2. and 4. (and probably also not 3.)

Definitely was something missing! Should be updated now.

@sbueringer
Copy link
Member

Nice cleanup. Looks a lot better now! :)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2021
@fabriziopandini
Copy link
Member

Thanks for getting rid of some of ours todo!
lgtm pending squash

Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2021
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2021
@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit eb38bab into kubernetes-sigs:main Oct 22, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add expressive comments to functions in testtypes/builders.go
4 participants