馃尡 ClusterClass: improve logging #5751
Conversation
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
| @@ -78,7 +78,7 @@ type TemplateRef struct { | |||
| MachineDeploymentRef MachineDeploymentRef | |||
| } | |||
|
|
|||
| func (t *TemplateRef) String() string { | |||
| func (t TemplateRef) String() string { | |||
There was a problem hiding this comment.
It seems like the String func should always be implemented with a value receiver. That way it works independent of if the TemplateRef is a pointer or not (I tested it with ~ fmt.Sprintf("%s %s", &api.TemplateRef{..}, api.TemplateRef{..})
This leads to the question if we should fix it in other cases too:
-
func (n *Node) String() string {
- exported type in test/infrastructure/docker/docker/types
-
func (p *ProviderID) String() string {
- exported type in controllers/noderefutil
-
func (n *NetworkRanges) String() string {
- exported type in api/v1beta1
-
func (t *healthCheckTarget) string() string {- Just saw that one is lower case so it doesn't implement the interface anyway
There was a problem hiding this comment.
Let's open an issue for this
| @@ -248,7 +248,7 @@ func applyPatchesToRequest(ctx context.Context, req *api.GenerateRequest, resp * | |||
| log := tlog.LoggerFrom(ctx) | |||
|
|
|||
| for _, patch := range resp.Items { | |||
| log = log.WithValues("templateRef", patch.TemplateRef) | |||
| log = log.WithValues("templateRef", patch.TemplateRef.String()) | |||
There was a problem hiding this comment.
We have to call the .String() func here explicitly because WithValues (and its underlying funcs) does not automatically use String() if the type implements the Stringer interface like fmt.Sprintf does
|
/lgtm |
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
k8s-ci-robot
added
the
cncf-cla: yes
|
/check-cla |
k8s-ci-robot
added
the
approved
|
@fabriziopandini Can you please reapply the lgtm label? Looks like Prow didn't set it based on your comment /retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #