Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.3] ⚠️ Use Kubernetes 1.26 in Quick Start docs and CAPD #7859

Merged
merged 1 commit into from
Jan 11, 2023
Merged

[release-1.3] ⚠️ Use Kubernetes 1.26 in Quick Start docs and CAPD #7859

merged 1 commit into from
Jan 11, 2023

Conversation

aniruddha2000
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
part of #7671

cc @kubernetes-sigs/cluster-api-release-team

@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Jan 6, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 6, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 6, 2023
cpanato
cpanato approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 408fd185a6dce078893f87f42618043ab4d7b5d0

killianmuldoon
killianmuldoon approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sbueringer sbueringer changed the title ⚠️ Use Kubernetes 1.26 in Quick Start docs and CAPD for release 1.3 [release-1.2] ⚠️ Use Kubernetes 1.26 in Quick Start docs and CAPD Jan 9, 2023
@sbueringer sbueringer changed the title [release-1.2] ⚠️ Use Kubernetes 1.26 in Quick Start docs and CAPD [release-1.3] ⚠️ Use Kubernetes 1.26 in Quick Start docs and CAPD Jan 9, 2023
@sbueringer sbueringer mentioned this pull request Jan 9, 2023
Closed
13 tasks
sbueringer
sbueringer reviewed Jan 9, 2023
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aniruddha2000 Thx, just a few nits

Tiltfile Outdated Show resolved Hide resolved
test/e2e/clusterctl_upgrade_test.go Outdated Show resolved Hide resolved
test/e2e/clusterctl_upgrade_test.go Outdated Show resolved Hide resolved
@fabriziopandini
Copy link
Member

/hold
after tomorrow's patch release; this will slit to next month's patch release (we need CI signal for it first)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2023
@aniruddha2000
Use Kubernetes 1.26 in Quick Start docs and CAPD.
949081f 
Signed-off-by: Aniruddha Basak <codewithaniruddha@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 9, 2023
@sbueringer
Copy link
Member

Thx!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4ac3450b052ddbbbdde39d245784065292f6f471

@sbueringer
Copy link
Member

/lgtm
/approve

@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2023
@sbueringer
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit a98d0e9 into kubernetes-sigs:release-1.3 Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@oscr oscr Awaiting requested review from oscr

@cpanato cpanato Awaiting requested review from cpanato

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

Assignees

@cpanato cpanato

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aniruddha2000 @k8s-ci-robot @fabriziopandini @sbueringer @cpanato @killianmuldoon