Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to still using Component Config besides it be deprecated only #2370

Closed
camilamacedo86 opened this issue Jun 9, 2023 · 5 comments
Closed
Labels
kind/support Categorizes issue or PR as a support question. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@camilamacedo86
Copy link
Member

We are facing a hard time to bump Controller-Runtime 0.15.0 due the breaking changes.
We noticed that the ComponentConfig was deprecated. #895

However, it seems that it also has a bug. This means when ctrl.File is called in cmd/main.go it calls in here which registers the ComponentConfig with the scheme. Though the field has been deprecated, the ComponentConfig type should still be registered with controller-runtime.sigs.k8s.io/v1alpha1 scheme, which seems missing.

@alvaroaleman
Copy link
Member

Sorry, I don't understand the bug. Could you provide a sample snippet of what you are trying to do?

mpreu added a commit to guacamole-operator/guacamole-operator that referenced this issue Jul 6, 2023
ComponentConfig was removed from the upstream controller-runtime as
described here
kubernetes-sigs/kubebuilder#3469.

Although only deprecated, there are now issues with it, as described
here kubernetes-sigs/controller-runtime#2370.

Because the ComponentConfig was not used until now, it can be removed
from the project.
mpreu added a commit to guacamole-operator/guacamole-operator that referenced this issue Jul 6, 2023
ComponentConfig was removed from the upstream controller-runtime as
described here
kubernetes-sigs/kubebuilder#3469.

Although only deprecated, there are now issues with it, as described
here kubernetes-sigs/controller-runtime#2370.

Because the ComponentConfig was not used until now, it can be removed
from the project.
@troy0820
Copy link
Member

/kind support

Is this issue fixed with the above pull request to guacamole-operator? @camilamacedo86

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 26, 2024
@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Feb 26, 2024

Hi @alvaroaleman,

The ComponentConfig was deprecated; therefore, it should still work fine until being removed and no longer supported.
However, that is not the case.

This means when ctrl.File is called in cmd/main.go it calls in here which registers the ComponentConfig with the scheme. Though the field has been deprecated, the ComponentConfig type should still be registered with controller-runtime.sigs.k8s.io/v1alpha1 scheme, which seems missing.

Anyway, I think that can be closed. It was not well adopted because we did not face complaints from Kubebuilder users, and we have already been communicating that soon we will do a MAJOR release where this option will be removed from there.

Therefore, I am closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/support Categorizes issue or PR as a support question. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants