removed type field from crd validation schema #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/M
k8s 1.11 rejects CRDs with type property at the root if status sub-resources enabled. This change drops the type field for CRD at the root level. kubernetes/kubernetes#65293 kubernetes/kubernetes#65357
droot
force-pushed
the
bugfix/remove-root-type-crd-schema
branch
from
04bf038
to
9f1e657
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
sebgl
added a commit
to sebgl/cloud-on-k8s
that referenced
this pull request
Nov 15, 2019
This is causing failures when applying the CRDs on v1.11. However this is supposed to be fixed in kubernetes-sigs/controller-tools#72 already... Needs some investigation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k8s 1.11 rejects CRDs with type property at the root if status sub-resources enabled.
This change drops the type field for CRD at the root level.
kubernetes/kubernetes#65293
kubernetes/kubernetes#65357