Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trap Ctrl+C. #288

Closed
Random-Liu opened this issue Apr 13, 2018 · 2 comments
Closed

Trap Ctrl+C. #288

Random-Liu opened this issue Apr 13, 2018 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@Random-Liu
Copy link
Contributor

Random-Liu commented Apr 13, 2018

crictl behavior:

e2e-test-lantaol-master ~ # crictl exec -i -t 8cbe40af73606 /bin/sh
# sleep 1000
sleep 1000
^C
e2e-test-lantaol-master ~ #

docker exec behavior:

e2e-test-lantaol-master ~ # docker exec -it 2ccc5ed91407 /bin/sh
# sleep 1000
^C
# exit
e2e-test-lantaol-master ~ #
@Random-Liu Random-Liu added the kind/bug Categorizes issue or PR as related to a bug. label Apr 13, 2018
@chuckha
Copy link
Contributor

chuckha commented Jun 18, 2018

This seems like a pretty involved ticket. I was reading up on how kubectl exec does this and it sets up and manages its own ptys. It captures interrupts, but does depend on the docker library

Did you have any thoughts on how you'd like this to be implemented?

@Random-Liu
Copy link
Contributor Author

Random-Liu commented Jul 7, 2018

@chuckha I think it is fine to use a docker library. :) Would you like to send out a PR?

BTW, I found that this can cause exec process leakage for containerd, I haven't tried docker yet. Just note it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants