Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm chart does not allow "falsey" value in cmdOptions #1371

Closed
fullykubed opened this issue Apr 2, 2024 · 1 comment · Fixed by #1390
Closed

Helm chart does not allow "falsey" value in cmdOptions #1371

fullykubed opened this issue Apr 2, 2024 · 1 comment · Fixed by #1390
Assignees
@omerap12
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@fullykubed
Copy link

What version of descheduler are you using?

descheduler version: v0.29.0

Does this issue reproduce with the latest release?

Yes

What did you do?

Tried to deploy the helm chart with cmdOptions.v equal to 0.

What did you expect to see?

The descheduler started with --v=0.

What did you see instead?

The descheduler started with --v.

Root Cause

This line is incorrect as it is not possible to provide a "falsey" value such as 0.
@fullykubed fullykubed added the kind/bug Categorizes issue or PR as related to a bug. label Apr 2, 2024
@omerap12
Copy link
Member

/assign

@omerap12 omerap12 mentioned this issue May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omerap12 omerap12

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Helm chart - allow 'falsey' value in cmdOption omerap12/descheduler
2 participants
@fullykubed @omerap12