Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dry-run cli flag to use uppercase #1103

Merged
merged 1 commit into from
Apr 1, 2023
Merged

dry-run cli flag to use uppercase #1103

merged 1 commit into from
Apr 1, 2023

Conversation

yanggangtony
Copy link
Member

.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 31, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @yanggangtony!

It looks like this is your first PR to kubernetes-sigs/descheduler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/descheduler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 31, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @yanggangtony. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 31, 2023
@a7i
Copy link
Contributor

a7i commented Mar 31, 2023

/retitle dry-run cli flag to use uppercase
/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot changed the title Make cobra args help info to uppercase. dry-run cli flag to use uppercase Mar 31, 2023
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 31, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2023
@a7i
Copy link
Contributor

a7i commented Mar 31, 2023

@yanggangtony would you please update the docs by running the make commands?

Signed-off-by: yanggang <gang.yang@daocloud.io>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2023
@yanggangtony
Copy link
Member Author

@a7i
Thanks for the review and quick response.
Rebased it.

@a7i
Copy link
Contributor

a7i commented Apr 1, 2023

/lgtm
/approve

Thank you for your contribution!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit aba0064 into kubernetes-sigs:master Apr 1, 2023
coolguy1771 pushed a commit to coolguy1771/home-ops that referenced this pull request May 6, 2023
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [descheduler](https://togithub.com/kubernetes-sigs/descheduler) |
minor | `0.26.1` -> `0.27.0` |

---

### Release Notes

<details>
<summary>kubernetes-sigs/descheduler</summary>

###
[`v0.27.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.27.0):
Descheduler v0.27.0

[Compare
Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.26.1...v0.27.0)

#### What's Changed

- add v1alpha2 registry based conversion by
[@&#8203;knelasevero](https://togithub.com/knelasevero) in
[kubernetes-sigs/descheduler#1006
- support client connection configuration to provide QPS and burst by
[@&#8203;a7i](https://togithub.com/a7i) in
[kubernetes-sigs/descheduler#1034
- enable auto generation of the documents by
[@&#8203;harshanarayana](https://togithub.com/harshanarayana) in
[kubernetes-sigs/descheduler#1048
- Fix v1alpha1 conversion to use universal decoder by
[@&#8203;gustavomfc](https://togithub.com/gustavomfc) in
[kubernetes-sigs/descheduler#1051
- metrics: enable loop duration and strategy duration metrics by
[@&#8203;harshanarayana](https://togithub.com/harshanarayana) in
[kubernetes-sigs/descheduler#1041
- v1alpha2 docs by
[@&#8203;knelasevero](https://togithub.com/knelasevero) in
[kubernetes-sigs/descheduler#1049
- remove some logic useless by
[@&#8203;lucming](https://togithub.com/lucming) in
[kubernetes-sigs/descheduler#1059
- check pod number by
[@&#8203;xiaoanyunfei](https://togithub.com/xiaoanyunfei) in
[kubernetes-sigs/descheduler#1057
- Adding descheduler policy API Version option in helm templates by
[@&#8203;gdasson](https://togithub.com/gdasson) in
[kubernetes-sigs/descheduler#1068
- Fix typo in nodeutilization types by
[@&#8203;JannikSt](https://togithub.com/JannikSt) in
[kubernetes-sigs/descheduler#1072
- Add note to HighNodeUtilization readme for GKE users by
[@&#8203;damemi](https://togithub.com/damemi) in
[kubernetes-sigs/descheduler#1075
- expose security context from helm chart by
[@&#8203;JaneLiuL](https://togithub.com/JaneLiuL) in
[kubernetes-sigs/descheduler#1066
- remove e2e tests from helm github action by
[@&#8203;a7i](https://togithub.com/a7i) in
[kubernetes-sigs/descheduler#937
- Add k8s compatibility warnings to logs by
[@&#8203;JaneLiuL](https://togithub.com/JaneLiuL) in
[kubernetes-sigs/descheduler#1063
- docs: typo by [@&#8203;dangen-effy](https://togithub.com/dangen-effy)
in
[kubernetes-sigs/descheduler#1090
- Descheduling profile with PoC fake plugin by
[@&#8203;ingvagabund](https://togithub.com/ingvagabund) in
[kubernetes-sigs/descheduler#1093
- bump golangci for go 1.20 by [@&#8203;a7i](https://togithub.com/a7i)
in
[kubernetes-sigs/descheduler#1101
- dry-run cli flag to use uppercase by
[@&#8203;yanggangtony](https://togithub.com/yanggangtony) in
[kubernetes-sigs/descheduler#1103
- fix default value assignment of EvictLocalStoragePods by
[@&#8203;yanggangtony](https://togithub.com/yanggangtony) in
[kubernetes-sigs/descheduler#1104
- bump to k8s 1.27 rc0 by [@&#8203;a7i](https://togithub.com/a7i) in
[kubernetes-sigs/descheduler#1100
- fix go doc for method IsPodWithPVC by
[@&#8203;yanggangtony](https://togithub.com/yanggangtony) in
[kubernetes-sigs/descheduler#1105
- Populate extension points automatically for deschedule, balance,
filter and preEvictionFilter by
[@&#8203;ingvagabund](https://togithub.com/ingvagabund) in
[kubernetes-sigs/descheduler#1097
- Delete "io/ioutil" package. by
[@&#8203;yanggangtony](https://togithub.com/yanggangtony) in
[kubernetes-sigs/descheduler#1111
- Fix typo log message for cachedClient by
[@&#8203;yanggangtony](https://togithub.com/yanggangtony) in
[kubernetes-sigs/descheduler#1112
- bump to k8s 1.27 by [@&#8203;a7i](https://togithub.com/a7i) in
[kubernetes-sigs/descheduler#1115
- update v0.26.1 references by [@&#8203;a7i](https://togithub.com/a7i)
in
[kubernetes-sigs/descheduler#1109
- Drop Evict extension point by
[@&#8203;ingvagabund](https://togithub.com/ingvagabund) in
[kubernetes-sigs/descheduler#1120
- Add json tags to internal api fields by
[@&#8203;damemi](https://togithub.com/damemi) in
[kubernetes-sigs/descheduler#1122
- Add knelasevero to approvers by
[@&#8203;knelasevero](https://togithub.com/knelasevero) in
[kubernetes-sigs/descheduler#1130
- Drop remaining mentions of evict extension point by
[@&#8203;ingvagabund](https://togithub.com/ingvagabund) in
[kubernetes-sigs/descheduler#1127
- Add note on documentation versions with links by
[@&#8203;damemi](https://togithub.com/damemi) in
[kubernetes-sigs/descheduler#1132
- Add missing quote to configmap by
[@&#8203;damemi](https://togithub.com/damemi) in
[kubernetes-sigs/descheduler#1133
- fix policy example configmap by
[@&#8203;AllenZMC](https://togithub.com/AllenZMC) in
[kubernetes-sigs/descheduler#1135
- Do some code cleans. by
[@&#8203;yanggangtony](https://togithub.com/yanggangtony) in
[kubernetes-sigs/descheduler#1129

#### New Contributors

- [@&#8203;Bobonium](https://togithub.com/Bobonium) made their first
contribution in
[kubernetes-sigs/descheduler#995
- [@&#8203;harshanarayana](https://togithub.com/harshanarayana) made
their first contribution in
[kubernetes-sigs/descheduler#1048
- [@&#8203;gustavomfc](https://togithub.com/gustavomfc) made their first
contribution in
[kubernetes-sigs/descheduler#1051
- [@&#8203;lucming](https://togithub.com/lucming) made their first
contribution in
[kubernetes-sigs/descheduler#1059
- [@&#8203;gdasson](https://togithub.com/gdasson) made their first
contribution in
[kubernetes-sigs/descheduler#1068
- [@&#8203;JannikSt](https://togithub.com/JannikSt) made their first
contribution in
[kubernetes-sigs/descheduler#1072
- [@&#8203;dangen-effy](https://togithub.com/dangen-effy) made their
first contribution in
[kubernetes-sigs/descheduler#1090
- [@&#8203;yanggangtony](https://togithub.com/yanggangtony) made their
first contribution in
[kubernetes-sigs/descheduler#1103
- [@&#8203;AllenZMC](https://togithub.com/AllenZMC) made their first
contribution in
[kubernetes-sigs/descheduler#1135

**Full Changelog**:
kubernetes-sigs/descheduler@v0.26.0...v0.27.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43MS41IiwidXBkYXRlZEluVmVyIjoiMzUuNzEuNSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: lumiere-bot <98047013+lumiere-bot[bot]@users.noreply.github.com>
renovate bot added a commit to teutonet/teutonet-helm-charts that referenced this pull request May 8, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [descheduler](https://togithub.com/kubernetes-sigs/descheduler) |
minor | `0.26.x` -> `0.27.x` |

---

### Release Notes

<details>
<summary>kubernetes-sigs/descheduler</summary>

###
[`v0.27.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.27.0):
Descheduler v0.27.0

[Compare
Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.26.1...v0.27.0)

#### What's Changed

- add v1alpha2 registry based conversion by
[@&#8203;knelasevero](https://togithub.com/knelasevero) in
[kubernetes-sigs/descheduler#1006
- support client connection configuration to provide QPS and burst by
[@&#8203;a7i](https://togithub.com/a7i) in
[kubernetes-sigs/descheduler#1034
- enable auto generation of the documents by
[@&#8203;harshanarayana](https://togithub.com/harshanarayana) in
[kubernetes-sigs/descheduler#1048
- Fix v1alpha1 conversion to use universal decoder by
[@&#8203;gustavomfc](https://togithub.com/gustavomfc) in
[kubernetes-sigs/descheduler#1051
- metrics: enable loop duration and strategy duration metrics by
[@&#8203;harshanarayana](https://togithub.com/harshanarayana) in
[kubernetes-sigs/descheduler#1041
- v1alpha2 docs by
[@&#8203;knelasevero](https://togithub.com/knelasevero) in
[kubernetes-sigs/descheduler#1049
- remove some logic useless by
[@&#8203;lucming](https://togithub.com/lucming) in
[kubernetes-sigs/descheduler#1059
- check pod number by
[@&#8203;xiaoanyunfei](https://togithub.com/xiaoanyunfei) in
[kubernetes-sigs/descheduler#1057
- Adding descheduler policy API Version option in helm templates by
[@&#8203;gdasson](https://togithub.com/gdasson) in
[kubernetes-sigs/descheduler#1068
- Fix typo in nodeutilization types by
[@&#8203;JannikSt](https://togithub.com/JannikSt) in
[kubernetes-sigs/descheduler#1072
- Add note to HighNodeUtilization readme for GKE users by
[@&#8203;damemi](https://togithub.com/damemi) in
[kubernetes-sigs/descheduler#1075
- expose security context from helm chart by
[@&#8203;JaneLiuL](https://togithub.com/JaneLiuL) in
[kubernetes-sigs/descheduler#1066
- remove e2e tests from helm github action by
[@&#8203;a7i](https://togithub.com/a7i) in
[kubernetes-sigs/descheduler#937
- Add k8s compatibility warnings to logs by
[@&#8203;JaneLiuL](https://togithub.com/JaneLiuL) in
[kubernetes-sigs/descheduler#1063
- docs: typo by [@&#8203;dangen-effy](https://togithub.com/dangen-effy)
in
[kubernetes-sigs/descheduler#1090
- Descheduling profile with PoC fake plugin by
[@&#8203;ingvagabund](https://togithub.com/ingvagabund) in
[kubernetes-sigs/descheduler#1093
- bump golangci for go 1.20 by [@&#8203;a7i](https://togithub.com/a7i)
in
[kubernetes-sigs/descheduler#1101
- dry-run cli flag to use uppercase by
[@&#8203;yanggangtony](https://togithub.com/yanggangtony) in
[kubernetes-sigs/descheduler#1103
- fix default value assignment of EvictLocalStoragePods by
[@&#8203;yanggangtony](https://togithub.com/yanggangtony) in
[kubernetes-sigs/descheduler#1104
- bump to k8s 1.27 rc0 by [@&#8203;a7i](https://togithub.com/a7i) in
[kubernetes-sigs/descheduler#1100
- fix go doc for method IsPodWithPVC by
[@&#8203;yanggangtony](https://togithub.com/yanggangtony) in
[kubernetes-sigs/descheduler#1105
- Populate extension points automatically for deschedule, balance,
filter and preEvictionFilter by
[@&#8203;ingvagabund](https://togithub.com/ingvagabund) in
[kubernetes-sigs/descheduler#1097
- Delete "io/ioutil" package. by
[@&#8203;yanggangtony](https://togithub.com/yanggangtony) in
[kubernetes-sigs/descheduler#1111
- Fix typo log message for cachedClient by
[@&#8203;yanggangtony](https://togithub.com/yanggangtony) in
[kubernetes-sigs/descheduler#1112
- bump to k8s 1.27 by [@&#8203;a7i](https://togithub.com/a7i) in
[kubernetes-sigs/descheduler#1115
- update v0.26.1 references by [@&#8203;a7i](https://togithub.com/a7i)
in
[kubernetes-sigs/descheduler#1109
- Drop Evict extension point by
[@&#8203;ingvagabund](https://togithub.com/ingvagabund) in
[kubernetes-sigs/descheduler#1120
- Add json tags to internal api fields by
[@&#8203;damemi](https://togithub.com/damemi) in
[kubernetes-sigs/descheduler#1122
- Add knelasevero to approvers by
[@&#8203;knelasevero](https://togithub.com/knelasevero) in
[kubernetes-sigs/descheduler#1130
- Drop remaining mentions of evict extension point by
[@&#8203;ingvagabund](https://togithub.com/ingvagabund) in
[kubernetes-sigs/descheduler#1127
- Add note on documentation versions with links by
[@&#8203;damemi](https://togithub.com/damemi) in
[kubernetes-sigs/descheduler#1132
- Add missing quote to configmap by
[@&#8203;damemi](https://togithub.com/damemi) in
[kubernetes-sigs/descheduler#1133
- fix policy example configmap by
[@&#8203;AllenZMC](https://togithub.com/AllenZMC) in
[kubernetes-sigs/descheduler#1135
- Do some code cleans. by
[@&#8203;yanggangtony](https://togithub.com/yanggangtony) in
[kubernetes-sigs/descheduler#1129

#### New Contributors

- [@&#8203;Bobonium](https://togithub.com/Bobonium) made their first
contribution in
[kubernetes-sigs/descheduler#995
- [@&#8203;harshanarayana](https://togithub.com/harshanarayana) made
their first contribution in
[kubernetes-sigs/descheduler#1048
- [@&#8203;gustavomfc](https://togithub.com/gustavomfc) made their first
contribution in
[kubernetes-sigs/descheduler#1051
- [@&#8203;lucming](https://togithub.com/lucming) made their first
contribution in
[kubernetes-sigs/descheduler#1059
- [@&#8203;gdasson](https://togithub.com/gdasson) made their first
contribution in
[kubernetes-sigs/descheduler#1068
- [@&#8203;JannikSt](https://togithub.com/JannikSt) made their first
contribution in
[kubernetes-sigs/descheduler#1072
- [@&#8203;dangen-effy](https://togithub.com/dangen-effy) made their
first contribution in
[kubernetes-sigs/descheduler#1090
- [@&#8203;yanggangtony](https://togithub.com/yanggangtony) made their
first contribution in
[kubernetes-sigs/descheduler#1103
- [@&#8203;AllenZMC](https://togithub.com/AllenZMC) made their first
contribution in
[kubernetes-sigs/descheduler#1135

**Full Changelog**:
kubernetes-sigs/descheduler@v0.26.0...v0.27.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/teutonet/teutonet-helm-charts).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43MS40IiwidXBkYXRlZEluVmVyIjoiMzUuNzEuNCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants