Do some code cleans.

[yanggangtony]

/kind cleanup

Its just some tiny code cleans..

[ingvagabund]

This assumes GetPluginConfig always returns idx == 0 for when defaultevictorPluginConfig == nil. That is another assumption that can be broken without noticing. GetPluginConfig could be later re-implement for non-sequential iteration and return anything other than 0 if not entry is found. Better keep it as it is.

[yanggangtony]

thanks for review.
Will rollback it.

[ingvagabund]

setErrorsInProfiles is used only once. Worth making it inline.

[yanggangtony]

sound good.
update it.

[ingvagabund]

We need to fail in case registry[pluginConfig.Name] does not exists. E.g.:

if _, ok := registry[pluginConfig.Name]; !ok {
	errorsInProfiles = fmt.Errorf("%w: %s", errorsInProfiles, fmt.Sprintf("in profile %s: plugin %s in pluginConfig not registered", profile.Name, pluginConfig.Name))
	continue
}
pluginUtilities := registry[pluginConfig.Name]
if pluginUtilities.PluginArgValidator == nil {
	continue
}
err := pluginUtilities.PluginArgValidator(pluginConfig.Args)
...

This will also reduce the level of nesting by 2.

[yanggangtony]

Good suggestion.
Update later.

[yanggangtony]

@ingvagabund
Thanks for your review.
Rebased again.

[ingvagabund]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ingvagabund]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ingvagabund]

/lgtm

[yanggangtony]

thanks.
@ingvagabund