nodefit: use info log level when pod doesn't fit #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
Welcome @antoinedeschenes! |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @antoinedeschenes. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XS
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
antoinedeschenes
changed the title
a7i
reviewed
Aug 22, 2023
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
|
/retitle nodefit: use info log level when pod doesn't fit |
k8s-ci-robot
changed the title
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a7i The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@a7i Do you need me to squash the commits? |
|
I have already added the squash label so prow will do it. Just need a lgtm from another reviewer (since it's a change in logging behavior) |
k8s-ci-robot
added
the
needs-rebase
Pods that don't pass the nodeFit condition currently log an unsuppressable error message to logs. This changes the log level to info as it's a normal operating condition. Signed-off-by: Antoine Deschênes <antoine.deschenes@linux.com>
antoinedeschenes
force-pushed
the
nodefit-loglevel
branch
from
8f969e8
to
62991e0
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/unhold thank you for your contribution! |
k8s-ci-robot
removed
the
do-not-merge/hold
coolguy1771
pushed a commit
to coolguy1771/home-ops
that referenced
this pull request
Jan 4, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.28.1` -> `0.29.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.29.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.29.0): Descheduler v0.29.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.28.1...v0.29.0) #### What's Changed - topologySpreadConstraints: handle `nodeTaintsPolicy` and `nodeAffinityPolicy` constraints by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1218 - fix: structured err logs in eviction by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1228 - helm: update cronjob args argument to avoid unmarshal error by [@​cayla](https://togithub.com/cayla) in [kubernetes-sigs/descheduler#1229 - fix: golangci config by [@​jklaw90](https://togithub.com/jklaw90) in [kubernetes-sigs/descheduler#1242 - docs: fix evictableNamespaces example by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1241 - update image references to point to v0.28.0 by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1246 - nodefit: use info log level when pod doesn't fit by [@​antoinedeschenes](https://togithub.com/antoinedeschenes) in [kubernetes-sigs/descheduler#1220 - helm: support of `timeZone` for CronJob by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1245 - helm: ability to specify `dnsConfig` by [@​audip](https://togithub.com/audip) in [kubernetes-sigs/descheduler#1260 - Bump dependencies to address CVE-2023-44487 by [@​ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1263 - CVE 2023 44487 fixes by [@​ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1270 - bump deps for CVE-2023-25151 by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1277 - topologyspreadconstraint: support `matchLabelKeys` by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1233 - fix: display ownerKey in the logs correctly by [@​dimunech](https://togithub.com/dimunech) in [kubernetes-sigs/descheduler#1281 - fix: version skew compatibility for managed kubernetes providers by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1249 - adding jklaw90 to reviewers by [@​jklaw90](https://togithub.com/jklaw90) in [kubernetes-sigs/descheduler#1276 - copy cherry_pick_pull script form kubernetes/kubernetes by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1282 - CVE-2023-47108: replace otelgrpc version by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1293 - fix: json logging by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1296 - Make the logged nodeutilization percentages human-readable by [@​PeterSzegedi](https://togithub.com/PeterSzegedi) in [kubernetes-sigs/descheduler#1294 - fix: revert defer of context done by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1299 - chore: upgrade libs to kubernetes 0.28.4 and matching go version by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1292 - release v0.28.1: bump helm chart and images by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1305 - helm: ability to specify security context for pod by [@​victorgs](https://togithub.com/victorgs) in [kubernetes-sigs/descheduler#1311 - helm: allow configuration of ipFamilyPolicy by [@​dongjiang1989](https://togithub.com/dongjiang1989) in [kubernetes-sigs/descheduler#1314 - fix: topologySpreadConstraint fields in structured logs by [@​SataQiu](https://togithub.com/SataQiu) in [kubernetes-sigs/descheduler#1317 - `PodLifeTime`: consider pods with container status `ImagePullBackOff` by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1318 - kubernetes 1.29: update deps and go-version by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1322 - `CVE-2023-48795`: bump k8s deps by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1333 #### New Contributors - [@​cayla](https://togithub.com/cayla) made their first contribution in [kubernetes-sigs/descheduler#1229 - [@​dimunech](https://togithub.com/dimunech) made their first contribution in [kubernetes-sigs/descheduler#1281 - [@​PeterSzegedi](https://togithub.com/PeterSzegedi) made their first contribution in [kubernetes-sigs/descheduler#1294 - [@​victorgs](https://togithub.com/victorgs) made their first contribution in [kubernetes-sigs/descheduler#1311 - [@​SataQiu](https://togithub.com/SataQiu) made their first contribution in [kubernetes-sigs/descheduler#1317 **Full Changelog**: kubernetes-sigs/descheduler@v0.28.0...v0.29.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMTYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjExNi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
spiceratops
added a commit
to spiceratops/k8s-gitops
that referenced
this pull request
Jan 5, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.28.1` -> `0.29.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.29.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.29.0): Descheduler v0.29.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.28.1...v0.29.0) #### What's Changed - topologySpreadConstraints: handle `nodeTaintsPolicy` and `nodeAffinityPolicy` constraints by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1218 - fix: structured err logs in eviction by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1228 - helm: update cronjob args argument to avoid unmarshal error by [@​cayla](https://togithub.com/cayla) in [kubernetes-sigs/descheduler#1229 - fix: golangci config by [@​jklaw90](https://togithub.com/jklaw90) in [kubernetes-sigs/descheduler#1242 - docs: fix evictableNamespaces example by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1241 - update image references to point to v0.28.0 by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1246 - nodefit: use info log level when pod doesn't fit by [@​antoinedeschenes](https://togithub.com/antoinedeschenes) in [kubernetes-sigs/descheduler#1220 - helm: support of `timeZone` for CronJob by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1245 - helm: ability to specify `dnsConfig` by [@​audip](https://togithub.com/audip) in [kubernetes-sigs/descheduler#1260 - Bump dependencies to address CVE-2023-44487 by [@​ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1263 - CVE 2023 44487 fixes by [@​ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1270 - bump deps for CVE-2023-25151 by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1277 - topologyspreadconstraint: support `matchLabelKeys` by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1233 - fix: display ownerKey in the logs correctly by [@​dimunech](https://togithub.com/dimunech) in [kubernetes-sigs/descheduler#1281 - fix: version skew compatibility for managed kubernetes providers by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1249 - adding jklaw90 to reviewers by [@​jklaw90](https://togithub.com/jklaw90) in [kubernetes-sigs/descheduler#1276 - copy cherry_pick_pull script form kubernetes/kubernetes by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1282 - CVE-2023-47108: replace otelgrpc version by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1293 - fix: json logging by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1296 - Make the logged nodeutilization percentages human-readable by [@​PeterSzegedi](https://togithub.com/PeterSzegedi) in [kubernetes-sigs/descheduler#1294 - fix: revert defer of context done by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1299 - chore: upgrade libs to kubernetes 0.28.4 and matching go version by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1292 - release v0.28.1: bump helm chart and images by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1305 - helm: ability to specify security context for pod by [@​victorgs](https://togithub.com/victorgs) in [kubernetes-sigs/descheduler#1311 - helm: allow configuration of ipFamilyPolicy by [@​dongjiang1989](https://togithub.com/dongjiang1989) in [kubernetes-sigs/descheduler#1314 - fix: topologySpreadConstraint fields in structured logs by [@​SataQiu](https://togithub.com/SataQiu) in [kubernetes-sigs/descheduler#1317 - `PodLifeTime`: consider pods with container status `ImagePullBackOff` by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1318 - kubernetes 1.29: update deps and go-version by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1322 - `CVE-2023-48795`: bump k8s deps by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1333 #### New Contributors - [@​cayla](https://togithub.com/cayla) made their first contribution in [kubernetes-sigs/descheduler#1229 - [@​dimunech](https://togithub.com/dimunech) made their first contribution in [kubernetes-sigs/descheduler#1281 - [@​PeterSzegedi](https://togithub.com/PeterSzegedi) made their first contribution in [kubernetes-sigs/descheduler#1294 - [@​victorgs](https://togithub.com/victorgs) made their first contribution in [kubernetes-sigs/descheduler#1311 - [@​SataQiu](https://togithub.com/SataQiu) made their first contribution in [kubernetes-sigs/descheduler#1317 **Full Changelog**: kubernetes-sigs/descheduler@v0.28.0...v0.29.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMTYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjExNi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
renovate bot
added a commit
to teutonet/teutonet-helm-charts
that referenced
this pull request
Feb 13, 2024
…0.29.x (#704) [](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.28.x` -> `0.29.x` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.29.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.29.0): Descheduler v0.29.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.28.1...v0.29.0) #### What's Changed - topologySpreadConstraints: handle `nodeTaintsPolicy` and `nodeAffinityPolicy` constraints by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1218 - fix: structured err logs in eviction by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1228 - helm: update cronjob args argument to avoid unmarshal error by [@​cayla](https://togithub.com/cayla) in [kubernetes-sigs/descheduler#1229 - fix: golangci config by [@​jklaw90](https://togithub.com/jklaw90) in [kubernetes-sigs/descheduler#1242 - docs: fix evictableNamespaces example by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1241 - update image references to point to v0.28.0 by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1246 - nodefit: use info log level when pod doesn't fit by [@​antoinedeschenes](https://togithub.com/antoinedeschenes) in [kubernetes-sigs/descheduler#1220 - helm: support of `timeZone` for CronJob by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1245 - helm: ability to specify `dnsConfig` by [@​audip](https://togithub.com/audip) in [kubernetes-sigs/descheduler#1260 - Bump dependencies to address CVE-2023-44487 by [@​ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1263 - CVE 2023 44487 fixes by [@​ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1270 - bump deps for CVE-2023-25151 by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1277 - topologyspreadconstraint: support `matchLabelKeys` by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1233 - fix: display ownerKey in the logs correctly by [@​dimunech](https://togithub.com/dimunech) in [kubernetes-sigs/descheduler#1281 - fix: version skew compatibility for managed kubernetes providers by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1249 - adding jklaw90 to reviewers by [@​jklaw90](https://togithub.com/jklaw90) in [kubernetes-sigs/descheduler#1276 - copy cherry_pick_pull script form kubernetes/kubernetes by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1282 - CVE-2023-47108: replace otelgrpc version by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1293 - fix: json logging by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1296 - Make the logged nodeutilization percentages human-readable by [@​PeterSzegedi](https://togithub.com/PeterSzegedi) in [kubernetes-sigs/descheduler#1294 - fix: revert defer of context done by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1299 - chore: upgrade libs to kubernetes 0.28.4 and matching go version by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1292 - release v0.28.1: bump helm chart and images by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1305 - helm: ability to specify security context for pod by [@​victorgs](https://togithub.com/victorgs) in [kubernetes-sigs/descheduler#1311 - helm: allow configuration of ipFamilyPolicy by [@​dongjiang1989](https://togithub.com/dongjiang1989) in [kubernetes-sigs/descheduler#1314 - fix: topologySpreadConstraint fields in structured logs by [@​SataQiu](https://togithub.com/SataQiu) in [kubernetes-sigs/descheduler#1317 - `PodLifeTime`: consider pods with container status `ImagePullBackOff` by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1318 - kubernetes 1.29: update deps and go-version by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1322 - `CVE-2023-48795`: bump k8s deps by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1333 #### New Contributors - [@​cayla](https://togithub.com/cayla) made their first contribution in [kubernetes-sigs/descheduler#1229 - [@​dimunech](https://togithub.com/dimunech) made their first contribution in [kubernetes-sigs/descheduler#1281 - [@​PeterSzegedi](https://togithub.com/PeterSzegedi) made their first contribution in [kubernetes-sigs/descheduler#1294 - [@​victorgs](https://togithub.com/victorgs) made their first contribution in [kubernetes-sigs/descheduler#1311 - [@​SataQiu](https://togithub.com/SataQiu) made their first contribution in [kubernetes-sigs/descheduler#1317 **Full Changelog**: kubernetes-sigs/descheduler@v0.28.0...v0.29.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/teutonet/teutonet-helm-charts). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Chris Werner Rau <cwr@teuto.net>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pods that don't pass the nodeFit condition currently log an unsuppressable error message to logs. This changes the log level to info as it's a normal operating condition.