-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
topologyspreadconstraint: support matchLabelKeys
#1233
Conversation
matchLabelKeys
eccf9d7
to
c8faf7a
Compare
/cc @ingvagabund |
pkg/framework/plugins/removepodsviolatingtopologyspreadconstraint/topologyspreadconstraint.go
Outdated
Show resolved
Hide resolved
3afad7b
to
35d4168
Compare
if _, err := clientSet.CoreV1().ReplicationControllers(rc.Namespace).Create(ctx, rc, metav1.CreateOptions{}); err != nil { | ||
t.Fatalf("Error creating RC %s %v", name, err) | ||
t.Logf("Creating Deployment %s with %d replicas", name, tc.replicaCount) | ||
deployment := test.BuildTestDeployment(name, testNamespace.Name, int32(tc.replicaCount), tc.topologySpreadConstraint.LabelSelector.DeepCopy().MatchLabels, func(d *appsv1.Deployment) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the e2e tests have to be updated to use Deployment instead of RC. That's because for matchLabelKeys, we want to rely on pod-template-hash
which is generated by the replicaset
35d4168
to
e1bc882
Compare
This |
@knelasevero updated the docs. Would you please take a look? also @ingvagabund need help moving this forward since this was officially supported in 1.27 but not in Descheduler 0.27 and 0.28 |
Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
…itialization Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
/lgtm /hold Hold for a bit to see if Jan has any comments, we can merge by eow if no comments or when another person has eyes on it |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@a7i this looks great. Thank you for all the refactoring. |
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.28.1` -> `0.29.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.29.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.29.0): Descheduler v0.29.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.28.1...v0.29.0) #### What's Changed - topologySpreadConstraints: handle `nodeTaintsPolicy` and `nodeAffinityPolicy` constraints by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1218](https://togithub.com/kubernetes-sigs/descheduler/pull/1218) - fix: structured err logs in eviction by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1228](https://togithub.com/kubernetes-sigs/descheduler/pull/1228) - helm: update cronjob args argument to avoid unmarshal error by [@​cayla](https://togithub.com/cayla) in [https://github.com/kubernetes-sigs/descheduler/pull/1229](https://togithub.com/kubernetes-sigs/descheduler/pull/1229) - fix: golangci config by [@​jklaw90](https://togithub.com/jklaw90) in [https://github.com/kubernetes-sigs/descheduler/pull/1242](https://togithub.com/kubernetes-sigs/descheduler/pull/1242) - docs: fix evictableNamespaces example by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1241](https://togithub.com/kubernetes-sigs/descheduler/pull/1241) - update image references to point to v0.28.0 by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1246](https://togithub.com/kubernetes-sigs/descheduler/pull/1246) - nodefit: use info log level when pod doesn't fit by [@​antoinedeschenes](https://togithub.com/antoinedeschenes) in [https://github.com/kubernetes-sigs/descheduler/pull/1220](https://togithub.com/kubernetes-sigs/descheduler/pull/1220) - helm: support of `timeZone` for CronJob by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1245](https://togithub.com/kubernetes-sigs/descheduler/pull/1245) - helm: ability to specify `dnsConfig` by [@​audip](https://togithub.com/audip) in [https://github.com/kubernetes-sigs/descheduler/pull/1260](https://togithub.com/kubernetes-sigs/descheduler/pull/1260) - Bump dependencies to address CVE-2023-44487 by [@​ingvagabund](https://togithub.com/ingvagabund) in [https://github.com/kubernetes-sigs/descheduler/pull/1263](https://togithub.com/kubernetes-sigs/descheduler/pull/1263) - CVE 2023 44487 fixes by [@​ingvagabund](https://togithub.com/ingvagabund) in [https://github.com/kubernetes-sigs/descheduler/pull/1270](https://togithub.com/kubernetes-sigs/descheduler/pull/1270) - bump deps for CVE-2023-25151 by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1277](https://togithub.com/kubernetes-sigs/descheduler/pull/1277) - topologyspreadconstraint: support `matchLabelKeys` by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1233](https://togithub.com/kubernetes-sigs/descheduler/pull/1233) - fix: display ownerKey in the logs correctly by [@​dimunech](https://togithub.com/dimunech) in [https://github.com/kubernetes-sigs/descheduler/pull/1281](https://togithub.com/kubernetes-sigs/descheduler/pull/1281) - fix: version skew compatibility for managed kubernetes providers by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1249](https://togithub.com/kubernetes-sigs/descheduler/pull/1249) - adding jklaw90 to reviewers by [@​jklaw90](https://togithub.com/jklaw90) in [https://github.com/kubernetes-sigs/descheduler/pull/1276](https://togithub.com/kubernetes-sigs/descheduler/pull/1276) - copy cherry_pick_pull script form kubernetes/kubernetes by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1282](https://togithub.com/kubernetes-sigs/descheduler/pull/1282) - CVE-2023-47108: replace otelgrpc version by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1293](https://togithub.com/kubernetes-sigs/descheduler/pull/1293) - fix: json logging by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1296](https://togithub.com/kubernetes-sigs/descheduler/pull/1296) - Make the logged nodeutilization percentages human-readable by [@​PeterSzegedi](https://togithub.com/PeterSzegedi) in [https://github.com/kubernetes-sigs/descheduler/pull/1294](https://togithub.com/kubernetes-sigs/descheduler/pull/1294) - fix: revert defer of context done by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1299](https://togithub.com/kubernetes-sigs/descheduler/pull/1299) - chore: upgrade libs to kubernetes 0.28.4 and matching go version by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1292](https://togithub.com/kubernetes-sigs/descheduler/pull/1292) - release v0.28.1: bump helm chart and images by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1305](https://togithub.com/kubernetes-sigs/descheduler/pull/1305) - helm: ability to specify security context for pod by [@​victorgs](https://togithub.com/victorgs) in [https://github.com/kubernetes-sigs/descheduler/pull/1311](https://togithub.com/kubernetes-sigs/descheduler/pull/1311) - helm: allow configuration of ipFamilyPolicy by [@​dongjiang1989](https://togithub.com/dongjiang1989) in [https://github.com/kubernetes-sigs/descheduler/pull/1314](https://togithub.com/kubernetes-sigs/descheduler/pull/1314) - fix: topologySpreadConstraint fields in structured logs by [@​SataQiu](https://togithub.com/SataQiu) in [https://github.com/kubernetes-sigs/descheduler/pull/1317](https://togithub.com/kubernetes-sigs/descheduler/pull/1317) - `PodLifeTime`: consider pods with container status `ImagePullBackOff` by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1318](https://togithub.com/kubernetes-sigs/descheduler/pull/1318) - kubernetes 1.29: update deps and go-version by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1322](https://togithub.com/kubernetes-sigs/descheduler/pull/1322) - `CVE-2023-48795`: bump k8s deps by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1333](https://togithub.com/kubernetes-sigs/descheduler/pull/1333) #### New Contributors - [@​cayla](https://togithub.com/cayla) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1229](https://togithub.com/kubernetes-sigs/descheduler/pull/1229) - [@​dimunech](https://togithub.com/dimunech) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1281](https://togithub.com/kubernetes-sigs/descheduler/pull/1281) - [@​PeterSzegedi](https://togithub.com/PeterSzegedi) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1294](https://togithub.com/kubernetes-sigs/descheduler/pull/1294) - [@​victorgs](https://togithub.com/victorgs) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1311](https://togithub.com/kubernetes-sigs/descheduler/pull/1311) - [@​SataQiu](https://togithub.com/SataQiu) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1317](https://togithub.com/kubernetes-sigs/descheduler/pull/1317) **Full Changelog**: kubernetes-sigs/descheduler@v0.28.0...v0.29.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMTYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjExNi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.28.1` -> `0.29.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.29.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.29.0): Descheduler v0.29.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.28.1...v0.29.0) #### What's Changed - topologySpreadConstraints: handle `nodeTaintsPolicy` and `nodeAffinityPolicy` constraints by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1218](https://togithub.com/kubernetes-sigs/descheduler/pull/1218) - fix: structured err logs in eviction by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1228](https://togithub.com/kubernetes-sigs/descheduler/pull/1228) - helm: update cronjob args argument to avoid unmarshal error by [@​cayla](https://togithub.com/cayla) in [https://github.com/kubernetes-sigs/descheduler/pull/1229](https://togithub.com/kubernetes-sigs/descheduler/pull/1229) - fix: golangci config by [@​jklaw90](https://togithub.com/jklaw90) in [https://github.com/kubernetes-sigs/descheduler/pull/1242](https://togithub.com/kubernetes-sigs/descheduler/pull/1242) - docs: fix evictableNamespaces example by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1241](https://togithub.com/kubernetes-sigs/descheduler/pull/1241) - update image references to point to v0.28.0 by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1246](https://togithub.com/kubernetes-sigs/descheduler/pull/1246) - nodefit: use info log level when pod doesn't fit by [@​antoinedeschenes](https://togithub.com/antoinedeschenes) in [https://github.com/kubernetes-sigs/descheduler/pull/1220](https://togithub.com/kubernetes-sigs/descheduler/pull/1220) - helm: support of `timeZone` for CronJob by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1245](https://togithub.com/kubernetes-sigs/descheduler/pull/1245) - helm: ability to specify `dnsConfig` by [@​audip](https://togithub.com/audip) in [https://github.com/kubernetes-sigs/descheduler/pull/1260](https://togithub.com/kubernetes-sigs/descheduler/pull/1260) - Bump dependencies to address CVE-2023-44487 by [@​ingvagabund](https://togithub.com/ingvagabund) in [https://github.com/kubernetes-sigs/descheduler/pull/1263](https://togithub.com/kubernetes-sigs/descheduler/pull/1263) - CVE 2023 44487 fixes by [@​ingvagabund](https://togithub.com/ingvagabund) in [https://github.com/kubernetes-sigs/descheduler/pull/1270](https://togithub.com/kubernetes-sigs/descheduler/pull/1270) - bump deps for CVE-2023-25151 by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1277](https://togithub.com/kubernetes-sigs/descheduler/pull/1277) - topologyspreadconstraint: support `matchLabelKeys` by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1233](https://togithub.com/kubernetes-sigs/descheduler/pull/1233) - fix: display ownerKey in the logs correctly by [@​dimunech](https://togithub.com/dimunech) in [https://github.com/kubernetes-sigs/descheduler/pull/1281](https://togithub.com/kubernetes-sigs/descheduler/pull/1281) - fix: version skew compatibility for managed kubernetes providers by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1249](https://togithub.com/kubernetes-sigs/descheduler/pull/1249) - adding jklaw90 to reviewers by [@​jklaw90](https://togithub.com/jklaw90) in [https://github.com/kubernetes-sigs/descheduler/pull/1276](https://togithub.com/kubernetes-sigs/descheduler/pull/1276) - copy cherry_pick_pull script form kubernetes/kubernetes by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1282](https://togithub.com/kubernetes-sigs/descheduler/pull/1282) - CVE-2023-47108: replace otelgrpc version by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1293](https://togithub.com/kubernetes-sigs/descheduler/pull/1293) - fix: json logging by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1296](https://togithub.com/kubernetes-sigs/descheduler/pull/1296) - Make the logged nodeutilization percentages human-readable by [@​PeterSzegedi](https://togithub.com/PeterSzegedi) in [https://github.com/kubernetes-sigs/descheduler/pull/1294](https://togithub.com/kubernetes-sigs/descheduler/pull/1294) - fix: revert defer of context done by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1299](https://togithub.com/kubernetes-sigs/descheduler/pull/1299) - chore: upgrade libs to kubernetes 0.28.4 and matching go version by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1292](https://togithub.com/kubernetes-sigs/descheduler/pull/1292) - release v0.28.1: bump helm chart and images by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1305](https://togithub.com/kubernetes-sigs/descheduler/pull/1305) - helm: ability to specify security context for pod by [@​victorgs](https://togithub.com/victorgs) in [https://github.com/kubernetes-sigs/descheduler/pull/1311](https://togithub.com/kubernetes-sigs/descheduler/pull/1311) - helm: allow configuration of ipFamilyPolicy by [@​dongjiang1989](https://togithub.com/dongjiang1989) in [https://github.com/kubernetes-sigs/descheduler/pull/1314](https://togithub.com/kubernetes-sigs/descheduler/pull/1314) - fix: topologySpreadConstraint fields in structured logs by [@​SataQiu](https://togithub.com/SataQiu) in [https://github.com/kubernetes-sigs/descheduler/pull/1317](https://togithub.com/kubernetes-sigs/descheduler/pull/1317) - `PodLifeTime`: consider pods with container status `ImagePullBackOff` by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1318](https://togithub.com/kubernetes-sigs/descheduler/pull/1318) - kubernetes 1.29: update deps and go-version by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1322](https://togithub.com/kubernetes-sigs/descheduler/pull/1322) - `CVE-2023-48795`: bump k8s deps by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1333](https://togithub.com/kubernetes-sigs/descheduler/pull/1333) #### New Contributors - [@​cayla](https://togithub.com/cayla) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1229](https://togithub.com/kubernetes-sigs/descheduler/pull/1229) - [@​dimunech](https://togithub.com/dimunech) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1281](https://togithub.com/kubernetes-sigs/descheduler/pull/1281) - [@​PeterSzegedi](https://togithub.com/PeterSzegedi) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1294](https://togithub.com/kubernetes-sigs/descheduler/pull/1294) - [@​victorgs](https://togithub.com/victorgs) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1311](https://togithub.com/kubernetes-sigs/descheduler/pull/1311) - [@​SataQiu](https://togithub.com/SataQiu) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1317](https://togithub.com/kubernetes-sigs/descheduler/pull/1317) **Full Changelog**: kubernetes-sigs/descheduler@v0.28.0...v0.29.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMTYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjExNi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
…0.29.x (#704) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.28.x` -> `0.29.x` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.29.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.29.0): Descheduler v0.29.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.28.1...v0.29.0) #### What's Changed - topologySpreadConstraints: handle `nodeTaintsPolicy` and `nodeAffinityPolicy` constraints by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1218](https://togithub.com/kubernetes-sigs/descheduler/pull/1218) - fix: structured err logs in eviction by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1228](https://togithub.com/kubernetes-sigs/descheduler/pull/1228) - helm: update cronjob args argument to avoid unmarshal error by [@​cayla](https://togithub.com/cayla) in [https://github.com/kubernetes-sigs/descheduler/pull/1229](https://togithub.com/kubernetes-sigs/descheduler/pull/1229) - fix: golangci config by [@​jklaw90](https://togithub.com/jklaw90) in [https://github.com/kubernetes-sigs/descheduler/pull/1242](https://togithub.com/kubernetes-sigs/descheduler/pull/1242) - docs: fix evictableNamespaces example by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1241](https://togithub.com/kubernetes-sigs/descheduler/pull/1241) - update image references to point to v0.28.0 by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1246](https://togithub.com/kubernetes-sigs/descheduler/pull/1246) - nodefit: use info log level when pod doesn't fit by [@​antoinedeschenes](https://togithub.com/antoinedeschenes) in [https://github.com/kubernetes-sigs/descheduler/pull/1220](https://togithub.com/kubernetes-sigs/descheduler/pull/1220) - helm: support of `timeZone` for CronJob by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1245](https://togithub.com/kubernetes-sigs/descheduler/pull/1245) - helm: ability to specify `dnsConfig` by [@​audip](https://togithub.com/audip) in [https://github.com/kubernetes-sigs/descheduler/pull/1260](https://togithub.com/kubernetes-sigs/descheduler/pull/1260) - Bump dependencies to address CVE-2023-44487 by [@​ingvagabund](https://togithub.com/ingvagabund) in [https://github.com/kubernetes-sigs/descheduler/pull/1263](https://togithub.com/kubernetes-sigs/descheduler/pull/1263) - CVE 2023 44487 fixes by [@​ingvagabund](https://togithub.com/ingvagabund) in [https://github.com/kubernetes-sigs/descheduler/pull/1270](https://togithub.com/kubernetes-sigs/descheduler/pull/1270) - bump deps for CVE-2023-25151 by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1277](https://togithub.com/kubernetes-sigs/descheduler/pull/1277) - topologyspreadconstraint: support `matchLabelKeys` by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1233](https://togithub.com/kubernetes-sigs/descheduler/pull/1233) - fix: display ownerKey in the logs correctly by [@​dimunech](https://togithub.com/dimunech) in [https://github.com/kubernetes-sigs/descheduler/pull/1281](https://togithub.com/kubernetes-sigs/descheduler/pull/1281) - fix: version skew compatibility for managed kubernetes providers by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1249](https://togithub.com/kubernetes-sigs/descheduler/pull/1249) - adding jklaw90 to reviewers by [@​jklaw90](https://togithub.com/jklaw90) in [https://github.com/kubernetes-sigs/descheduler/pull/1276](https://togithub.com/kubernetes-sigs/descheduler/pull/1276) - copy cherry_pick_pull script form kubernetes/kubernetes by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1282](https://togithub.com/kubernetes-sigs/descheduler/pull/1282) - CVE-2023-47108: replace otelgrpc version by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1293](https://togithub.com/kubernetes-sigs/descheduler/pull/1293) - fix: json logging by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1296](https://togithub.com/kubernetes-sigs/descheduler/pull/1296) - Make the logged nodeutilization percentages human-readable by [@​PeterSzegedi](https://togithub.com/PeterSzegedi) in [https://github.com/kubernetes-sigs/descheduler/pull/1294](https://togithub.com/kubernetes-sigs/descheduler/pull/1294) - fix: revert defer of context done by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1299](https://togithub.com/kubernetes-sigs/descheduler/pull/1299) - chore: upgrade libs to kubernetes 0.28.4 and matching go version by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1292](https://togithub.com/kubernetes-sigs/descheduler/pull/1292) - release v0.28.1: bump helm chart and images by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1305](https://togithub.com/kubernetes-sigs/descheduler/pull/1305) - helm: ability to specify security context for pod by [@​victorgs](https://togithub.com/victorgs) in [https://github.com/kubernetes-sigs/descheduler/pull/1311](https://togithub.com/kubernetes-sigs/descheduler/pull/1311) - helm: allow configuration of ipFamilyPolicy by [@​dongjiang1989](https://togithub.com/dongjiang1989) in [https://github.com/kubernetes-sigs/descheduler/pull/1314](https://togithub.com/kubernetes-sigs/descheduler/pull/1314) - fix: topologySpreadConstraint fields in structured logs by [@​SataQiu](https://togithub.com/SataQiu) in [https://github.com/kubernetes-sigs/descheduler/pull/1317](https://togithub.com/kubernetes-sigs/descheduler/pull/1317) - `PodLifeTime`: consider pods with container status `ImagePullBackOff` by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1318](https://togithub.com/kubernetes-sigs/descheduler/pull/1318) - kubernetes 1.29: update deps and go-version by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1322](https://togithub.com/kubernetes-sigs/descheduler/pull/1322) - `CVE-2023-48795`: bump k8s deps by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1333](https://togithub.com/kubernetes-sigs/descheduler/pull/1333) #### New Contributors - [@​cayla](https://togithub.com/cayla) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1229](https://togithub.com/kubernetes-sigs/descheduler/pull/1229) - [@​dimunech](https://togithub.com/dimunech) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1281](https://togithub.com/kubernetes-sigs/descheduler/pull/1281) - [@​PeterSzegedi](https://togithub.com/PeterSzegedi) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1294](https://togithub.com/kubernetes-sigs/descheduler/pull/1294) - [@​victorgs](https://togithub.com/victorgs) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1311](https://togithub.com/kubernetes-sigs/descheduler/pull/1311) - [@​SataQiu](https://togithub.com/SataQiu) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1317](https://togithub.com/kubernetes-sigs/descheduler/pull/1317) **Full Changelog**: kubernetes-sigs/descheduler@v0.28.0...v0.29.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/teutonet/teutonet-helm-charts). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Chris Werner Rau <cwr@teuto.net>
Closes #1171
In Kubernetes 1.27, this feature flag was graduated to beta and it respects topology spread constraints during rolling upgrades. Descheduler currently does not honor this and apps could get unnecessary evictions during rolling upgrade
Ref: kubernetes/enhancements#3243