Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topologyspreadconstraint: support matchLabelKeys #1233

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Aug 28, 2023

Closes #1171

In Kubernetes 1.27, this feature flag was graduated to beta and it respects topology spread constraints during rolling upgrades. Descheduler currently does not honor this and apps could get unnecessary evictions during rolling upgrade

Ref: kubernetes/enhancements#3243

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 28, 2023
@a7i a7i changed the title topologyspreadconstraint: support topologyspreadconstraint: support matchLabelKeys Aug 28, 2023
@a7i a7i force-pushed the match-label-keys branch 4 times, most recently from eccf9d7 to c8faf7a Compare August 28, 2023 16:00
@a7i
Copy link
Contributor Author

a7i commented Sep 1, 2023

/cc @ingvagabund

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 4, 2023
if _, err := clientSet.CoreV1().ReplicationControllers(rc.Namespace).Create(ctx, rc, metav1.CreateOptions{}); err != nil {
t.Fatalf("Error creating RC %s %v", name, err)
t.Logf("Creating Deployment %s with %d replicas", name, tc.replicaCount)
deployment := test.BuildTestDeployment(name, testNamespace.Name, int32(tc.replicaCount), tc.topologySpreadConstraint.LabelSelector.DeepCopy().MatchLabels, func(d *appsv1.Deployment) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the e2e tests have to be updated to use Deployment instead of RC. That's because for matchLabelKeys, we want to rely on pod-template-hash which is generated by the replicaset

@knelasevero
Copy link
Contributor

This
/lgtm
would it make sense to add a bit about this in our docs?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2023
@a7i
Copy link
Contributor Author

a7i commented Oct 27, 2023

@knelasevero updated the docs.

Would you please take a look? also @ingvagabund need help moving this forward since this was officially supported in 1.27 but not in Descheduler 0.27 and 0.28

Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
…itialization

Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
@knelasevero
Copy link
Contributor

/lgtm

/hold

Hold for a bit to see if Jan has any comments, we can merge by eow if no comments or when another person has eyes on it

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 30, 2023
@ingvagabund
Copy link
Contributor

/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023
@ingvagabund
Copy link
Contributor

@a7i this looks great. Thank you for all the refactoring.

@k8s-ci-robot k8s-ci-robot merged commit c4ab200 into kubernetes-sigs:master Oct 31, 2023
10 checks passed
@a7i a7i deleted the match-label-keys branch October 31, 2023 11:43
coolguy1771 referenced this pull request in coolguy1771/home-ops Jan 4, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [descheduler](https://togithub.com/kubernetes-sigs/descheduler) |
minor | `0.28.1` -> `0.29.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>kubernetes-sigs/descheduler (descheduler)</summary>

###
[`v0.29.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.29.0):
Descheduler v0.29.0

[Compare
Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.28.1...v0.29.0)

#### What's Changed

- topologySpreadConstraints: handle `nodeTaintsPolicy` and
`nodeAffinityPolicy` constraints by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1218](https://togithub.com/kubernetes-sigs/descheduler/pull/1218)
- fix: structured err logs in eviction by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1228](https://togithub.com/kubernetes-sigs/descheduler/pull/1228)
- helm: update cronjob args argument to avoid unmarshal error by
[@&#8203;cayla](https://togithub.com/cayla) in
[https://github.com/kubernetes-sigs/descheduler/pull/1229](https://togithub.com/kubernetes-sigs/descheduler/pull/1229)
- fix: golangci config by
[@&#8203;jklaw90](https://togithub.com/jklaw90) in
[https://github.com/kubernetes-sigs/descheduler/pull/1242](https://togithub.com/kubernetes-sigs/descheduler/pull/1242)
- docs: fix evictableNamespaces example by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1241](https://togithub.com/kubernetes-sigs/descheduler/pull/1241)
- update image references to point to v0.28.0 by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1246](https://togithub.com/kubernetes-sigs/descheduler/pull/1246)
- nodefit: use info log level when pod doesn't fit by
[@&#8203;antoinedeschenes](https://togithub.com/antoinedeschenes) in
[https://github.com/kubernetes-sigs/descheduler/pull/1220](https://togithub.com/kubernetes-sigs/descheduler/pull/1220)
- helm: support of `timeZone` for CronJob by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1245](https://togithub.com/kubernetes-sigs/descheduler/pull/1245)
- helm: ability to specify `dnsConfig` by
[@&#8203;audip](https://togithub.com/audip) in
[https://github.com/kubernetes-sigs/descheduler/pull/1260](https://togithub.com/kubernetes-sigs/descheduler/pull/1260)
- Bump dependencies to address CVE-2023-44487 by
[@&#8203;ingvagabund](https://togithub.com/ingvagabund) in
[https://github.com/kubernetes-sigs/descheduler/pull/1263](https://togithub.com/kubernetes-sigs/descheduler/pull/1263)
- CVE 2023 44487 fixes by
[@&#8203;ingvagabund](https://togithub.com/ingvagabund) in
[https://github.com/kubernetes-sigs/descheduler/pull/1270](https://togithub.com/kubernetes-sigs/descheduler/pull/1270)
- bump deps for CVE-2023-25151 by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1277](https://togithub.com/kubernetes-sigs/descheduler/pull/1277)
- topologyspreadconstraint: support `matchLabelKeys` by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1233](https://togithub.com/kubernetes-sigs/descheduler/pull/1233)
- fix: display ownerKey in the logs correctly by
[@&#8203;dimunech](https://togithub.com/dimunech) in
[https://github.com/kubernetes-sigs/descheduler/pull/1281](https://togithub.com/kubernetes-sigs/descheduler/pull/1281)
- fix: version skew compatibility for managed kubernetes providers by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1249](https://togithub.com/kubernetes-sigs/descheduler/pull/1249)
- adding jklaw90 to reviewers by
[@&#8203;jklaw90](https://togithub.com/jklaw90) in
[https://github.com/kubernetes-sigs/descheduler/pull/1276](https://togithub.com/kubernetes-sigs/descheduler/pull/1276)
- copy cherry_pick_pull script form kubernetes/kubernetes by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1282](https://togithub.com/kubernetes-sigs/descheduler/pull/1282)
- CVE-2023-47108: replace otelgrpc version by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1293](https://togithub.com/kubernetes-sigs/descheduler/pull/1293)
- fix: json logging by [@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1296](https://togithub.com/kubernetes-sigs/descheduler/pull/1296)
- Make the logged nodeutilization percentages human-readable by
[@&#8203;PeterSzegedi](https://togithub.com/PeterSzegedi) in
[https://github.com/kubernetes-sigs/descheduler/pull/1294](https://togithub.com/kubernetes-sigs/descheduler/pull/1294)
- fix: revert defer of context done by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1299](https://togithub.com/kubernetes-sigs/descheduler/pull/1299)
- chore: upgrade libs to kubernetes 0.28.4 and matching go version by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1292](https://togithub.com/kubernetes-sigs/descheduler/pull/1292)
- release v0.28.1: bump helm chart and images by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1305](https://togithub.com/kubernetes-sigs/descheduler/pull/1305)
- helm: ability to specify security context for pod by
[@&#8203;victorgs](https://togithub.com/victorgs) in
[https://github.com/kubernetes-sigs/descheduler/pull/1311](https://togithub.com/kubernetes-sigs/descheduler/pull/1311)
- helm: allow configuration of ipFamilyPolicy by
[@&#8203;dongjiang1989](https://togithub.com/dongjiang1989) in
[https://github.com/kubernetes-sigs/descheduler/pull/1314](https://togithub.com/kubernetes-sigs/descheduler/pull/1314)
- fix: topologySpreadConstraint fields in structured logs by
[@&#8203;SataQiu](https://togithub.com/SataQiu) in
[https://github.com/kubernetes-sigs/descheduler/pull/1317](https://togithub.com/kubernetes-sigs/descheduler/pull/1317)
- `PodLifeTime`: consider pods with container status `ImagePullBackOff`
by [@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1318](https://togithub.com/kubernetes-sigs/descheduler/pull/1318)
- kubernetes 1.29: update deps and go-version by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1322](https://togithub.com/kubernetes-sigs/descheduler/pull/1322)
- `CVE-2023-48795`: bump k8s deps by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1333](https://togithub.com/kubernetes-sigs/descheduler/pull/1333)

#### New Contributors

- [@&#8203;cayla](https://togithub.com/cayla) made their first
contribution in
[https://github.com/kubernetes-sigs/descheduler/pull/1229](https://togithub.com/kubernetes-sigs/descheduler/pull/1229)
- [@&#8203;dimunech](https://togithub.com/dimunech) made their first
contribution in
[https://github.com/kubernetes-sigs/descheduler/pull/1281](https://togithub.com/kubernetes-sigs/descheduler/pull/1281)
- [@&#8203;PeterSzegedi](https://togithub.com/PeterSzegedi) made their
first contribution in
[https://github.com/kubernetes-sigs/descheduler/pull/1294](https://togithub.com/kubernetes-sigs/descheduler/pull/1294)
- [@&#8203;victorgs](https://togithub.com/victorgs) made their first
contribution in
[https://github.com/kubernetes-sigs/descheduler/pull/1311](https://togithub.com/kubernetes-sigs/descheduler/pull/1311)
- [@&#8203;SataQiu](https://togithub.com/SataQiu) made their first
contribution in
[https://github.com/kubernetes-sigs/descheduler/pull/1317](https://togithub.com/kubernetes-sigs/descheduler/pull/1317)

**Full Changelog**:
kubernetes-sigs/descheduler@v0.28.0...v0.29.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMTYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjExNi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
spiceratops referenced this pull request in spiceratops/k8s-gitops Jan 5, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [descheduler](https://togithub.com/kubernetes-sigs/descheduler) |
minor | `0.28.1` -> `0.29.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>kubernetes-sigs/descheduler (descheduler)</summary>

###
[`v0.29.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.29.0):
Descheduler v0.29.0

[Compare
Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.28.1...v0.29.0)

#### What's Changed

- topologySpreadConstraints: handle `nodeTaintsPolicy` and
`nodeAffinityPolicy` constraints by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1218](https://togithub.com/kubernetes-sigs/descheduler/pull/1218)
- fix: structured err logs in eviction by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1228](https://togithub.com/kubernetes-sigs/descheduler/pull/1228)
- helm: update cronjob args argument to avoid unmarshal error by
[@&#8203;cayla](https://togithub.com/cayla) in
[https://github.com/kubernetes-sigs/descheduler/pull/1229](https://togithub.com/kubernetes-sigs/descheduler/pull/1229)
- fix: golangci config by
[@&#8203;jklaw90](https://togithub.com/jklaw90) in
[https://github.com/kubernetes-sigs/descheduler/pull/1242](https://togithub.com/kubernetes-sigs/descheduler/pull/1242)
- docs: fix evictableNamespaces example by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1241](https://togithub.com/kubernetes-sigs/descheduler/pull/1241)
- update image references to point to v0.28.0 by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1246](https://togithub.com/kubernetes-sigs/descheduler/pull/1246)
- nodefit: use info log level when pod doesn't fit by
[@&#8203;antoinedeschenes](https://togithub.com/antoinedeschenes) in
[https://github.com/kubernetes-sigs/descheduler/pull/1220](https://togithub.com/kubernetes-sigs/descheduler/pull/1220)
- helm: support of `timeZone` for CronJob by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1245](https://togithub.com/kubernetes-sigs/descheduler/pull/1245)
- helm: ability to specify `dnsConfig` by
[@&#8203;audip](https://togithub.com/audip) in
[https://github.com/kubernetes-sigs/descheduler/pull/1260](https://togithub.com/kubernetes-sigs/descheduler/pull/1260)
- Bump dependencies to address CVE-2023-44487 by
[@&#8203;ingvagabund](https://togithub.com/ingvagabund) in
[https://github.com/kubernetes-sigs/descheduler/pull/1263](https://togithub.com/kubernetes-sigs/descheduler/pull/1263)
- CVE 2023 44487 fixes by
[@&#8203;ingvagabund](https://togithub.com/ingvagabund) in
[https://github.com/kubernetes-sigs/descheduler/pull/1270](https://togithub.com/kubernetes-sigs/descheduler/pull/1270)
- bump deps for CVE-2023-25151 by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1277](https://togithub.com/kubernetes-sigs/descheduler/pull/1277)
- topologyspreadconstraint: support `matchLabelKeys` by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1233](https://togithub.com/kubernetes-sigs/descheduler/pull/1233)
- fix: display ownerKey in the logs correctly by
[@&#8203;dimunech](https://togithub.com/dimunech) in
[https://github.com/kubernetes-sigs/descheduler/pull/1281](https://togithub.com/kubernetes-sigs/descheduler/pull/1281)
- fix: version skew compatibility for managed kubernetes providers by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1249](https://togithub.com/kubernetes-sigs/descheduler/pull/1249)
- adding jklaw90 to reviewers by
[@&#8203;jklaw90](https://togithub.com/jklaw90) in
[https://github.com/kubernetes-sigs/descheduler/pull/1276](https://togithub.com/kubernetes-sigs/descheduler/pull/1276)
- copy cherry_pick_pull script form kubernetes/kubernetes by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1282](https://togithub.com/kubernetes-sigs/descheduler/pull/1282)
- CVE-2023-47108: replace otelgrpc version by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1293](https://togithub.com/kubernetes-sigs/descheduler/pull/1293)
- fix: json logging by [@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1296](https://togithub.com/kubernetes-sigs/descheduler/pull/1296)
- Make the logged nodeutilization percentages human-readable by
[@&#8203;PeterSzegedi](https://togithub.com/PeterSzegedi) in
[https://github.com/kubernetes-sigs/descheduler/pull/1294](https://togithub.com/kubernetes-sigs/descheduler/pull/1294)
- fix: revert defer of context done by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1299](https://togithub.com/kubernetes-sigs/descheduler/pull/1299)
- chore: upgrade libs to kubernetes 0.28.4 and matching go version by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1292](https://togithub.com/kubernetes-sigs/descheduler/pull/1292)
- release v0.28.1: bump helm chart and images by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1305](https://togithub.com/kubernetes-sigs/descheduler/pull/1305)
- helm: ability to specify security context for pod by
[@&#8203;victorgs](https://togithub.com/victorgs) in
[https://github.com/kubernetes-sigs/descheduler/pull/1311](https://togithub.com/kubernetes-sigs/descheduler/pull/1311)
- helm: allow configuration of ipFamilyPolicy by
[@&#8203;dongjiang1989](https://togithub.com/dongjiang1989) in
[https://github.com/kubernetes-sigs/descheduler/pull/1314](https://togithub.com/kubernetes-sigs/descheduler/pull/1314)
- fix: topologySpreadConstraint fields in structured logs by
[@&#8203;SataQiu](https://togithub.com/SataQiu) in
[https://github.com/kubernetes-sigs/descheduler/pull/1317](https://togithub.com/kubernetes-sigs/descheduler/pull/1317)
- `PodLifeTime`: consider pods with container status `ImagePullBackOff`
by [@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1318](https://togithub.com/kubernetes-sigs/descheduler/pull/1318)
- kubernetes 1.29: update deps and go-version by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1322](https://togithub.com/kubernetes-sigs/descheduler/pull/1322)
- `CVE-2023-48795`: bump k8s deps by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1333](https://togithub.com/kubernetes-sigs/descheduler/pull/1333)

#### New Contributors

- [@&#8203;cayla](https://togithub.com/cayla) made their first
contribution in
[https://github.com/kubernetes-sigs/descheduler/pull/1229](https://togithub.com/kubernetes-sigs/descheduler/pull/1229)
- [@&#8203;dimunech](https://togithub.com/dimunech) made their first
contribution in
[https://github.com/kubernetes-sigs/descheduler/pull/1281](https://togithub.com/kubernetes-sigs/descheduler/pull/1281)
- [@&#8203;PeterSzegedi](https://togithub.com/PeterSzegedi) made their
first contribution in
[https://github.com/kubernetes-sigs/descheduler/pull/1294](https://togithub.com/kubernetes-sigs/descheduler/pull/1294)
- [@&#8203;victorgs](https://togithub.com/victorgs) made their first
contribution in
[https://github.com/kubernetes-sigs/descheduler/pull/1311](https://togithub.com/kubernetes-sigs/descheduler/pull/1311)
- [@&#8203;SataQiu](https://togithub.com/SataQiu) made their first
contribution in
[https://github.com/kubernetes-sigs/descheduler/pull/1317](https://togithub.com/kubernetes-sigs/descheduler/pull/1317)

**Full Changelog**:
kubernetes-sigs/descheduler@v0.28.0...v0.29.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMTYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjExNi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
renovate bot referenced this pull request in teutonet/teutonet-helm-charts Feb 13, 2024
…0.29.x (#704)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [descheduler](https://togithub.com/kubernetes-sigs/descheduler) |
minor | `0.28.x` -> `0.29.x` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>kubernetes-sigs/descheduler (descheduler)</summary>

###
[`v0.29.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.29.0):
Descheduler v0.29.0

[Compare
Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.28.1...v0.29.0)

#### What's Changed

- topologySpreadConstraints: handle `nodeTaintsPolicy` and
`nodeAffinityPolicy` constraints by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1218](https://togithub.com/kubernetes-sigs/descheduler/pull/1218)
- fix: structured err logs in eviction by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1228](https://togithub.com/kubernetes-sigs/descheduler/pull/1228)
- helm: update cronjob args argument to avoid unmarshal error by
[@&#8203;cayla](https://togithub.com/cayla) in
[https://github.com/kubernetes-sigs/descheduler/pull/1229](https://togithub.com/kubernetes-sigs/descheduler/pull/1229)
- fix: golangci config by
[@&#8203;jklaw90](https://togithub.com/jklaw90) in
[https://github.com/kubernetes-sigs/descheduler/pull/1242](https://togithub.com/kubernetes-sigs/descheduler/pull/1242)
- docs: fix evictableNamespaces example by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1241](https://togithub.com/kubernetes-sigs/descheduler/pull/1241)
- update image references to point to v0.28.0 by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1246](https://togithub.com/kubernetes-sigs/descheduler/pull/1246)
- nodefit: use info log level when pod doesn't fit by
[@&#8203;antoinedeschenes](https://togithub.com/antoinedeschenes) in
[https://github.com/kubernetes-sigs/descheduler/pull/1220](https://togithub.com/kubernetes-sigs/descheduler/pull/1220)
- helm: support of `timeZone` for CronJob by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1245](https://togithub.com/kubernetes-sigs/descheduler/pull/1245)
- helm: ability to specify `dnsConfig` by
[@&#8203;audip](https://togithub.com/audip) in
[https://github.com/kubernetes-sigs/descheduler/pull/1260](https://togithub.com/kubernetes-sigs/descheduler/pull/1260)
- Bump dependencies to address CVE-2023-44487 by
[@&#8203;ingvagabund](https://togithub.com/ingvagabund) in
[https://github.com/kubernetes-sigs/descheduler/pull/1263](https://togithub.com/kubernetes-sigs/descheduler/pull/1263)
- CVE 2023 44487 fixes by
[@&#8203;ingvagabund](https://togithub.com/ingvagabund) in
[https://github.com/kubernetes-sigs/descheduler/pull/1270](https://togithub.com/kubernetes-sigs/descheduler/pull/1270)
- bump deps for CVE-2023-25151 by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1277](https://togithub.com/kubernetes-sigs/descheduler/pull/1277)
- topologyspreadconstraint: support `matchLabelKeys` by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1233](https://togithub.com/kubernetes-sigs/descheduler/pull/1233)
- fix: display ownerKey in the logs correctly by
[@&#8203;dimunech](https://togithub.com/dimunech) in
[https://github.com/kubernetes-sigs/descheduler/pull/1281](https://togithub.com/kubernetes-sigs/descheduler/pull/1281)
- fix: version skew compatibility for managed kubernetes providers by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1249](https://togithub.com/kubernetes-sigs/descheduler/pull/1249)
- adding jklaw90 to reviewers by
[@&#8203;jklaw90](https://togithub.com/jklaw90) in
[https://github.com/kubernetes-sigs/descheduler/pull/1276](https://togithub.com/kubernetes-sigs/descheduler/pull/1276)
- copy cherry_pick_pull script form kubernetes/kubernetes by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1282](https://togithub.com/kubernetes-sigs/descheduler/pull/1282)
- CVE-2023-47108: replace otelgrpc version by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1293](https://togithub.com/kubernetes-sigs/descheduler/pull/1293)
- fix: json logging by [@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1296](https://togithub.com/kubernetes-sigs/descheduler/pull/1296)
- Make the logged nodeutilization percentages human-readable by
[@&#8203;PeterSzegedi](https://togithub.com/PeterSzegedi) in
[https://github.com/kubernetes-sigs/descheduler/pull/1294](https://togithub.com/kubernetes-sigs/descheduler/pull/1294)
- fix: revert defer of context done by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1299](https://togithub.com/kubernetes-sigs/descheduler/pull/1299)
- chore: upgrade libs to kubernetes 0.28.4 and matching go version by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1292](https://togithub.com/kubernetes-sigs/descheduler/pull/1292)
- release v0.28.1: bump helm chart and images by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1305](https://togithub.com/kubernetes-sigs/descheduler/pull/1305)
- helm: ability to specify security context for pod by
[@&#8203;victorgs](https://togithub.com/victorgs) in
[https://github.com/kubernetes-sigs/descheduler/pull/1311](https://togithub.com/kubernetes-sigs/descheduler/pull/1311)
- helm: allow configuration of ipFamilyPolicy by
[@&#8203;dongjiang1989](https://togithub.com/dongjiang1989) in
[https://github.com/kubernetes-sigs/descheduler/pull/1314](https://togithub.com/kubernetes-sigs/descheduler/pull/1314)
- fix: topologySpreadConstraint fields in structured logs by
[@&#8203;SataQiu](https://togithub.com/SataQiu) in
[https://github.com/kubernetes-sigs/descheduler/pull/1317](https://togithub.com/kubernetes-sigs/descheduler/pull/1317)
- `PodLifeTime`: consider pods with container status `ImagePullBackOff`
by [@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1318](https://togithub.com/kubernetes-sigs/descheduler/pull/1318)
- kubernetes 1.29: update deps and go-version by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1322](https://togithub.com/kubernetes-sigs/descheduler/pull/1322)
- `CVE-2023-48795`: bump k8s deps by
[@&#8203;a7i](https://togithub.com/a7i) in
[https://github.com/kubernetes-sigs/descheduler/pull/1333](https://togithub.com/kubernetes-sigs/descheduler/pull/1333)

#### New Contributors

- [@&#8203;cayla](https://togithub.com/cayla) made their first
contribution in
[https://github.com/kubernetes-sigs/descheduler/pull/1229](https://togithub.com/kubernetes-sigs/descheduler/pull/1229)
- [@&#8203;dimunech](https://togithub.com/dimunech) made their first
contribution in
[https://github.com/kubernetes-sigs/descheduler/pull/1281](https://togithub.com/kubernetes-sigs/descheduler/pull/1281)
- [@&#8203;PeterSzegedi](https://togithub.com/PeterSzegedi) made their
first contribution in
[https://github.com/kubernetes-sigs/descheduler/pull/1294](https://togithub.com/kubernetes-sigs/descheduler/pull/1294)
- [@&#8203;victorgs](https://togithub.com/victorgs) made their first
contribution in
[https://github.com/kubernetes-sigs/descheduler/pull/1311](https://togithub.com/kubernetes-sigs/descheduler/pull/1311)
- [@&#8203;SataQiu](https://togithub.com/SataQiu) made their first
contribution in
[https://github.com/kubernetes-sigs/descheduler/pull/1317](https://togithub.com/kubernetes-sigs/descheduler/pull/1317)

**Full Changelog**:
kubernetes-sigs/descheduler@v0.28.0...v0.29.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/teutonet/teutonet-helm-charts).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Chris Werner Rau <cwr@teuto.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support MatchLabelKeys in TopologySpreadConstraints Strategy
4 participants