`PodLifeTime`: update support pods with container status and pods reason #1330

dongjiang1989 · 2023-12-22T03:32:47Z

support pod status reason:

NodeAffinity
NodeLost
Shutdown
UnexpectedAdmissionError

support pod with container status:

CrashLoopBackOff
CreateContainerConfigError
ErrImagePull
CreateContainerError
InvalidImageName

k8s-ci-robot · 2023-12-22T03:32:56Z

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/framework/plugins/podlifetime/validation.go

dongjiang1989

Remove duplicates

pkg/framework/plugins/podlifetime/validation.go

dongjiang1989 · 2023-12-22T04:18:23Z

/ok-to-test

k8s-ci-robot · 2023-12-22T04:18:37Z

@dongjiang1989: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dongjiang1989 · 2023-12-25T01:26:01Z

@a7i PTAL

jklaw90 · 2023-12-27T16:58:34Z

/ok-to-test

pkg/framework/plugins/podlifetime/pod_lifetime_test.go

jklaw90 · 2023-12-29T21:02:01Z

/lgtm

a7i · 2023-12-29T21:31:56Z

pkg/framework/plugins/podlifetime/validation.go

+		"NodeAffinity",
+		"NodeLost",
+		"Shutdown",
+		"UnexpectedAdmissionError",


Some (maybe all) of these are status reasons for Pods that have status Failed, which generally has been handled by RemoveFailedPods strategy as opposed to PodLifeTime.

We have discussed merging the two strategies in the past so I'm not opposed to this idea.

Let's give it a couple of more days to see if other maintainers want to chime in on our approach going forward.

Great. I’m willing to join and improve it

a7i · 2023-12-29T21:33:00Z

/label tide/merge-method-squash

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

dongjiang1989 · 2024-01-02T07:31:28Z

/label tide/merge-method-squash

squash done. @a7i PTAL, thanks

dongjiang1989 · 2024-01-02T07:52:06Z

/retest-required

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

dongjiang1989 · 2024-01-03T03:15:32Z

/retest-required

a7i · 2024-01-06T03:03:28Z

/approve

k8s-ci-robot · 2024-01-06T03:03:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [a7i]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

a7i · 2024-01-06T16:30:15Z

/lgtm

…son (kubernetes-sigs#1330) * update support podlifetime status Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * update verify gen Signed-off-by: dongjiang1989 <dongjiang1989@126.com> --------- Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.29.0` -> `0.30.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.30.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.30.0): Descheduler v0.30.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.29.0...v0.30.0) #### What's Changed - fix(podlifetime): fix failed unittest by [@xujihui1985](https://togithub.com/xujihui1985) in [kubernetes-sigs/descheduler#1334 - `PodLifeTime`: update support pods with container status and pods reason by [@dongjiang1989](https://togithub.com/dongjiang1989) in [kubernetes-sigs/descheduler#1330 - v1alpha1: log deprecation notice by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1337 - feat: Add support for topologySpreadConstraints by [@UAntBou](https://togithub.com/UAntBou) in [kubernetes-sigs/descheduler#1289 - chore: update dependencies for security vulnerabilities (CVE-2023-48795) by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1343 - trim managedFields in shared informer factory by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1346 - fix: `RemovePodsHavingTooManyRestarts` to include `InitContainerStatuses` by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1348 - Improve PodEvictor observability through EvictOptions by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1349 - Fix node taint wrong EvictOption field by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1358 - Disambiguate node fit log messages by [@jackfrancis](https://togithub.com/jackfrancis) in [kubernetes-sigs/descheduler#1362 - Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` by [@nikimanoledaki](https://togithub.com/nikimanoledaki) in [kubernetes-sigs/descheduler#1356 - Bump to k8s v0.30.0-alpha.3 by [@pravarag](https://togithub.com/pravarag) in [kubernetes-sigs/descheduler#1359 - skip eviction when replica count is below evictor `minReplicas` threshold setting by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1257 - Add argument to remove only pods violating allowlisted taints by [@etoster](https://togithub.com/etoster) in [kubernetes-sigs/descheduler#1360 - use v1alpha2 api for helm chart default values by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1139 - `RemoveDuplicates`: reduce cycle times identifying duplicates by [@ls-2018](https://togithub.com/ls-2018) in [kubernetes-sigs/descheduler#1365 - avoid redundant type conversion of DefaultEvictorArgs parameter in DefaultEvictor by [@fanhaouu](https://togithub.com/fanhaouu) in [kubernetes-sigs/descheduler#1369 - bump(golang.org/x/net)=v0.23.0 by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1373 - Allow eviction of DaemonSet pods by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1342 - bump to go 1.22.2 by [@jklaw90](https://togithub.com/jklaw90) in [kubernetes-sigs/descheduler#1374 - helm: Allow the use of existing policy configMap by [@agmimidi](https://togithub.com/agmimidi) in [kubernetes-sigs/descheduler#1376 - Fix and improve the namespace filtering description in README by [@yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1379 - Add an extra parameter ExitCode to RemoveFailedPods by [@yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1381 - 753 - Descheduling framework by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1372 - KEP-753: Descheduling framework: update diagram by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1396 - \[release 1.30] upgrade kubernetes version and docs by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1400 #### New Contributors - [@xujihui1985](https://togithub.com/xujihui1985) made their first contribution in [kubernetes-sigs/descheduler#1334 - [@UAntBou](https://togithub.com/UAntBou) made their first contribution in [kubernetes-sigs/descheduler#1289 - [@tioxy](https://togithub.com/tioxy) made their first contribution in [kubernetes-sigs/descheduler#1349 - [@jackfrancis](https://togithub.com/jackfrancis) made their first contribution in [kubernetes-sigs/descheduler#1362 - [@nikimanoledaki](https://togithub.com/nikimanoledaki) made their first contribution in [kubernetes-sigs/descheduler#1356 - [@etoster](https://togithub.com/etoster) made their first contribution in [kubernetes-sigs/descheduler#1360 - [@ls-2018](https://togithub.com/ls-2018) made their first contribution in [kubernetes-sigs/descheduler#1365 - [@fanhaouu](https://togithub.com/fanhaouu) made their first contribution in [kubernetes-sigs/descheduler#1369 - [@agmimidi](https://togithub.com/agmimidi) made their first contribution in [kubernetes-sigs/descheduler#1376 - [@yuanchen8911](https://togithub.com/yuanchen8911) made their first contribution in [kubernetes-sigs/descheduler#1379 **Full Changelog**: kubernetes-sigs/descheduler@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.29.0` -> `0.30.0` | --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.30.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.30.0): Descheduler v0.30.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.29.0...v0.30.0) #### What's Changed - fix(podlifetime): fix failed unittest by [@xujihui1985](https://togithub.com/xujihui1985) in [kubernetes-sigs/descheduler#1334 - `PodLifeTime`: update support pods with container status and pods reason by [@dongjiang1989](https://togithub.com/dongjiang1989) in [kubernetes-sigs/descheduler#1330 - v1alpha1: log deprecation notice by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1337 - feat: Add support for topologySpreadConstraints by [@UAntBou](https://togithub.com/UAntBou) in [kubernetes-sigs/descheduler#1289 - chore: update dependencies for security vulnerabilities (CVE-2023-48795) by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1343 - trim managedFields in shared informer factory by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1346 - fix: `RemovePodsHavingTooManyRestarts` to include `InitContainerStatuses` by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1348 - Improve PodEvictor observability through EvictOptions by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1349 - Fix node taint wrong EvictOption field by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1358 - Disambiguate node fit log messages by [@jackfrancis](https://togithub.com/jackfrancis) in [kubernetes-sigs/descheduler#1362 - Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` by [@nikimanoledaki](https://togithub.com/nikimanoledaki) in [kubernetes-sigs/descheduler#1356 - Bump to k8s v0.30.0-alpha.3 by [@pravarag](https://togithub.com/pravarag) in [kubernetes-sigs/descheduler#1359 - skip eviction when replica count is below evictor `minReplicas` threshold setting by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1257 - Add argument to remove only pods violating allowlisted taints by [@etoster](https://togithub.com/etoster) in [kubernetes-sigs/descheduler#1360 - use v1alpha2 api for helm chart default values by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1139 - `RemoveDuplicates`: reduce cycle times identifying duplicates by [@ls-2018](https://togithub.com/ls-2018) in [kubernetes-sigs/descheduler#1365 - avoid redundant type conversion of DefaultEvictorArgs parameter in DefaultEvictor by [@fanhaouu](https://togithub.com/fanhaouu) in [kubernetes-sigs/descheduler#1369 - bump(golang.org/x/net)=v0.23.0 by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1373 - Allow eviction of DaemonSet pods by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1342 - bump to go 1.22.2 by [@jklaw90](https://togithub.com/jklaw90) in [kubernetes-sigs/descheduler#1374 - helm: Allow the use of existing policy configMap by [@agmimidi](https://togithub.com/agmimidi) in [kubernetes-sigs/descheduler#1376 - Fix and improve the namespace filtering description in README by [@yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1379 - Add an extra parameter ExitCode to RemoveFailedPods by [@yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1381 - 753 - Descheduling framework by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1372 - KEP-753: Descheduling framework: update diagram by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1396 - \[release 1.30] upgrade kubernetes version and docs by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1400 #### New Contributors - [@xujihui1985](https://togithub.com/xujihui1985) made their first contribution in [kubernetes-sigs/descheduler#1334 - [@UAntBou](https://togithub.com/UAntBou) made their first contribution in [kubernetes-sigs/descheduler#1289 - [@tioxy](https://togithub.com/tioxy) made their first contribution in [kubernetes-sigs/descheduler#1349 - [@jackfrancis](https://togithub.com/jackfrancis) made their first contribution in [kubernetes-sigs/descheduler#1362 - [@nikimanoledaki](https://togithub.com/nikimanoledaki) made their first contribution in [kubernetes-sigs/descheduler#1356 - [@etoster](https://togithub.com/etoster) made their first contribution in [kubernetes-sigs/descheduler#1360 - [@ls-2018](https://togithub.com/ls-2018) made their first contribution in [kubernetes-sigs/descheduler#1365 - [@fanhaouu](https://togithub.com/fanhaouu) made their first contribution in [kubernetes-sigs/descheduler#1369 - [@agmimidi](https://togithub.com/agmimidi) made their first contribution in [kubernetes-sigs/descheduler#1376 - [@yuanchen8911](https://togithub.com/yuanchen8911) made their first contribution in [kubernetes-sigs/descheduler#1379 **Full Changelog**: kubernetes-sigs/descheduler@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.29.0` -> `0.30.1` | --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.30.1`](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.30.0...v0.30.1) [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.30.0...v0.30.1) ### [`v0.30.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.30.0): Descheduler v0.30.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.29.0...v0.30.0) #### What's Changed - fix(podlifetime): fix failed unittest by [@xujihui1985](https://togithub.com/xujihui1985) in [kubernetes-sigs/descheduler#1334 - `PodLifeTime`: update support pods with container status and pods reason by [@dongjiang1989](https://togithub.com/dongjiang1989) in [kubernetes-sigs/descheduler#1330 - v1alpha1: log deprecation notice by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1337 - feat: Add support for topologySpreadConstraints by [@UAntBou](https://togithub.com/UAntBou) in [kubernetes-sigs/descheduler#1289 - chore: update dependencies for security vulnerabilities (CVE-2023-48795) by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1343 - trim managedFields in shared informer factory by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1346 - fix: `RemovePodsHavingTooManyRestarts` to include `InitContainerStatuses` by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1348 - Improve PodEvictor observability through EvictOptions by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1349 - Fix node taint wrong EvictOption field by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1358 - Disambiguate node fit log messages by [@jackfrancis](https://togithub.com/jackfrancis) in [kubernetes-sigs/descheduler#1362 - Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` by [@nikimanoledaki](https://togithub.com/nikimanoledaki) in [kubernetes-sigs/descheduler#1356 - Bump to k8s v0.30.0-alpha.3 by [@pravarag](https://togithub.com/pravarag) in [kubernetes-sigs/descheduler#1359 - skip eviction when replica count is below evictor `minReplicas` threshold setting by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1257 - Add argument to remove only pods violating allowlisted taints by [@etoster](https://togithub.com/etoster) in [kubernetes-sigs/descheduler#1360 - use v1alpha2 api for helm chart default values by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1139 - `RemoveDuplicates`: reduce cycle times identifying duplicates by [@ls-2018](https://togithub.com/ls-2018) in [kubernetes-sigs/descheduler#1365 - avoid redundant type conversion of DefaultEvictorArgs parameter in DefaultEvictor by [@fanhaouu](https://togithub.com/fanhaouu) in [kubernetes-sigs/descheduler#1369 - bump(golang.org/x/net)=v0.23.0 by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1373 - Allow eviction of DaemonSet pods by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1342 - bump to go 1.22.2 by [@jklaw90](https://togithub.com/jklaw90) in [kubernetes-sigs/descheduler#1374 - helm: Allow the use of existing policy configMap by [@agmimidi](https://togithub.com/agmimidi) in [kubernetes-sigs/descheduler#1376 - Fix and improve the namespace filtering description in README by [@yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1379 - Add an extra parameter ExitCode to RemoveFailedPods by [@yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1381 - 753 - Descheduling framework by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1372 - KEP-753: Descheduling framework: update diagram by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1396 - \[release 1.30] upgrade kubernetes version and docs by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1400 #### New Contributors - [@xujihui1985](https://togithub.com/xujihui1985) made their first contribution in [kubernetes-sigs/descheduler#1334 - [@UAntBou](https://togithub.com/UAntBou) made their first contribution in [kubernetes-sigs/descheduler#1289 - [@tioxy](https://togithub.com/tioxy) made their first contribution in [kubernetes-sigs/descheduler#1349 - [@jackfrancis](https://togithub.com/jackfrancis) made their first contribution in [kubernetes-sigs/descheduler#1362 - [@nikimanoledaki](https://togithub.com/nikimanoledaki) made their first contribution in [kubernetes-sigs/descheduler#1356 - [@etoster](https://togithub.com/etoster) made their first contribution in [kubernetes-sigs/descheduler#1360 - [@ls-2018](https://togithub.com/ls-2018) made their first contribution in [kubernetes-sigs/descheduler#1365 - [@fanhaouu](https://togithub.com/fanhaouu) made their first contribution in [kubernetes-sigs/descheduler#1369 - [@agmimidi](https://togithub.com/agmimidi) made their first contribution in [kubernetes-sigs/descheduler#1376 - [@yuanchen8911](https://togithub.com/yuanchen8911) made their first contribution in [kubernetes-sigs/descheduler#1379 **Full Changelog**: kubernetes-sigs/descheduler@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/sp3nx0r/homelab).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…0.30.x (#1015) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.29.x` -> `0.30.x` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.30.1`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.30.1): Descheduler v0.30.1 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.30.0...v0.30.1) #### What's Changed - bump to to 1.22.3 to address CVE-2024-24788 by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1408 - \[release 1.30] update kustomize image tags and helm versions by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1405 - Automated cherry pick of [#1378](https://togithub.com/kubernetes-sigs/descheduler/issues/1378): Fix the replicas type for the helm-chart [#1390](https://togithub.com/kubernetes-sigs/descheduler/issues/1390): allow 'falsey' value in cmdOption [#1412](https://togithub.com/kubernetes-sigs/descheduler/issues/1412): fix helm's default deschedulerPolicy [#1413](https://togithub.com/kubernetes-sigs/descheduler/issues/1413): fix TOC location in Readme [#1416](https://togithub.com/kubernetes-sigs/descheduler/issues/1416): use cmd context instead of using context.Background() [#1395](https://togithub.com/kubernetes-sigs/descheduler/issues/1395): fix the issue that the pod anti-filtering rules are not by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1425 **Full Changelog**: kubernetes-sigs/descheduler@v0.30.0...v0.30.1 ### [`v0.30.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.30.0): Descheduler v0.30.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.29.0...v0.30.0) #### What's Changed - fix(podlifetime): fix failed unittest by [@xujihui1985](https://togithub.com/xujihui1985) in [kubernetes-sigs/descheduler#1334 - `PodLifeTime`: update support pods with container status and pods reason by [@dongjiang1989](https://togithub.com/dongjiang1989) in [kubernetes-sigs/descheduler#1330 - v1alpha1: log deprecation notice by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1337 - feat: Add support for topologySpreadConstraints by [@UAntBou](https://togithub.com/UAntBou) in [kubernetes-sigs/descheduler#1289 - chore: update dependencies for security vulnerabilities (CVE-2023-48795) by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1343 - trim managedFields in shared informer factory by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1346 - fix: `RemovePodsHavingTooManyRestarts` to include `InitContainerStatuses` by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1348 - Improve PodEvictor observability through EvictOptions by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1349 - Fix node taint wrong EvictOption field by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1358 - Disambiguate node fit log messages by [@jackfrancis](https://togithub.com/jackfrancis) in [kubernetes-sigs/descheduler#1362 - Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` by [@nikimanoledaki](https://togithub.com/nikimanoledaki) in [kubernetes-sigs/descheduler#1356 - Bump to k8s v0.30.0-alpha.3 by [@pravarag](https://togithub.com/pravarag) in [kubernetes-sigs/descheduler#1359 - skip eviction when replica count is below evictor `minReplicas` threshold setting by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1257 - Add argument to remove only pods violating allowlisted taints by [@etoster](https://togithub.com/etoster) in [kubernetes-sigs/descheduler#1360 - use v1alpha2 api for helm chart default values by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1139 - `RemoveDuplicates`: reduce cycle times identifying duplicates by [@ls-2018](https://togithub.com/ls-2018) in [kubernetes-sigs/descheduler#1365 - avoid redundant type conversion of DefaultEvictorArgs parameter in DefaultEvictor by [@fanhaouu](https://togithub.com/fanhaouu) in [kubernetes-sigs/descheduler#1369 - bump(golang.org/x/net)=v0.23.0 by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1373 - Allow eviction of DaemonSet pods by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1342 - bump to go 1.22.2 by [@jklaw90](https://togithub.com/jklaw90) in [kubernetes-sigs/descheduler#1374 - helm: Allow the use of existing policy configMap by [@agmimidi](https://togithub.com/agmimidi) in [kubernetes-sigs/descheduler#1376 - Fix and improve the namespace filtering description in README by [@yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1379 - Add an extra parameter ExitCode to RemoveFailedPods by [@yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1381 - 753 - Descheduling framework by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1372 - KEP-753: Descheduling framework: update diagram by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1396 - \[release 1.30] upgrade kubernetes version and docs by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1400 #### New Contributors - [@xujihui1985](https://togithub.com/xujihui1985) made their first contribution in [kubernetes-sigs/descheduler#1334 - [@UAntBou](https://togithub.com/UAntBou) made their first contribution in [kubernetes-sigs/descheduler#1289 - [@tioxy](https://togithub.com/tioxy) made their first contribution in [kubernetes-sigs/descheduler#1349 - [@jackfrancis](https://togithub.com/jackfrancis) made their first contribution in [kubernetes-sigs/descheduler#1362 - [@nikimanoledaki](https://togithub.com/nikimanoledaki) made their first contribution in [kubernetes-sigs/descheduler#1356 - [@etoster](https://togithub.com/etoster) made their first contribution in [kubernetes-sigs/descheduler#1360 - [@ls-2018](https://togithub.com/ls-2018) made their first contribution in [kubernetes-sigs/descheduler#1365 - [@fanhaouu](https://togithub.com/fanhaouu) made their first contribution in [kubernetes-sigs/descheduler#1369 - [@agmimidi](https://togithub.com/agmimidi) made their first contribution in [kubernetes-sigs/descheduler#1376 - [@yuanchen8911](https://togithub.com/yuanchen8911) made their first contribution in [kubernetes-sigs/descheduler#1379 **Full Changelog**: kubernetes-sigs/descheduler@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/teutonet/teutonet-helm-charts).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

k8s-ci-robot requested review from JaneLiuL and jklaw90 December 22, 2023 03:32

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 22, 2023

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 22, 2023

dongjiang1989 commented Dec 22, 2023

View reviewed changes

pkg/framework/plugins/podlifetime/validation.go Outdated Show resolved Hide resolved

dongjiang1989 commented Dec 22, 2023

View reviewed changes

pkg/framework/plugins/podlifetime/validation.go Outdated Show resolved Hide resolved

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 27, 2023

jklaw90 reviewed Dec 27, 2023

View reviewed changes

pkg/framework/plugins/podlifetime/pod_lifetime_test.go Show resolved Hide resolved

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 28, 2023

k8s-ci-robot assigned jklaw90 Dec 29, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 29, 2023

a7i reviewed Dec 29, 2023

View reviewed changes

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 29, 2023

update support podlifetime status

bf97435

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

dongjiang1989 force-pushed the update-podlifetime-status branch from 9271f03 to bf97435 Compare January 2, 2024 07:27

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2024

update verify gen

ef29b99

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2024

k8s-ci-robot assigned a7i Jan 6, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2024

k8s-ci-robot merged commit e798044 into kubernetes-sigs:master Jan 6, 2024
8 checks passed

dongjiang1989 deleted the update-podlifetime-status branch January 8, 2024 06:30

ionfury added a commit to ionfury/homelab that referenced this pull request Apr 20, 2024

Waiting on release of kubernetes-sigs/descheduler#1330

30e0b31

a7i mentioned this pull request May 10, 2024

status.phase=Unknown not available in 1.29 release #1394

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`PodLifeTime`: update support pods with container status and pods reason #1330

`PodLifeTime`: update support pods with container status and pods reason #1330

dongjiang1989 commented Dec 22, 2023 •

edited

Loading

k8s-ci-robot commented Dec 22, 2023

dongjiang1989 left a comment

dongjiang1989 commented Dec 22, 2023

k8s-ci-robot commented Dec 22, 2023

dongjiang1989 commented Dec 25, 2023

jklaw90 commented Dec 27, 2023

jklaw90 commented Dec 29, 2023

a7i Dec 29, 2023

dongjiang1989 Dec 30, 2023

a7i commented Dec 29, 2023

dongjiang1989 commented Jan 2, 2024

dongjiang1989 commented Jan 2, 2024

dongjiang1989 commented Jan 3, 2024

a7i commented Jan 6, 2024

k8s-ci-robot commented Jan 6, 2024

a7i commented Jan 6, 2024

PodLifeTime: update support pods with container status and pods reason #1330

PodLifeTime: update support pods with container status and pods reason #1330

Conversation

dongjiang1989 commented Dec 22, 2023 • edited Loading

k8s-ci-robot commented Dec 22, 2023

dongjiang1989 left a comment

Choose a reason for hiding this comment

dongjiang1989 commented Dec 22, 2023

k8s-ci-robot commented Dec 22, 2023

dongjiang1989 commented Dec 25, 2023

jklaw90 commented Dec 27, 2023

jklaw90 commented Dec 29, 2023

a7i Dec 29, 2023

Choose a reason for hiding this comment

dongjiang1989 Dec 30, 2023

Choose a reason for hiding this comment

a7i commented Dec 29, 2023

dongjiang1989 commented Jan 2, 2024

dongjiang1989 commented Jan 2, 2024

dongjiang1989 commented Jan 3, 2024

a7i commented Jan 6, 2024

k8s-ci-robot commented Jan 6, 2024

a7i commented Jan 6, 2024

`PodLifeTime`: update support pods with container status and pods reason #1330

`PodLifeTime`: update support pods with container status and pods reason #1330

dongjiang1989 commented Dec 22, 2023 •

edited

Loading