Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` #1356

nikimanoledaki · 2024-02-27T15:20:57Z

Closes #1279
More context: #1149

This PR:

Adds a check so that NodeFit() assesses whether it is possible for a given Pod to be scheduled on a given Node before descheduling it.
Uses the logic from the plugin RemovePodsViolatingInterPodAntiAffinity which already contains logic for fetching and comparing the pod anti-affinity rule of pods in checkPodsWithAntiAffinityExist. The logic is extracted from pkg/framework/plugins/removepodsviolatinginterpodantiaffinity -> pkg/utils/predicates.go (for the most part).
Updates user-facing docs about this change
Adds lots of unit tests!

k8s-ci-robot · 2024-02-27T15:21:07Z

Hi @nikimanoledaki. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

damemi

/ok-to-test

nikimanoledaki · 2024-02-28T10:51:10Z

/ok-to-test

@damemi thank you for approving the tests - I fixed the linter issue, would it be possible to run them again please?

pkg/descheduler/node/node.go

logyball

Hey @nikimanoledaki , great work here! I've got the tests all passing, and look forward to testing this out with you. I have one question about the namespaces that we'll be comparing in order to figure out which pods need to checked for anti-affinity, let me know what you think.

pkg/descheduler/node/node_test.go

pkg/utils/priority.go

ingvagabund · 2024-03-05T07:59:43Z

/retest pull-descheduler-verify-master

k8s-ci-robot · 2024-03-05T07:59:46Z

@ingvagabund: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test pull-descheduler-test-e2e-k8s-master-1-27
/test pull-descheduler-test-e2e-k8s-master-1-28
/test pull-descheduler-test-e2e-k8s-master-1-29
/test pull-descheduler-unit-test-master-master
/test pull-descheduler-verify-build-master
/test pull-descheduler-verify-master

Use /test all to run all jobs.

In response to this:

/retest pull-descheduler-verify-master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knelasevero · 2024-03-06T12:07:55Z

I think this can get in before we redesign nodeFit, as @a7i pointed out.

gonna approve and let lgtm's for other maintainers and @logyball

/approve

nikimanoledaki · 2024-03-06T12:13:42Z

/test all

logyball

LGTM! nice work

…part of NodeFit() * Add unit tests for checking inter-pod anti-affinity match in NodeFit() * Export setPodAntiAffinity() helper func to test utils

* Move logic for finding match between pods with antiaffinity out of framework to reuse in other pkgs * Move interpod antiaffinity funcs to pkg/utils/predicates.go

nikimanoledaki · 2024-03-12T11:30:51Z

Thank you @ingvagabund! I rewrote the history a bit to remove in-between draft steps & duplications, as well as group unit test commits :) Could you review when you can please? Thank you!

/test all

* Test logic in GroupByNodeName * Test NodeFit() case where pods matches inter-pod anti-affinity * Test for inter-pod anti-affinity pods match terms, have label selector

…not set

nikimanoledaki · 2024-03-12T16:09:42Z

/cc ingvagabund

a7i · 2024-03-12T16:13:54Z

@nikimanoledaki I'm working on getting this merged today. We have a CI job that is stuck

a7i · 2024-03-12T18:37:01Z

/lgtm

a7i · 2024-03-12T20:45:38Z

seems to be stuck on linting: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_descheduler/1356/pull-descheduler-verify-master/1767621656668278784

a7i · 2024-03-13T02:37:32Z

/retest-required

a7i · 2024-03-13T02:48:32Z

thank you for your contribution @nikimanoledaki 🏆

nikimanoledaki · 2024-03-13T11:18:23Z

Thank you so much for the reviews and help @a7i @logyball @ingvagabund @knelasevero @damemi! 🎉 🥳

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.29.0` -> `0.30.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.30.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.30.0): Descheduler v0.30.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.29.0...v0.30.0) #### What's Changed - fix(podlifetime): fix failed unittest by [@xujihui1985](https://togithub.com/xujihui1985) in [kubernetes-sigs/descheduler#1334 - `PodLifeTime`: update support pods with container status and pods reason by [@dongjiang1989](https://togithub.com/dongjiang1989) in [kubernetes-sigs/descheduler#1330 - v1alpha1: log deprecation notice by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1337 - feat: Add support for topologySpreadConstraints by [@UAntBou](https://togithub.com/UAntBou) in [kubernetes-sigs/descheduler#1289 - chore: update dependencies for security vulnerabilities (CVE-2023-48795) by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1343 - trim managedFields in shared informer factory by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1346 - fix: `RemovePodsHavingTooManyRestarts` to include `InitContainerStatuses` by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1348 - Improve PodEvictor observability through EvictOptions by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1349 - Fix node taint wrong EvictOption field by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1358 - Disambiguate node fit log messages by [@jackfrancis](https://togithub.com/jackfrancis) in [kubernetes-sigs/descheduler#1362 - Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` by [@nikimanoledaki](https://togithub.com/nikimanoledaki) in [kubernetes-sigs/descheduler#1356 - Bump to k8s v0.30.0-alpha.3 by [@pravarag](https://togithub.com/pravarag) in [kubernetes-sigs/descheduler#1359 - skip eviction when replica count is below evictor `minReplicas` threshold setting by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1257 - Add argument to remove only pods violating allowlisted taints by [@etoster](https://togithub.com/etoster) in [kubernetes-sigs/descheduler#1360 - use v1alpha2 api for helm chart default values by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1139 - `RemoveDuplicates`: reduce cycle times identifying duplicates by [@ls-2018](https://togithub.com/ls-2018) in [kubernetes-sigs/descheduler#1365 - avoid redundant type conversion of DefaultEvictorArgs parameter in DefaultEvictor by [@fanhaouu](https://togithub.com/fanhaouu) in [kubernetes-sigs/descheduler#1369 - bump(golang.org/x/net)=v0.23.0 by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1373 - Allow eviction of DaemonSet pods by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1342 - bump to go 1.22.2 by [@jklaw90](https://togithub.com/jklaw90) in [kubernetes-sigs/descheduler#1374 - helm: Allow the use of existing policy configMap by [@agmimidi](https://togithub.com/agmimidi) in [kubernetes-sigs/descheduler#1376 - Fix and improve the namespace filtering description in README by [@yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1379 - Add an extra parameter ExitCode to RemoveFailedPods by [@yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1381 - 753 - Descheduling framework by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1372 - KEP-753: Descheduling framework: update diagram by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1396 - \[release 1.30] upgrade kubernetes version and docs by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1400 #### New Contributors - [@xujihui1985](https://togithub.com/xujihui1985) made their first contribution in [kubernetes-sigs/descheduler#1334 - [@UAntBou](https://togithub.com/UAntBou) made their first contribution in [kubernetes-sigs/descheduler#1289 - [@tioxy](https://togithub.com/tioxy) made their first contribution in [kubernetes-sigs/descheduler#1349 - [@jackfrancis](https://togithub.com/jackfrancis) made their first contribution in [kubernetes-sigs/descheduler#1362 - [@nikimanoledaki](https://togithub.com/nikimanoledaki) made their first contribution in [kubernetes-sigs/descheduler#1356 - [@etoster](https://togithub.com/etoster) made their first contribution in [kubernetes-sigs/descheduler#1360 - [@ls-2018](https://togithub.com/ls-2018) made their first contribution in [kubernetes-sigs/descheduler#1365 - [@fanhaouu](https://togithub.com/fanhaouu) made their first contribution in [kubernetes-sigs/descheduler#1369 - [@agmimidi](https://togithub.com/agmimidi) made their first contribution in [kubernetes-sigs/descheduler#1376 - [@yuanchen8911](https://togithub.com/yuanchen8911) made their first contribution in [kubernetes-sigs/descheduler#1379 **Full Changelog**: kubernetes-sigs/descheduler@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.29.0` -> `0.30.0` | --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.30.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.30.0): Descheduler v0.30.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.29.0...v0.30.0) #### What's Changed - fix(podlifetime): fix failed unittest by [@xujihui1985](https://togithub.com/xujihui1985) in [kubernetes-sigs/descheduler#1334 - `PodLifeTime`: update support pods with container status and pods reason by [@dongjiang1989](https://togithub.com/dongjiang1989) in [kubernetes-sigs/descheduler#1330 - v1alpha1: log deprecation notice by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1337 - feat: Add support for topologySpreadConstraints by [@UAntBou](https://togithub.com/UAntBou) in [kubernetes-sigs/descheduler#1289 - chore: update dependencies for security vulnerabilities (CVE-2023-48795) by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1343 - trim managedFields in shared informer factory by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1346 - fix: `RemovePodsHavingTooManyRestarts` to include `InitContainerStatuses` by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1348 - Improve PodEvictor observability through EvictOptions by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1349 - Fix node taint wrong EvictOption field by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1358 - Disambiguate node fit log messages by [@jackfrancis](https://togithub.com/jackfrancis) in [kubernetes-sigs/descheduler#1362 - Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` by [@nikimanoledaki](https://togithub.com/nikimanoledaki) in [kubernetes-sigs/descheduler#1356 - Bump to k8s v0.30.0-alpha.3 by [@pravarag](https://togithub.com/pravarag) in [kubernetes-sigs/descheduler#1359 - skip eviction when replica count is below evictor `minReplicas` threshold setting by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1257 - Add argument to remove only pods violating allowlisted taints by [@etoster](https://togithub.com/etoster) in [kubernetes-sigs/descheduler#1360 - use v1alpha2 api for helm chart default values by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1139 - `RemoveDuplicates`: reduce cycle times identifying duplicates by [@ls-2018](https://togithub.com/ls-2018) in [kubernetes-sigs/descheduler#1365 - avoid redundant type conversion of DefaultEvictorArgs parameter in DefaultEvictor by [@fanhaouu](https://togithub.com/fanhaouu) in [kubernetes-sigs/descheduler#1369 - bump(golang.org/x/net)=v0.23.0 by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1373 - Allow eviction of DaemonSet pods by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1342 - bump to go 1.22.2 by [@jklaw90](https://togithub.com/jklaw90) in [kubernetes-sigs/descheduler#1374 - helm: Allow the use of existing policy configMap by [@agmimidi](https://togithub.com/agmimidi) in [kubernetes-sigs/descheduler#1376 - Fix and improve the namespace filtering description in README by [@yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1379 - Add an extra parameter ExitCode to RemoveFailedPods by [@yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1381 - 753 - Descheduling framework by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1372 - KEP-753: Descheduling framework: update diagram by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1396 - \[release 1.30] upgrade kubernetes version and docs by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1400 #### New Contributors - [@xujihui1985](https://togithub.com/xujihui1985) made their first contribution in [kubernetes-sigs/descheduler#1334 - [@UAntBou](https://togithub.com/UAntBou) made their first contribution in [kubernetes-sigs/descheduler#1289 - [@tioxy](https://togithub.com/tioxy) made their first contribution in [kubernetes-sigs/descheduler#1349 - [@jackfrancis](https://togithub.com/jackfrancis) made their first contribution in [kubernetes-sigs/descheduler#1362 - [@nikimanoledaki](https://togithub.com/nikimanoledaki) made their first contribution in [kubernetes-sigs/descheduler#1356 - [@etoster](https://togithub.com/etoster) made their first contribution in [kubernetes-sigs/descheduler#1360 - [@ls-2018](https://togithub.com/ls-2018) made their first contribution in [kubernetes-sigs/descheduler#1365 - [@fanhaouu](https://togithub.com/fanhaouu) made their first contribution in [kubernetes-sigs/descheduler#1369 - [@agmimidi](https://togithub.com/agmimidi) made their first contribution in [kubernetes-sigs/descheduler#1376 - [@yuanchen8911](https://togithub.com/yuanchen8911) made their first contribution in [kubernetes-sigs/descheduler#1379 **Full Changelog**: kubernetes-sigs/descheduler@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.29.0` -> `0.30.1` | --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.30.1`](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.30.0...v0.30.1) [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.30.0...v0.30.1) ### [`v0.30.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.30.0): Descheduler v0.30.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.29.0...v0.30.0) #### What's Changed - fix(podlifetime): fix failed unittest by [@xujihui1985](https://togithub.com/xujihui1985) in [kubernetes-sigs/descheduler#1334 - `PodLifeTime`: update support pods with container status and pods reason by [@dongjiang1989](https://togithub.com/dongjiang1989) in [kubernetes-sigs/descheduler#1330 - v1alpha1: log deprecation notice by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1337 - feat: Add support for topologySpreadConstraints by [@UAntBou](https://togithub.com/UAntBou) in [kubernetes-sigs/descheduler#1289 - chore: update dependencies for security vulnerabilities (CVE-2023-48795) by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1343 - trim managedFields in shared informer factory by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1346 - fix: `RemovePodsHavingTooManyRestarts` to include `InitContainerStatuses` by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1348 - Improve PodEvictor observability through EvictOptions by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1349 - Fix node taint wrong EvictOption field by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1358 - Disambiguate node fit log messages by [@jackfrancis](https://togithub.com/jackfrancis) in [kubernetes-sigs/descheduler#1362 - Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` by [@nikimanoledaki](https://togithub.com/nikimanoledaki) in [kubernetes-sigs/descheduler#1356 - Bump to k8s v0.30.0-alpha.3 by [@pravarag](https://togithub.com/pravarag) in [kubernetes-sigs/descheduler#1359 - skip eviction when replica count is below evictor `minReplicas` threshold setting by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1257 - Add argument to remove only pods violating allowlisted taints by [@etoster](https://togithub.com/etoster) in [kubernetes-sigs/descheduler#1360 - use v1alpha2 api for helm chart default values by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1139 - `RemoveDuplicates`: reduce cycle times identifying duplicates by [@ls-2018](https://togithub.com/ls-2018) in [kubernetes-sigs/descheduler#1365 - avoid redundant type conversion of DefaultEvictorArgs parameter in DefaultEvictor by [@fanhaouu](https://togithub.com/fanhaouu) in [kubernetes-sigs/descheduler#1369 - bump(golang.org/x/net)=v0.23.0 by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1373 - Allow eviction of DaemonSet pods by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1342 - bump to go 1.22.2 by [@jklaw90](https://togithub.com/jklaw90) in [kubernetes-sigs/descheduler#1374 - helm: Allow the use of existing policy configMap by [@agmimidi](https://togithub.com/agmimidi) in [kubernetes-sigs/descheduler#1376 - Fix and improve the namespace filtering description in README by [@yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1379 - Add an extra parameter ExitCode to RemoveFailedPods by [@yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1381 - 753 - Descheduling framework by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1372 - KEP-753: Descheduling framework: update diagram by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1396 - \[release 1.30] upgrade kubernetes version and docs by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1400 #### New Contributors - [@xujihui1985](https://togithub.com/xujihui1985) made their first contribution in [kubernetes-sigs/descheduler#1334 - [@UAntBou](https://togithub.com/UAntBou) made their first contribution in [kubernetes-sigs/descheduler#1289 - [@tioxy](https://togithub.com/tioxy) made their first contribution in [kubernetes-sigs/descheduler#1349 - [@jackfrancis](https://togithub.com/jackfrancis) made their first contribution in [kubernetes-sigs/descheduler#1362 - [@nikimanoledaki](https://togithub.com/nikimanoledaki) made their first contribution in [kubernetes-sigs/descheduler#1356 - [@etoster](https://togithub.com/etoster) made their first contribution in [kubernetes-sigs/descheduler#1360 - [@ls-2018](https://togithub.com/ls-2018) made their first contribution in [kubernetes-sigs/descheduler#1365 - [@fanhaouu](https://togithub.com/fanhaouu) made their first contribution in [kubernetes-sigs/descheduler#1369 - [@agmimidi](https://togithub.com/agmimidi) made their first contribution in [kubernetes-sigs/descheduler#1376 - [@yuanchen8911](https://togithub.com/yuanchen8911) made their first contribution in [kubernetes-sigs/descheduler#1379 **Full Changelog**: kubernetes-sigs/descheduler@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/sp3nx0r/homelab).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…0.30.x (#1015) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.29.x` -> `0.30.x` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.30.1`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.30.1): Descheduler v0.30.1 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.30.0...v0.30.1) #### What's Changed - bump to to 1.22.3 to address CVE-2024-24788 by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1408 - \[release 1.30] update kustomize image tags and helm versions by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1405 - Automated cherry pick of [#1378](https://togithub.com/kubernetes-sigs/descheduler/issues/1378): Fix the replicas type for the helm-chart [#1390](https://togithub.com/kubernetes-sigs/descheduler/issues/1390): allow 'falsey' value in cmdOption [#1412](https://togithub.com/kubernetes-sigs/descheduler/issues/1412): fix helm's default deschedulerPolicy [#1413](https://togithub.com/kubernetes-sigs/descheduler/issues/1413): fix TOC location in Readme [#1416](https://togithub.com/kubernetes-sigs/descheduler/issues/1416): use cmd context instead of using context.Background() [#1395](https://togithub.com/kubernetes-sigs/descheduler/issues/1395): fix the issue that the pod anti-filtering rules are not by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1425 **Full Changelog**: kubernetes-sigs/descheduler@v0.30.0...v0.30.1 ### [`v0.30.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.30.0): Descheduler v0.30.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.29.0...v0.30.0) #### What's Changed - fix(podlifetime): fix failed unittest by [@xujihui1985](https://togithub.com/xujihui1985) in [kubernetes-sigs/descheduler#1334 - `PodLifeTime`: update support pods with container status and pods reason by [@dongjiang1989](https://togithub.com/dongjiang1989) in [kubernetes-sigs/descheduler#1330 - v1alpha1: log deprecation notice by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1337 - feat: Add support for topologySpreadConstraints by [@UAntBou](https://togithub.com/UAntBou) in [kubernetes-sigs/descheduler#1289 - chore: update dependencies for security vulnerabilities (CVE-2023-48795) by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1343 - trim managedFields in shared informer factory by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1346 - fix: `RemovePodsHavingTooManyRestarts` to include `InitContainerStatuses` by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1348 - Improve PodEvictor observability through EvictOptions by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1349 - Fix node taint wrong EvictOption field by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1358 - Disambiguate node fit log messages by [@jackfrancis](https://togithub.com/jackfrancis) in [kubernetes-sigs/descheduler#1362 - Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` by [@nikimanoledaki](https://togithub.com/nikimanoledaki) in [kubernetes-sigs/descheduler#1356 - Bump to k8s v0.30.0-alpha.3 by [@pravarag](https://togithub.com/pravarag) in [kubernetes-sigs/descheduler#1359 - skip eviction when replica count is below evictor `minReplicas` threshold setting by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1257 - Add argument to remove only pods violating allowlisted taints by [@etoster](https://togithub.com/etoster) in [kubernetes-sigs/descheduler#1360 - use v1alpha2 api for helm chart default values by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1139 - `RemoveDuplicates`: reduce cycle times identifying duplicates by [@ls-2018](https://togithub.com/ls-2018) in [kubernetes-sigs/descheduler#1365 - avoid redundant type conversion of DefaultEvictorArgs parameter in DefaultEvictor by [@fanhaouu](https://togithub.com/fanhaouu) in [kubernetes-sigs/descheduler#1369 - bump(golang.org/x/net)=v0.23.0 by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1373 - Allow eviction of DaemonSet pods by [@tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1342 - bump to go 1.22.2 by [@jklaw90](https://togithub.com/jklaw90) in [kubernetes-sigs/descheduler#1374 - helm: Allow the use of existing policy configMap by [@agmimidi](https://togithub.com/agmimidi) in [kubernetes-sigs/descheduler#1376 - Fix and improve the namespace filtering description in README by [@yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1379 - Add an extra parameter ExitCode to RemoveFailedPods by [@yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1381 - 753 - Descheduling framework by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1372 - KEP-753: Descheduling framework: update diagram by [@ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1396 - \[release 1.30] upgrade kubernetes version and docs by [@a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1400 #### New Contributors - [@xujihui1985](https://togithub.com/xujihui1985) made their first contribution in [kubernetes-sigs/descheduler#1334 - [@UAntBou](https://togithub.com/UAntBou) made their first contribution in [kubernetes-sigs/descheduler#1289 - [@tioxy](https://togithub.com/tioxy) made their first contribution in [kubernetes-sigs/descheduler#1349 - [@jackfrancis](https://togithub.com/jackfrancis) made their first contribution in [kubernetes-sigs/descheduler#1362 - [@nikimanoledaki](https://togithub.com/nikimanoledaki) made their first contribution in [kubernetes-sigs/descheduler#1356 - [@etoster](https://togithub.com/etoster) made their first contribution in [kubernetes-sigs/descheduler#1360 - [@ls-2018](https://togithub.com/ls-2018) made their first contribution in [kubernetes-sigs/descheduler#1365 - [@fanhaouu](https://togithub.com/fanhaouu) made their first contribution in [kubernetes-sigs/descheduler#1369 - [@agmimidi](https://togithub.com/agmimidi) made their first contribution in [kubernetes-sigs/descheduler#1376 - [@yuanchen8911](https://togithub.com/yuanchen8911) made their first contribution in [kubernetes-sigs/descheduler#1379 **Full Changelog**: kubernetes-sigs/descheduler@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/teutonet/teutonet-helm-charts).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2024

k8s-ci-robot requested review from a7i and knelasevero February 27, 2024 15:21

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 27, 2024

nikimanoledaki changed the title ~~Nm/pod anti affinity~~ Add inter-pod anti-affinity to NodeFit() Feb 27, 2024

nikimanoledaki changed the title ~~Add inter-pod anti-affinity to NodeFit()~~ Check whether pod has inter-pod anti-affinity with another Pod in given Node in NodeFit() Feb 27, 2024

nikimanoledaki changed the title ~~Check whether pod has inter-pod anti-affinity with another Pod in given Node in NodeFit()~~ Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in NodeFit() Feb 27, 2024

nikimanoledaki marked this pull request as ready for review February 27, 2024 15:27

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2024

k8s-ci-robot requested a review from seanmalloy February 27, 2024 15:27

damemi reviewed Feb 27, 2024

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2024

nikimanoledaki requested a review from damemi February 27, 2024 16:23

logyball reviewed Feb 28, 2024

View reviewed changes

pkg/descheduler/node/node.go Show resolved Hide resolved

logyball suggested changes Feb 28, 2024

View reviewed changes

pkg/descheduler/node/node_test.go Show resolved Hide resolved

pkg/utils/priority.go Show resolved Hide resolved

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2024

nikimanoledaki force-pushed the nm/pod-anti-affinity branch from 0bc795c to 4edf613 Compare March 6, 2024 10:15

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024

logyball mentioned this pull request Mar 6, 2024

Implement namespaceSelector for Pod (anti)affinity when considering NodeFit #1361

Open

logyball approved these changes Mar 6, 2024

View reviewed changes

nikimanoledaki added 2 commits March 12, 2024 11:37

Check if Pod matches inter-pod anti-affinity of other pod on node as …

791a9fd

…part of NodeFit() * Add unit tests for checking inter-pod anti-affinity match in NodeFit() * Export setPodAntiAffinity() helper func to test utils

Add docs for inter-pod anti-affinity in README

3931a03

nikimanoledaki force-pushed the nm/pod-anti-affinity branch 4 times, most recently from 118bf10 to 3ccd15d Compare March 12, 2024 11:20

Refactor logic for inter-pod anti-affinity to use in multiple pkgs

d8cea2c

* Move logic for finding match between pods with antiaffinity out of framework to reuse in other pkgs * Move interpod antiaffinity funcs to pkg/utils/predicates.go

nikimanoledaki force-pushed the nm/pod-anti-affinity branch from 3ccd15d to 1bb932d Compare March 12, 2024 11:26

nikimanoledaki requested a review from a7i March 12, 2024 11:31

nikimanoledaki added 2 commits March 12, 2024 12:34

Add unit tests for inter-pod anti-affinity check

a5b2f54

* Test logic in GroupByNodeName * Test NodeFit() case where pods matches inter-pod anti-affinity * Test for inter-pod anti-affinity pods match terms, have label selector

NodeFit inter-pod anti-affinity check returns early if affinity spec …

88ce966

…not set

nikimanoledaki force-pushed the nm/pod-anti-affinity branch from 1bb932d to 88ce966 Compare March 12, 2024 11:36

k8s-ci-robot requested a review from ingvagabund March 12, 2024 16:09

k8s-ci-robot assigned a7i Mar 12, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2024

k8s-ci-robot merged commit 749e81c into kubernetes-sigs:master Mar 13, 2024
10 checks passed

nikimanoledaki mentioned this pull request Mar 29, 2024

Inter-pod anti-affinity check for NodeFit should not check if Pods are on the same Node already #1370

Closed

nikimanoledaki mentioned this pull request May 23, 2024

fix the issue that the pod anti-filtering rules are not taking effect #1395

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` #1356

Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` #1356

nikimanoledaki commented Feb 27, 2024 •

edited

Loading

k8s-ci-robot commented Feb 27, 2024

damemi left a comment

nikimanoledaki commented Feb 28, 2024

logyball left a comment

ingvagabund commented Mar 5, 2024

k8s-ci-robot commented Mar 5, 2024

knelasevero commented Mar 6, 2024

nikimanoledaki commented Mar 6, 2024

logyball left a comment

nikimanoledaki commented Mar 12, 2024 •

edited

Loading

nikimanoledaki commented Mar 12, 2024

a7i commented Mar 12, 2024

a7i commented Mar 12, 2024

a7i commented Mar 12, 2024

a7i commented Mar 13, 2024

a7i commented Mar 13, 2024

nikimanoledaki commented Mar 13, 2024

Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in NodeFit() #1356

Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in NodeFit() #1356

Conversation

nikimanoledaki commented Feb 27, 2024 • edited Loading

k8s-ci-robot commented Feb 27, 2024

damemi left a comment

Choose a reason for hiding this comment

nikimanoledaki commented Feb 28, 2024

logyball left a comment

Choose a reason for hiding this comment

ingvagabund commented Mar 5, 2024

k8s-ci-robot commented Mar 5, 2024

knelasevero commented Mar 6, 2024

nikimanoledaki commented Mar 6, 2024

logyball left a comment

Choose a reason for hiding this comment

nikimanoledaki commented Mar 12, 2024 • edited Loading

nikimanoledaki commented Mar 12, 2024

a7i commented Mar 12, 2024

a7i commented Mar 12, 2024

a7i commented Mar 12, 2024

a7i commented Mar 13, 2024

a7i commented Mar 13, 2024

nikimanoledaki commented Mar 13, 2024

Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` #1356

Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` #1356

nikimanoledaki commented Feb 27, 2024 •

edited

Loading

nikimanoledaki commented Mar 12, 2024 •

edited

Loading