Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh conformance tests should be careful with parentRef groups #2309

Closed
kflynn opened this issue Aug 15, 2023 · 0 comments · Fixed by #2310
Closed

Mesh conformance tests should be careful with parentRef groups #2309

kflynn opened this issue Aug 15, 2023 · 0 comments · Fixed by #2310
Assignees
Labels
area/conformance kind/bug Categorizes issue or PR as related to a bug.

Comments

@kflynn
Copy link
Contributor

kflynn commented Aug 15, 2023

In many cases, the mesh conformance tests are applying HTTPRoutes including, for example:

parentRefs:
  - kind: Service
    name: echo-v2

The astute reader will note the absence of a group. Per the parentRefs specification:

When [group is] unspecified, "gateway.networking.k8s.io" is inferred.

This is problematic, because gateway.networking.k8s.io doesn't contain a Service. Meshes which correctly interpret parentRefs will fail these tests.

How to reproduce it (as minimally and precisely as possible):

Run the conformance tests with the HTTPResponseHeaderModification feature enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/conformance kind/bug Categorizes issue or PR as related to a bug.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants