Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPU driver enabled Ubuntu(18.04 & 20.04) GCE image #934

Conversation

aniruddha2000
Copy link

@aniruddha2000 aniruddha2000 commented Jul 8, 2022

What this PR does / why we need it:

Creates the Ubuntu (18.04 & 20.04) GCE image with GPU drivers pre-installed.

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Additional context
Waiting for 907 to be merged so that we can be sure about the ssh connection.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 8, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @aniruddha2000!

It looks like this is your first PR to kubernetes-sigs/image-builder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/image-builder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 8, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @aniruddha2000. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 8, 2022
@aniruddha2000
Copy link
Author

/cc @dims @richardcase @cpanato

@richardcase
Copy link
Member

/ok-to-test

And until #907 merges:

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 8, 2022
images/capi/packer/gce/packer.json Outdated Show resolved Hide resolved
images/capi/packer/gce/ubuntu-1804-gpu.json Outdated Show resolved Hide resolved
@aniruddha2000 aniruddha2000 force-pushed the aniruddha/add-ubuntu-gpu-gce-image branch from fbdb539 to 8822ffb Compare July 8, 2022 16:27
@cpanato
Copy link
Member

cpanato commented Jul 9, 2022

cc @codenrhoden for visibility

@aniruddha2000
Copy link
Author

/cc @codenrhoden

@aniruddha2000 aniruddha2000 force-pushed the aniruddha/add-ubuntu-gpu-gce-image branch from 4ca1f05 to 4bc21f7 Compare July 13, 2022 11:17
Copy link
Member

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

A few minor comments inline. Also, could you update the title and pr description to match the fact that its now 18.04 and 20.04.

images/capi/Makefile Show resolved Hide resolved
images/capi/packer/config/ansible-args.json Outdated Show resolved Hide resolved
@aniruddha2000 aniruddha2000 changed the title [WIP] Add GPU driver enabled Ubuntu 18.04 GCE image [WIP] Add GPU driver enabled Ubuntu(18.04 & 20.04) GCE image Jul 14, 2022
@dims
Copy link
Member

dims commented Aug 23, 2022

@aniruddha2000 are you still working on this? (looks like it is marked as draft/WIP)

@richardcase
Copy link
Member

@dims - it’s waiting for #907 to merge. Although we could probably work around this...wdyt @aniruddha2000 @SubhasmitaSw ?

@aniruddha2000
Copy link
Author

Yes @dims @richardcase we should go for a workaround

images/capi/packer/gce/ubuntu-1804-gpu.json Outdated Show resolved Hide resolved
@@ -1,4 +1,5 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any make target for Ubuntu 22.04. Is it supported with GPU builds?

Signed-off-by: Aniruddha Basak <codewithaniruddha@gmail.com>

 #Add scripts to install drivers in Ubuntu 1804 image
…e existing one

Signed-off-by: Aniruddha Basak <codewithaniruddha@gmail.com>
@aniruddha2000 aniruddha2000 force-pushed the aniruddha/add-ubuntu-gpu-gce-image branch from d457a7a to 2a19dc4 Compare October 12, 2023 04:17
@mboersma
Copy link
Contributor

/retest

These errors should be fixed now that #1320 merged.

@aniruddha2000
Copy link
Author

Thanks @mboersma

@jsturtevant
Copy link
Contributor

Looks like the tests are passing, @aniruddha2000 there are a few open comments on the PR, could you address them and then I think we can move forward with the PR.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 5, 2024
@richardcase
Copy link
Member

Looks like the tests are passing, @aniruddha2000 there are a few open comments on the PR, could you address them and then I think we can move forward with the PR.

@aniruddha2000 - just checking in to see if you could handle the comments? let me know if can't and i can help out.

@aniruddha2000
Copy link
Author

@richardcase can you take this for now? I am bit occupied

@richardcase
Copy link
Member

@richardcase can you take this for now? I am bit occupied

I can, thanks @aniruddha2000

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 10, 2024
@richardcase
Copy link
Member

I need to work on this, so:

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Mar 15, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codenrhoden
Copy link
Contributor

/uncc @codenrhoden

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 1, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 31, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.