-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated contributing doc to correct script names #1431
Updated contributing doc to correct script names #1431
Conversation
Mention the correct verify/* and update/* script names in the contributing docs to prevent confusion for the new developers. In passing, surrounded some command names with back-ticks.
Hi @gurjeet. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @munnerz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
I think that some of these docs are outdated, i.e., the generated bindata is no longer needed IIRC, but the PR is legit, the scripts moved to folders a while ago 😄 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, gurjeet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Mention the correct verify/* and update/* script names in the
contributing docs to prevent confusion for the new developers.
In passing, surrounded some command names with back-ticks.