Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated QEMU image and added cross build support for s390x kind binary and associated images #2494

Closed

Conversation

guirish
Copy link
Contributor

@guirish guirish commented Oct 12, 2021

Updated QEMU image to tonistiigi/binfmt:qemu-v6.1.0 and added cross build support for s390x kind binary and associated images.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 12, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @guirish. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: guirish
To complete the pull request process, please assign amwat after the PR has been reviewed.
You can assign the PR to them by writing /assign @amwat in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 12, 2021
@aojea
Copy link
Contributor

aojea commented Oct 12, 2021

Please sign the CLA @guirish

@guirish
Copy link
Contributor Author

guirish commented Oct 12, 2021

"I signed it"

@@ -46,11 +46,12 @@ export GOOS=darwin GOARCH=arm64
export GOOS=linux GOARCH=amd64
export GOOS=linux GOARCH=arm64
export GOOS=linux GOARCH=ppc64le
export GOOS=linux GOARCH=s390x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO (unrelated to this PR): add ppc64le back to images/Makefile.common.in or drop it here.

@BenTheElder
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 12, 2021
@BenTheElder
Copy link
Member

The commit in this PR is not associated with your GitHub account (I think maybe email not included?), the CNCF CLA bot requires that:

  1. You have a signed CLA associated with your GitHub account
  2. Your commits are associated with GitHub accounts that have signed the CLA (some of them can be from others but they must also be accounts that meet 1))

Right now it's failing on 2).

@BenTheElder
Copy link
Member

#23 2.340 go: github.com/coreos/go-iptables@v0.4.5: Get "https://proxy.golang.org/github.com/coreos/go-iptables/@v/v0.4.5.mod": tls: invalid signature by the server certificate: ECDSA verification failure
#23 ERROR: process "/bin/sh -c go mod download" did not complete successfully: exit code: 1

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kind/2494/pull-kind-build/1447949063788957696 🤔

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 13, 2021
@aojea
Copy link
Contributor

aojea commented Oct 13, 2021

The file https://github.com/kubernetes-sigs/kind/blob/main/images/base/Dockerfile has to be updated to download the corresponding dependencies

@aojea
Copy link
Contributor

aojea commented Oct 13, 2021

it only needs

diff --git a/images/base/update-shasums.sh b/images/base/update-shasums.sh
index 8876e833..86c30ac8 100755
--- a/images/base/update-shasums.sh
+++ b/images/base/update-shasums.sh
@@ -39,6 +39,7 @@ ARCHITECTURES=(
     "amd64"
     "arm64"
     "ppc64le"
+    "s390x"
 )
 
 echo

@aojea
Copy link
Contributor

aojea commented Oct 13, 2021

I'll take it from here, and add it for the image base bump

@aojea aojea mentioned this pull request Oct 13, 2021
@aojea
Copy link
Contributor

aojea commented Oct 13, 2021

/hold
part of #2465

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2021
@BenTheElder
Copy link
Member

rebased merged in #2465

thanks!

@rohitsakala
Copy link

rohitsakala commented Nov 9, 2021

Hi, which kind version and on what date will have s390x support ? @BenTheElder Thanks :)

@BenTheElder
Copy link
Member

In the next release there will be very limited support in which the non-configurable development images are s390x, and the binary is s390x. There is no intention to build node images for s390x at this time, nor CI / testing.
There is no release date yet, releases and in general all work on this repo are best-effort.

@BenTheElder
Copy link
Member

Also noting: I've had builds hang on s390x a few times now :/
These issues + limited-to-nonexistent demand are why PPC64LE never made it to full support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants