Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve logging #23

Closed
4 tasks done
BenTheElder opened this issue Sep 21, 2018 · 7 comments
Closed
4 tasks done

improve logging #23

BenTheElder opened this issue Sep 21, 2018 · 7 comments
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@BenTheElder
Copy link
Member

BenTheElder commented Sep 21, 2018

  • make log level configurable
  • improve differentiation between print, info, debug etc.
    • we should use print & friends for normal user level info
    • use info for debug-ish details like "running this command"
    • use debug for trace-ish level details
    • use warn & error as appropriate
  • revisit structured logging
  • look at adding "quiet" modes to all commands

/kind cleanup
/assign

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 21, 2018
This was referenced Sep 21, 2018
@BenTheElder
Copy link
Member Author

I've done most of this
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Oct 23, 2018
@BenTheElder
Copy link
Member Author

xref: #109

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels Apr 27, 2019
@BenTheElder BenTheElder removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 1, 2019
@BenTheElder
Copy link
Member Author

still a major issue, probably will switch to klog / logr to match the ecosystem and rework what we log then...

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 1, 2019
@BenTheElder
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 1, 2019
@BenTheElder
Copy link
Member Author

this is more or less done now, we can make the logger a little nicer but we've improved a lot here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

3 participants