-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding one more related project #279
Conversation
Welcome @mitar! It looks like this is your first PR to kubernetes-sigs/kind 🎉 |
Hi @mitar. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, mitar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
will also need to capture in #268. |
[manual merge due to netlify failure blocking the robot, xref #268] |
If you are reordering things in #268 I would suggest this one in this PR is also put towards the top because it is very aligned/similar to this project as well. |
ordering in #268 is based on visual length, otherwise kubeadm-dind-cluster
would be at the top as the closest, what I meant by capturing it there is
also in the site since that copies from the readme.
…On Thu, Feb 7, 2019 at 10:01 AM Mitar ***@***.***> wrote:
If you are reordering things in #268
<#268> I would suggest this
one in this PR is also put towards the top because it is very
aligned/similar to this project as well.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#279 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA4BqyyyDrwP-WO3ugCWY6_KQ8K3mnrtks5vLGnngaJpZM4anpuT>
.
|
@mitar: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* Fix add override vars * Clean code * Clean code
No description provided.