Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates linux default installation #2859

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Updates linux default installation #2859

merged 2 commits into from
Aug 4, 2022

Conversation

rewanthtammana
Copy link
Contributor

The most common installation location in linux is, /usr/local/bin. It's easier to copy-paste the snippet with actual values rather the whatever-path everytime.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 3, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @rewanthtammana!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @rewanthtammana. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 3, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 3, 2022
neolit123
neolit123 reviewed Aug 3, 2022
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2022
@neolit123
Copy link
Member

/ok-to-test
/kind documentation

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. kind/documentation Categorizes issue or PR as related to documentation. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 3, 2022
@rewanthtammana
Copy link
Contributor Author

/test pull-kind-build

@rewanthtammana
Copy link
Contributor Author

@neolit123 I think the builds are failing for wrong reason. I made changes to the documentation but they are failing due to CSI volumes,etc in pull-kind-e2e-kubernetes-1-24. Can you please suggest what changes are required?

@neolit123
Copy link
Member

could be test flakes

BenTheElder
BenTheElder reviewed Aug 3, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@BenTheElder
Copy link
Member

/override pull-kind-e2e-kubernetes-1-24

Thanks for the PR, sorry for the test flake noise.

Since we've split out mac vs linux, this makes sense per linux FHS, one comment about permissions.

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Overrode contexts on behalf of BenTheElder: pull-kind-e2e-kubernetes-1-24

In response to this:

/override pull-kind-e2e-kubernetes-1-24

Thanks for the PR, sorry for the test flake noise.

Since we've split out mac vs linux, this makes sense per linux FHS, one comment about permissions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Aug 3, 2022
Closed
Closed
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2022
@rewanthtammana
Copy link
Contributor Author

I made the recommended changes, @BenTheElder @neolit123!

stmcginnis
stmcginnis reviewed Aug 4, 2022
View reviewed changes
README.md
@@ -49,7 +49,7 @@ On Linux:
```console
curl -Lo ./kind "https://kind.sigs.k8s.io/dl/v0.14.0/kind-$(uname)-amd64"
chmod +x ./kind
mv ./kind /some-dir-in-your-PATH/kind
sudo mv ./kind /usr/local/bin/kind
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All instances should be updated. There are at least lines 75 and 82 in this file and lines 74 and 81 in site/content/docs/user/quick-start.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 74 is for Mac & line 82 is for windows. I'm not a user of macOS/windows yet; hence I'm not sure of their default preferred locations. So, I made changes only to Linux installation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can leave discussion on changing those for a different PR, IIRC macOS SIP makes it more problematic to suggest installing to system folders vs a user local folder added to path (like ~/go/bin)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a plan! There might be considerable discrepancies regarding macOS & windows default install locations.

BenTheElder
BenTheElder approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2022
@BenTheElder BenTheElder merged commit 29b5b24 into kubernetes-sigs:main Aug 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, rewanthtammana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2022
@rewanthtammana
Copy link
Contributor Author

Thanks for the prompt response & the merge, @BenTheElder :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@BenTheElder BenTheElder BenTheElder approved these changes

@stmcginnis stmcginnis stmcginnis left review comments

@amwat amwat Awaiting requested review from amwat

Assignees

@neolit123 neolit123

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rewanthtammana @k8s-ci-robot @neolit123 @BenTheElder @stmcginnis