Fix load docker-image re-tagging with prefix

[Vlatombe]

When loading a docker image that has already been loaded with a new tag, its name is not sanitized on import, leading to an inconsistent tag present in the kind container.

Reproducer with latest kind release (v0.16.0)

$ docker pull maven:3-jdk-11
$ docker tag maven:3-jdk-11 maven:test

Import the first tag

$ kind --name $cluster load docker-image maven:3-jdk-11
Image: "maven:3-jdk-11" with ID "sha256:a016b74d0cb2fdf1adcc87a85d6eb6fc4c299bf550def4d2b752b10f6f1cdbf1" not yet present on node "$cluster-control-plane", loading...

Then import the second tag

$ kind --name $cluster load docker-image maven:test
Image with ID: sha256:a016b74d0cb2fdf1adcc87a85d6eb6fc4c299bf550def4d2b752b10f6f1cdbf1 already present on the node $cluster-control-plane but is missing the tag maven:test. re-tagging...

Inspecting content of the internal registry shows that the new image hasn't been prefixed with docker.io/library as it was done for the first load.

$ docker exec $cluster-control-plane ctr -n k8s.io images list | grep maven
docker.io/library/maven:3-jdk-11                                                                                           application/vnd.docker.distribution.manifest.v2+json      sha256:89b095d4e90aaf193a782e16b53d0ba268ef75752a943b17aa346b632894c8fc 636.0 MiB linux/arm64                                                                  io.cri-containerd.image=managed
maven:test                                                                                                                 application/vnd.docker.distribution.manifest.v2+json      sha256:89b095d4e90aaf193a782e16b53d0ba268ef75752a943b17aa346b632894c8fc 636.0 MiB linux/arm64                                                                  io.cri-containerd.image=managed

[jglick]

Possibly related: #2394 #2835 #2922

[jglick]

Failed workaround:

$ kind load docker-image docker.io/library/maven:test
Image: "docker.io/library/maven:test" with ID "sha256:…" found to be already present on all nodes.

[jglick]

Looks right (untested).

[k8s-ci-robot]

Welcome @Vlatombe!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Vlatombe. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@jglick: changing LGTM is restricted to collaborators

In response to this:

Looks right (untested).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[harshanarayana]

Thanks @Vlatombe This is definitely a case that I missed in #2786

[aojea]

/ok-to-test

[BenTheElder]

/lgtm
/approve
thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, jglick, Vlatombe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [BenTheElder]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[BenTheElder]

flake:

Kubernetes e2e suite: [It] [sig-apps] StatefulSet Basic StatefulSet functionality [StatefulSetBasic] should provide basic identity

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kind/2955/pull-kind-e2e-kubernetes/1578110956825743360
/retest

[aojea]

I was wondering if we should always sanitize the images names?