-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log cluster version in e2e-ci.sh #3083
Conversation
@@ -192,6 +179,9 @@ EOF | |||
-v=3 \ | |||
"--config=${ARTIFACTS}/kind-config.yaml" | |||
|
|||
# debug cluster version | |||
kubectl version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also just for anyone else following along we do log the kubernetes version (like v1.25.0
) in a file when we dump kind export logs
to $ARTIFACTS
, but that misses for example the go version. the version reported comes from the build system and is what kind uses internally to understand what version the node image is.
@@ -118,22 +118,9 @@ create_cluster() { | |||
runtime_config="{}" | |||
;; | |||
true) | |||
case "${KUBE_VERSION}" in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair enough :+)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.