Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require go 1.17+ #3335

Merged
merged 9 commits into from
Apr 1, 2024
Merged

Require go 1.17+ #3335

merged 9 commits into from
Apr 1, 2024

Commits on Apr 1, 2024

  1. Require go 1.17+ 

    This enables better dependency management via  https://go.dev/ref/mod#graph-pruning

We previously required 1.16+

We don't want to require especially recent versions because that will break users with `go install` using older packaged golang.

We use currently supported much more recent go for our own builds.
    @BenTheElder
    BenTheElder committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    4121af1 View commit details
    Browse the repository at this point in the history

  2. disbale unused-parameter lint for now

    @BenTheElder
    BenTheElder committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    a8ee57f View commit details
    Browse the repository at this point in the history

  3. rename copy helper to avoid redefining built-in

    @BenTheElder
    BenTheElder committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    7c05010 View commit details
    Browse the repository at this point in the history

  4. fix if-return redundant if ...; err != nil check lint

    @BenTheElder
    BenTheElder committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    5f59a83 View commit details
    Browse the repository at this point in the history

  5. switch kindnetd to generic sets 

    kindnetd is typically pre-compiled and not installed with "go get", kind development already uses much more recent go so requiring 1.18 for kindnetd is fine
    @BenTheElder
    BenTheElder committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    f9a254d View commit details
    Browse the repository at this point in the history

  6. upgrade to go1.21

    @BenTheElder
    BenTheElder committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    2b793f9 View commit details
    Browse the repository at this point in the history

  7. force GOTOOLCHAIN="go${GO_VERSION}" for now 

    TODO: look at using deprecating .go-version in favor of GOTOOLCHAIN existing knobs
    @BenTheElder
    BenTheElder committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    3652d39 View commit details
    Browse the repository at this point in the history

  8. add missing GOTOOLCHAIN

    @BenTheElder
    BenTheElder committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    738f237 View commit details
    Browse the repository at this point in the history

  9. nerdctl: fix if-return lint

    @BenTheElder
    BenTheElder committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    58508bc View commit details
    Browse the repository at this point in the history