Require go 1.17+ #3335

BenTheElder · 2023-08-24T21:09:09Z

This enables better dependency management via https://go.dev/ref/mod#graph-pruning

We previously required 1.16+

We don't want to require especially recent versions because that will break users with go install using older packaged golang.

We use currently supported much more recent go for our own builds.

NOTE: there are no docs changes yet, because the docs have users installing v0.20 which is still compatible with go 1.16

k8s-ci-robot · 2023-08-24T21:09:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [BenTheElder]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

BenTheElder · 2023-08-24T21:22:35Z

had to update the tools while working on this, looks like we picked up some new linter issues, working on resolving.

BenTheElder · 2023-08-24T21:52:14Z

images/kindnetd/cmd/kindnetd/main.go

@@ -252,7 +252,7 @@ func makeNodesReconciler(cniConfig *CNIConfigWriter, hostIP string, ipFamily IPF

 		// obtain the PodCIDR gateway
 		var nodeIPv4, nodeIPv6 string
-		for _, ip := range nodeIPs.List() {
+		for _, ip := range sets.List(nodeIPs) {


[this is the non-deprecated way to use the sets package]

aojea · 2023-08-25T14:19:58Z

go.mod

+// See ./.go-version for the go compiler version used when building binaries
+//
+// https://go.dev/doc/modules/gomod-ref#go
+go 1.17


well , this is changing in 1.21

For example, a go.mod that says go 1.21.0 with no toolchain line is interpreted as if it had a toolchain go1.21.0 line.

https://go.dev/doc/toolchain

We should rework everything around .go-version to switch to this toolchain line.

Thanks, I forgot about this.

so, I added a commit to deal with this, but the remaining downside (Also true in k/k currently), is that IDEs won't see all our bash hacks.

what we probably need to do is pivot to setting toolchain in the go mods and then also for the image builds of external binaries, but that's going to force us to decentralize setting the go version unfortunately.

the current PR is enough to ensure our builds / tools work at least

aojea · 2023-08-25T14:22:09Z

just the question about the behavior change in golang with 1.21, the rest LGTM

BenTheElder · 2023-12-14T20:16:38Z

I'm going to finish this up today, ahead of generally bumping things for a v0.21 cut.

BenTheElder · 2023-12-14T20:19:00Z

It's going to be a bit awkward to re-work this around plumbing GOTOOLCHAIN and I'm not sure what the best answer is, we've definitely got downstreams depending on patching .go-version. It might be best to just break that in favor of toolchain in the modules and put a release note. Need to think a bit.

BenTheElder · 2024-02-02T00:02:51Z

I'm punting this to the next release because we really need to get that runc CVE out, but some veersion of the changes here probably need to be high on the list longterm as part of switching to go1.21+

BenTheElder · 2024-02-02T00:50:56Z

rebased and started forcing GOTOOLCHAIN="go${GOVERSION}" everywhere for now.

BenTheElder · 2024-02-02T02:08:49Z

pull-kind-conformance-parallel-ga-only — Pod got deleted unexpectedly

/retest

BenTheElder · 2024-02-06T23:12:38Z

@aojea go 1.22 released so go 1.20 will be EOL and we'll have to sort this out. Will aim to look again later this week for better iteration, but the current version should be usable.

aojea · 2024-03-25T21:35:17Z

.go-version

@@ -1 +1 @@
-1.20.13
+1.21.6


this should be 1.22 no?

this PR has been around awaiting review for a while :-)

we're still on 1.20.13 @ HEAD

aojea · 2024-03-25T21:55:48Z

images/base/Dockerfile

@@ -141,6 +143,7 @@ RUN git clone --filter=tree:0 "${RUNC_CLONE_URL}" /runc \
    && cd /runc \
    && git checkout "${RUNC_VERSION}" \
    && eval "$(gimme "${GO_VERSION}")" \
+    && export GOTOOLCHAIN="go${GO_VERSION}" \


line159 seems is missing this export too

yes. I will add this and bump up the go versions again

fixed this one.

aojea · 2024-03-25T21:56:44Z

images/kindnetd/go.mod

@@ -1,6 +1,6 @@
 module sigs.k8s.io/kind/images/kindnetd

-go 1.13
+go 1.18


why don't you move to latest here then?

it matched kubernetes at the time. note that this is not the go version used to compile, this is the language level features used.

let's leave this for a later PR, this PR is already a lot and I don't want to deal with any breakage while trying to get the rest of the PR in.

This enables better dependency management via https://go.dev/ref/mod#graph-pruning We previously required 1.16+ We don't want to require especially recent versions because that will break users with `go install` using older packaged golang. We use currently supported much more recent go for our own builds.

kindnetd is typically pre-compiled and not installed with "go get", kind development already uses much more recent go so requiring 1.18 for kindnetd is fine

TODO: look at using deprecating .go-version in favor of GOTOOLCHAIN existing knobs

BenTheElder · 2024-04-01T22:56:30Z

TODO:

rebump everything to latest
explore using go.mod gotoolchain instead (need to handle things like the gimme fallback, and approach to keep these in sync or not)

leaving for follow-ups, I want to get in the core "we're unblocked to manage go versions with 1.21+ without switching language version to 1.21+" so we can collectively iterate from there (requiring 1.17+ also cleans up dep management and go get vs go install, required some docs changes)

BenTheElder · 2024-04-01T22:58:49Z

There is a new linter failure from nerdctl code, fixing ...

aojea · 2024-04-01T23:11:47Z

/lgtm

BenTheElder · 2024-04-01T23:22:29Z

/retest
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kind/3335/pull-kind-e2e-kubernetes-1-28/1774934849065324544

network glitch during cloning, not related.

BenTheElder · 2024-04-03T16:39:43Z

hrm, that's not good.

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-kind-push-base-image/1774949333360185344

BenTheElder · 2024-04-03T16:42:51Z

ah, I know what this is. patch coming in a bit (dealing with some internal work atm)

BenTheElder · 2024-04-06T00:47:48Z

base is building again

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 24, 2023

k8s-ci-robot requested review from aojea and neolit123 August 24, 2023 21:09

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 24, 2023

BenTheElder mentioned this pull request Aug 24, 2023

Add API for CDI --devices flag in Docker and Podman for mapping GPUs #3290

Open

k8s-ci-robot added area/provider/docker Issues or PRs related to docker area/provider/podman Issues or PRs related to podman labels Aug 24, 2023

BenTheElder commented Aug 24, 2023

View reviewed changes

BenTheElder force-pushed the go1.17+ branch from 441bee3 to 6b5f6f0 Compare August 24, 2023 21:54

BenTheElder assigned aojea Aug 24, 2023

aojea reviewed Aug 25, 2023

View reviewed changes

jacob-delgado mentioned this pull request Oct 5, 2023

Update dependencies go.mod #3378

Closed

BenTheElder added this to the v0.21.0 milestone Dec 14, 2023

BenTheElder mentioned this pull request Dec 14, 2023

Kind 0.20.0 pod create error with 0.20.0 node images #3309

Closed

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2024

BenTheElder mentioned this pull request Feb 1, 2024

use latest go 1.20 (1.20.13) #3498

Merged

BenTheElder force-pushed the go1.17+ branch from 6b5f6f0 to f022b08 Compare February 2, 2024 00:35

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2024

BenTheElder removed this from the v0.21.0 milestone Feb 2, 2024

BenTheElder mentioned this pull request Mar 25, 2024

go.mod: include indirect dependencies #3549

Closed

aojea reviewed Mar 25, 2024

View reviewed changes

BenTheElder mentioned this pull request Apr 1, 2024

ci/dependabot updates #3561

Merged

BenTheElder added 8 commits April 1, 2024 15:52

disbale unused-parameter lint for now

a8ee57f

rename copy helper to avoid redefining built-in

7c05010

fix if-return redundant if ...; err != nil check lint

5f59a83

switch kindnetd to generic sets

f9a254d

kindnetd is typically pre-compiled and not installed with "go get", kind development already uses much more recent go so requiring 1.18 for kindnetd is fine

upgrade to go1.21

2b793f9

force GOTOOLCHAIN="go${GO_VERSION}" for now

3652d39

TODO: look at using deprecating .go-version in favor of GOTOOLCHAIN existing knobs

add missing GOTOOLCHAIN

738f237

BenTheElder force-pushed the go1.17+ branch from 4368aad to 738f237 Compare April 1, 2024 22:54

BenTheElder changed the title ~~[WIP] Require go 1.17+~~ Require go 1.17+ Apr 1, 2024

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2024

nerdctl: fix if-return lint

58508bc

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2024

k8s-ci-robot merged commit 506824a into kubernetes-sigs:main Apr 1, 2024
29 checks passed

BenTheElder deleted the go1.17+ branch April 2, 2024 00:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Require go 1.17+ #3335

Require go 1.17+ #3335

BenTheElder commented Aug 24, 2023

k8s-ci-robot commented Aug 24, 2023

BenTheElder commented Aug 24, 2023

BenTheElder Aug 24, 2023

aojea Aug 25, 2023

BenTheElder Aug 25, 2023

BenTheElder Aug 25, 2023

BenTheElder Feb 2, 2024

BenTheElder Feb 2, 2024

aojea commented Aug 25, 2023

BenTheElder commented Dec 14, 2023

BenTheElder commented Dec 14, 2023

BenTheElder commented Feb 2, 2024

BenTheElder commented Feb 2, 2024

BenTheElder commented Feb 2, 2024 •

edited

Loading

BenTheElder commented Feb 6, 2024

aojea Mar 25, 2024

BenTheElder Mar 25, 2024

BenTheElder Mar 25, 2024

aojea Mar 25, 2024

BenTheElder Mar 26, 2024

BenTheElder Apr 1, 2024

aojea Mar 25, 2024

BenTheElder Mar 26, 2024

BenTheElder Apr 1, 2024

BenTheElder commented Apr 1, 2024 •

edited

Loading

BenTheElder commented Apr 1, 2024

aojea commented Apr 1, 2024

BenTheElder commented Apr 1, 2024

BenTheElder commented Apr 3, 2024

BenTheElder commented Apr 3, 2024

BenTheElder commented Apr 6, 2024

		@@ -1 +1 @@
		1.20.13
		1.21.6

Require go 1.17+ #3335

Require go 1.17+ #3335

Conversation

BenTheElder commented Aug 24, 2023

k8s-ci-robot commented Aug 24, 2023

BenTheElder commented Aug 24, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aojea commented Aug 25, 2023

BenTheElder commented Dec 14, 2023

BenTheElder commented Dec 14, 2023

BenTheElder commented Feb 2, 2024

BenTheElder commented Feb 2, 2024

BenTheElder commented Feb 2, 2024 • edited Loading

BenTheElder commented Feb 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BenTheElder commented Apr 1, 2024 • edited Loading

BenTheElder commented Apr 1, 2024

aojea commented Apr 1, 2024

BenTheElder commented Apr 1, 2024

BenTheElder commented Apr 3, 2024

BenTheElder commented Apr 3, 2024

BenTheElder commented Apr 6, 2024

BenTheElder commented Feb 2, 2024 •

edited

Loading

BenTheElder commented Apr 1, 2024 •

edited

Loading