Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: include indirect dependencies #3549

Closed
wants to merge 1 commit into from

Conversation

AkihiroSuda
Copy link
Member

Bump up the go.mod format so as to help analyzing all the dependencies

Bump up the go.mod format so as to help analyzing all the dependencies

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AkihiroSuda
Once this PR has been reviewed and has the lgtm label, please assign aojea for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 13, 2024
@stmcginnis
Copy link
Contributor

Makes sense if we are bumping up the minimum go version. But that has intentionally been kept back. I would defer to @BenTheElder on whether that is something we want right now or not.

@AkihiroSuda
Copy link
Member Author

@BenTheElder Could you take a look?

@@ -1,6 +1,6 @@
module sigs.k8s.io/kind

go 1.16
go 1.21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've intentionally held this back, people go get / go install kind and use systems with outdated go and we have no particular need for latest go features in the core tool

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've been hacking on bumping it to 1.17 for related reasons but not as far as 1.21 currently #3335

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been waiting for @aojea to take another review pass at #3335, but if we wanted to land a more targeted change, just bumping to 1.17 here will accomplish the same thing with less impact.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They mustn’t use Go 1.20, as it has reached EOL and no longer receives security fixes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's their choice, the kind binary is not particularly sensitive to these as a local non-networked CLI. We document that 1.16+ is required to install currently and have no use case for newer go features for the core project.

Being able to go install on e.g., debian stable, without issues, is something we do not want to break lightly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And again, to get the module pruning, you only need to increase this to 1.17

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't break users without a good reason, lots of new k8s users are installing the kind CLI via their system go and it works fine.

similarly we still have limited support for kubernetes versions that kubernetes no longer supports (e.g. so lagging users can test before/after updating), it would be easier to force only current versions but it has value to users not to and the burden is not too high

Copy link
Member Author

@AkihiroSuda AkihiroSuda Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, closing this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants