Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump containerd to v1.7.16 #3600

Merged
merged 1 commit into from
May 14, 2024

Conversation

abhay-krishna
Copy link
Contributor

This PR bumps the containerd version in the Kind base image to the latest upstream release (version v1.7.16).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 2, 2024
@@ -122,7 +122,7 @@ RUN eval "$(gimme "${GO_VERSION}")" \
# stage for building containerd
FROM go-build as build-containerd
ARG TARGETARCH GO_VERSION
ARG CONTAINERD_VERSION="v1.7.15"
ARG CONTAINERD_VERSION="v1.7.16"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any notable changes to be aware of?

we also usually see runc changed at the same time

Copy link
Contributor Author

@abhay-krishna abhay-krishna May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see any breaking changes, just bug fixes and a CVE fix.

runc has a new RC tag v1.2.0-rc.1 but this is a minor version upgrade from what Kind uses currently, which is v1.1.12, so I had some reservations about upgrading to that one.

@BenTheElder
Copy link
Member

[I forgot to submit my comment here, lost in all the tabs, sorry!]

Let's hold this until after the next release, there don't seem to be any super pressing bug fixes, we've had time to soak the current version in CI, and we're ~overdue for a release.

I think we'll get a release in this week and then shortly after double back and get this in.

Thanks for the PR and your patience!

@abhay-krishna
Copy link
Contributor Author

[I forgot to submit my comment here, lost in all the tabs, sorry!]

Let's hold this until after the next release, there don't seem to be any super pressing bug fixes, we've had time to soak the current version in CI, and we're ~overdue for a release.

I think we'll get a release in this week and then shortly after double back and get this in.

Thanks for the PR and your patience!

Thanks for the response! Sounds good to me, I'll keep an eye on this PR and rebase if necessary.

@BenTheElder BenTheElder added this to the v0.24.0 milestone May 13, 2024
@BenTheElder
Copy link
Member

/hold cancel
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit a471512 into kubernetes-sigs:main May 14, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants