Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up GitHub Action definitions #3655

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Clean up GitHub Action definitions #3655

merged 1 commit into from
Jun 12, 2024

Conversation

stmcginnis
Copy link
Contributor

This defines a local action for the common actions performed by most of our workflows. This reduces duplication between them to make sure they are consistent, and also make the workflow definitions more concise to just the operations that are unique to the particular testing activities.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 11, 2024
aojea
aojea reviewed Jun 11, 2024
View reviewed changes
.github/workflows/vm.yaml Outdated Show resolved Hide resolved
@aojea
Copy link
Contributor

aojea commented Jun 11, 2024

Error: GitHub.DistributedTask.ObjectTemplating.TemplateValidationException: The template is not valid. /home/runner/work/kind/kind/./.github/actions/setup-env/action.yaml (Line: 6, Col: 7): Required property is missing: shell

@stmcginnis
Copy link
Contributor Author

Error: GitHub.DistributedTask.ObjectTemplating.TemplateValidationException: The template is not valid. /home/runner/work/kind/kind/./.github/actions/setup-env/action.yaml (Line: 6, Col: 7): Required property is missing: shell

Yep, I have the missing shell line staged locally. Just wanted to wait until a response on the naming before I pushed it up so I don't waste resources running tests if another update is needed.

@stmcginnis
Clean up GitHub Action definitions
f5c16ab 
This defines a local action for the common actions performed by most of
our workflows. This reduces duplication between them to make sure they
are consistent, and also make the workflow definitions more concise to
just the operations that are unique to the particular testing
activities.

Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
@aojea
Copy link
Contributor

aojea commented Jun 12, 2024

/lgtm
/approve

Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, stmcginnis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7799e72 into kubernetes-sigs:main Jun 12, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@aojea aojea aojea left review comments

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stmcginnis @aojea @k8s-ci-robot @BenTheElder