add image pull retries #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
krzyzacy
reviewed
Sep 27, 2018
pkg/docker/docker.go
Outdated
| } | ||
| } | ||
| if err != nil { | ||
| log.Infof("Failed to pull image: %s", image) |
There was a problem hiding this comment.
will do, fixing kubernetes/test-infra#9592 first
k8s-ci-robot
added
do-not-merge/hold
|
/retest |
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
removed
the
lgtm
BenTheElder
added
the
lgtm
|
(resolved review, re-lgtm so we can soak this, image pulling is one of the major remaining flakes..) |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
stg-0
pushed a commit
to stg-0/kind
that referenced
this pull request
Feb 15, 2023
…_retain_functionality [EOS-10953] fixed --retain bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #29
TODO: make log level configurable and cleanup logging ref #23