Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update deps #534

Merged
merged 3 commits into from
May 15, 2019
Merged

update deps #534

merged 3 commits into from
May 15, 2019

Conversation

BenTheElder
Copy link
Member

with a bit of fiddling I've shrunk the root go.mod and updated dependencies

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2019
@BenTheElder
Copy link
Member Author

steps:

  • update direct dependencies (NOT client-go and k8s.io/api)
  • drop all //indirect from go.mod
  • add back k8s.io/api and k8s.io/apimachinery indirects
  • hand edit client-go and k8s.io/ to updated matching versions
  • result in this go.mod:
module sigs.k8s.io/kind

require (
	github.com/google/gofuzz v1.0.0
	github.com/google/uuid v1.1.1
	github.com/pkg/errors v0.8.0
	github.com/sirupsen/logrus v1.4.1
	github.com/spf13/cobra v0.0.3
	golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2
	k8s.io/api kubernetes-1.14.1 // indirect
	k8s.io/apimachinery kubernetes-1.14.1
	k8s.io/client-go v11.0.0+incompatible
	sigs.k8s.io/kustomize v2.0.3+incompatible
)
  • make build to add in updated indirect dependencies

BenTheElder
BenTheElder commented May 15, 2019
View reviewed changes
go.mod
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
github.com/modern-go/reflect2 v0.0.0-20180701023420-4b7aa43c6742 // indirect
github.com/onsi/ginkgo v1.7.0 // indirect
github.com/onsi/gomega v1.4.3 // indirect
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm really not sure how these were still in the root go.mod (ginkgo, gomega), happy to have the dependencies reduced, it should make building faster :-)

@BenTheElder BenTheElder added this to the 0.3 milestone May 15, 2019
@BenTheElder
Copy link
Member Author

added a similar update for the tools module. same pinning method (1.14.1 kubernetes-wise)

neolit123
neolit123 reviewed May 15, 2019
View reviewed changes
hack/tools/go.sum
k8s.io/gengo v0.0.0-20190327210449-e17681d19d3a h1:QoHVuRquf80YZ+/bovwxoMO3Q/A3nt3yTgS0/0nejuk=
k8s.io/gengo v0.0.0-20190327210449-e17681d19d3a/go.mod h1:ezvh/TsK7cY6rbqRK0oQQ8IAqLxYwwyPxAX1Pzy0ii0=
k8s.io/klog v0.3.0 h1:0VPpR+sizsiivjIfIAQH/rl8tan6jvWkS7lU+0di3lE=
k8s.io/klog v0.3.0/go.mod h1:Gq+BEi5rUBO/HRz0bTSXDUcqjScdoY3a9IHpCEIOOfk=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wanted to note that the whole idea of suffixing a semver with /go.mod is crazy-pants syntax.

/lgtm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may also want to prune these someday, working as intended is growing infinitely with all observed dependency hashes...

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6a2d6fe into kubernetes-sigs:master May 15, 2019
@BenTheElder BenTheElder deleted the update-deps branch May 15, 2019 15:17
stg-0 pushed a commit to stg-0/kind that referenced this pull request Apr 22, 2024
@iamjanr
[CLOUD-205] Support k8s v1.28 (kubernetes-sigs#534)
34df147 
* Fix aws-node permissions

* Update AKS & Azure Unmanaged version for k8s 1.28

* Update AKS & Azure Unmanaged permissions

* Update changelog & gitignore

* Update -en- perm docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@neolit123 neolit123

@amwat amwat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@BenTheElder @k8s-ci-robot @neolit123 @amwat