Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a debug flag to retain the broken nodes for debugging. #74

Merged
merged 3 commits into from
Nov 27, 2018
Merged

Add a debug flag to retain the broken nodes for debugging. #74

merged 3 commits into from
Nov 27, 2018

Conversation

tao12345666333
Copy link
Member

xref: #23

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 24, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 24, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @tao12345666333. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 24, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2018
@BenTheElder
Copy link
Member

Thanks for the PR btw, I think this might need more discussion.

@tao12345666333
Copy link
Member Author

@BenTheElder Addressed. Thanks.

BenTheElder
BenTheElder reviewed Nov 27, 2018
View reviewed changes
cmd/kind/create/cluster/createcluster.go Outdated
@@ -47,6 +48,7 @@ func NewCommand() *cobra.Command {
cmd.Flags().StringVar(&flags.Name, "name", "1", "the cluster context name")
cmd.Flags().StringVar(&flags.Config, "config", "", "path to a kind config file")
cmd.Flags().StringVar(&flags.ImageName, "image", "", "node docker image to use for booting the cluster")
cmd.Flags().BoolVar(&flags.Retain, "retain", false, "whether retain the broken nodes for debugging")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny nit, maybe description should be: "retain nodes for debugging when cluster creation fails"? even if a node is not broken, this flag will retain all of them in the near future.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will update it.

BenTheElder
BenTheElder approved these changes Nov 27, 2018
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold
sorry for the delay, was out for the holiday, this needs rebasing again unfortunately!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2018
@BenTheElder
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 27, 2018
@tao12345666333
Copy link
Member Author

/retest

@tao12345666333
Add a retain flag to retain the broken nodes for debugging.
2f0e2f0 
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333
change retain flag description.
14bcb55 
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333
Copy link
Member Author

/retest

@tao12345666333
remove delete retain flag
a4c8a9b 
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333
Copy link
Member Author

/retest

@tao12345666333
Copy link
Member Author

@BenTheElder PTAL, thanks. ❤️

@BenTheElder
Copy link
Member

will follow up with a refactor to NewContext, thanks again for the PR!
/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 27, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2018
@k8s-ci-robot k8s-ci-robot merged commit bbf6e65 into kubernetes-sigs:master Nov 27, 2018
@tao12345666333 tao12345666333 deleted the add-debug-option branch November 27, 2018 22:47
yankay pushed a commit to yankay/kind that referenced this pull request Mar 17, 2022
@k8s-ci-robot
Merge pull request kubernetes-sigs#74 from danwinship/so-you-want-to-…
7784bea 
…write-a-service-proxy

Add documentation of what the service proxy does
stg-0 pushed a commit to stg-0/kind that referenced this pull request Mar 24, 2023
@lreciomelero
Merge pull request kubernetes-sigs#74 from lreciomelero/fix/Extract_m…
0b266ef 
…hc_from_templates

extracted machinehealthchecks from templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tao12345666333 @k8s-ci-robot @BenTheElder