Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Performance #89

Merged
merged 7 commits into from
Nov 7, 2018
Merged

Improve Performance #89

merged 7 commits into from
Nov 7, 2018

Conversation

BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Nov 7, 2018 •
edited
Loading

  • correct image retagging bug at node boot time
  • avoid repeatedly detecting the kubernetes version installed on the node
  • upgrade node image to docker to 18.06, switch base image to ubuntu:18.04
  • pre-pull images that are not part of the build
  • switch status to using a custom lightweight spinner that should be cheaper / behave better for our use case

cc @munnerz @spiffxp @Katharine

With this I get <= 40s kind create cluster on my linux workstation.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 7, 2018
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 7, 2018
BenTheElder
BenTheElder commented Nov 7, 2018
View reviewed changes
pkg/build/node/node.go
}

// helpers to run things in the build container
execInBuild := func(command ...string) error {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

execing in general needs a cleanup in a follow-up, I have some ideas that will make the exec package much nicer.

@BenTheElder BenTheElder changed the title [WIP] Improve Performance Improve Performance Nov 7, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2018
@BenTheElder
Copy link
Member Author

BenTheElder commented Nov 7, 2018 •
edited
Loading

This should be good to go, in a follow-up I will update the base image and update the default node image to a newer k8s version as well.

PTAL @krzyzacy @munnerz @amwat

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2018
amwat
amwat reviewed Nov 7, 2018
View reviewed changes
Copy link
Contributor

@amwat amwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lint
/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2018
@amwat
Copy link
Contributor

amwat commented Nov 7, 2018

/lint

@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2018
@k8s-ci-robot k8s-ci-robot merged commit 6f628d7 into kubernetes-sigs:master Nov 7, 2018
@BenTheElder BenTheElder deleted the prepull branch November 7, 2018 23:59
This was referenced Nov 7, 2018
Closed
Closed
@tao12345666333 tao12345666333 mentioned this pull request Nov 8, 2018
Closed
@BenTheElder BenTheElder mentioned this pull request Nov 8, 2018
Closed
yankay pushed a commit to yankay/kind that referenced this pull request Mar 17, 2022
@hanamantagoudvk
deleting remaining files of old ipvs files (kubernetes-sigs#89)
f4532e3
stg-0 pushed a commit to stg-0/kind that referenced this pull request Apr 11, 2023
@lreciomelero
Merge pull request kubernetes-sigs#89 from lreciomelero/fix/changed-v…
6c141d4 
…ersion_updating

changed-version_updating
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 left review comments

@amwat amwat amwat left review comments

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@amwat amwat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BenTheElder @k8s-ci-robot @amwat @tao12345666333