Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the docker version to maximum validated version 18.06 #85

Closed
warmchang opened this issue Oct 30, 2018 · 7 comments
Closed

Update the docker version to maximum validated version 18.06 #85

warmchang opened this issue Oct 30, 2018 · 7 comments
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.

Comments

@warmchang
Copy link

Looks like kubernetes support the maximum validated docker is 18.06 now:
kubernetes/website#10299
kubernetes/test-infra#9444
kubernetes/kubernetes#68495
https://kubernetes.io/docs/setup/cri/#docker

On each of your machines, install Docker. Version 18.06 is recommended, but 1.11, 1.12, 1.13 and 17.03 are known to work as well. Keep track of the latest verified Docker version in the Kubernetes release notes.

So we can update the docker version to 18.06 in images/base/Dockerfile. 😃

# NOTE: 17.03 is officially supported by Kubernetes currently, so we pin to that.
# https://kubernetes.io/docs/tasks/tools/install-kubeadm/
ARG DOCKER_VERSION="17.03.2~ce-0~debian-stretch"

@BenTheElder
Copy link
Member

/cc @munnerz
Probably we should also consider switching to an Ubuntu base image too so that:

  • we can use newer systemd without hacks
  • we don't circularly depend on an image from k/k
  • we can use the Ubuntu guides for install
    ... But still use the Debian package logic we have setup.

I think the 18.04 image should be small enough.

This docker version was the main reason for using debian-base. We used that one due to validation from sig-node, but I agree we should upgrade 👍

/assign
/kind cleanup
/lifecycle active

@k8s-ci-robot k8s-ci-robot added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 30, 2018
@neolit123
Copy link
Member

neolit123 commented Oct 30, 2018

Update the docker version to maximum validated version 18.06

validated by k8s consumers and contributors.
AFAIK sig-node will no longer do the validation process they were doing for previous releases.

@warmchang
Copy link
Author

AFAIK sig-node will no longer do the validation process they were doing for previous releases.

The PR kubernetes/test-infra#9444 in project test-infra added Docker 18.06 to the CI tests.

And an other PR kubernetes/test-infra#9379 from BenTheElder upgraded docker in bootsrap to 18.06 (Please ignore the comment and issue 6187 has been fixed.):

image

https://github.com/kubernetes/test-infra/blob/f97e35a467fdfbc3bb50fed8d5be9328cf62c02a/images/bootstrap/Dockerfile#L102

@neolit123
Copy link
Member

yes, i saw these when they merged, we do have 18.06 test signal.
but it's not the same sig-node validation.

@warmchang
Copy link
Author

warmchang commented Oct 31, 2018

ok, I understand.

@BenTheElder
Copy link
Member

Yep, that's something else entirely, I have some work that includes this though, will PR later today.

@BenTheElder
Copy link
Member

Done in #89

stg-0 added a commit to stg-0/kind that referenced this issue Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Development

No branches or pull requests

4 participants