Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade project to use go 1.13 #1135

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@camilamacedo86
Copy link
Contributor

camilamacedo86 commented Oct 28, 2019

Description
Upgrade the project to work/used 1.13 go and its tests

Motivation
Closes: #1134

@k8s-ci-robot k8s-ci-robot requested review from DirectXMan12 and mengqiy Oct 28, 2019
@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Oct 28, 2019
@camilamacedo86 camilamacedo86 force-pushed the camilamacedo86:go-up branch from 08af4f6 to 4efbf6d Oct 28, 2019
@k8s-ci-robot k8s-ci-robot added size/L and removed size/S labels Oct 28, 2019
@camilamacedo86 camilamacedo86 changed the title add go 1.13 to travis Upgrade project to use go 1.13 Oct 28, 2019
@camilamacedo86 camilamacedo86 force-pushed the camilamacedo86:go-up branch from 4efbf6d to be43b34 Oct 28, 2019
@k8s-ci-robot k8s-ci-robot added size/XL and removed size/L labels Oct 28, 2019
@camilamacedo86 camilamacedo86 force-pushed the camilamacedo86:go-up branch from e4ab2c4 to 9b765d9 Oct 28, 2019
@k8s-ci-robot k8s-ci-robot added size/L and removed size/XL labels Oct 28, 2019
@camilamacedo86 camilamacedo86 force-pushed the camilamacedo86:go-up branch 2 times, most recently from 05faff0 to 30a8209 Oct 28, 2019
@k8s-ci-robot k8s-ci-robot added size/M and removed size/L labels Oct 28, 2019
@camilamacedo86 camilamacedo86 force-pushed the camilamacedo86:go-up branch from 30a8209 to e206c28 Oct 28, 2019
@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Oct 28, 2019
@camilamacedo86 camilamacedo86 force-pushed the camilamacedo86:go-up branch from e206c28 to 9dfff03 Oct 28, 2019
@k8s-ci-robot k8s-ci-robot added size/M and removed size/L labels Oct 28, 2019
@camilamacedo86 camilamacedo86 force-pushed the camilamacedo86:go-up branch 3 times, most recently from 8b0a8c1 to 475bb28 Oct 28, 2019
Copy link
Contributor

DirectXMan12 left a comment

one comment inline, otherwise:

We're going to have to pull the trigger on moving stuff to 1.13 eventually, and it's been a few months now. The only blocker is k/k moving, but I don't think we can wait forever on that, and the issues affecting k/k don't have any bearing on us.

I propose a scream test -- if anyone has any serious issues, we'll hear about it shortly.

We'll need a corresponding update to prow, otherwise we'll bork things.

testdata/project-v2/go.mod Show resolved Hide resolved
@camilamacedo86 camilamacedo86 force-pushed the camilamacedo86:go-up branch from 66d0441 to 2a8ba1b Nov 6, 2019
@camilamacedo86 camilamacedo86 requested a review from DirectXMan12 Nov 6, 2019
@camilamacedo86

This comment has been minimized.

Copy link
Contributor Author

camilamacedo86 commented Nov 7, 2019

H @DirectXMan12,

All done 👍 Also, shows that k8s will be upgraded as well uhu here.

@mengqiy

This comment has been minimized.

Copy link
Contributor

mengqiy commented Nov 8, 2019

k/k is now on golang1.13 with kubernetes/kubernetes#82809 merged.

@camilamacedo86

This comment has been minimized.

Copy link
Contributor Author

camilamacedo86 commented Nov 8, 2019

Hi @mengqiy and @DirectXMan12,

Let's merge this one? If not, let me know what is missing for we are able to move forward.

@camilamacedo86

This comment has been minimized.

Copy link
Contributor Author

camilamacedo86 commented Nov 8, 2019

/assign @droot

@camilamacedo86

This comment has been minimized.

Copy link
Contributor Author

camilamacedo86 commented Nov 8, 2019

/assign @DirectXMan12

@camilamacedo86

This comment has been minimized.

Copy link
Contributor Author

camilamacedo86 commented Nov 8, 2019

/assign @mengqiy

@mengqiy
mengqiy approved these changes Nov 8, 2019
Copy link
Contributor

mengqiy left a comment

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 8, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9eeec12 into kubernetes-sigs:master Nov 8, 2019
4 of 5 checks passed
4 of 5 checks passed
tide Not mergeable. Needs approved label.
Details
cla/linuxfoundation camilamacedo86 authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/kubebuilder/deploy-preview Deploy preview ready!
Details
pull-kubebuilder-test Job succeeded.
Details
@DirectXMan12

This comment has been minimized.

Copy link
Contributor

DirectXMan12 commented Nov 8, 2019

k/k is now on golang1.13 with kubernetes/kubernetes#82809 merged.

Full steam ahead on the 1.13 train, then 🚂


require (
github.com/go-logr/logr v0.1.0
github.com/robfig/cron v1.2.0
golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2 // indirect

This comment has been minimized.

Copy link
@Adirio

Adirio Nov 11, 2019

Contributor

My IDE is inserting this line automatically when I pulled this PR. Does it really need to be removed?

This comment has been minimized.

Copy link
@camilamacedo86

camilamacedo86 Nov 11, 2019

Author Contributor

It will be removed when we do a go mod tidy than it should not be committed.


require (
github.com/go-logr/logr v0.1.0
github.com/onsi/ginkgo v1.6.0
github.com/onsi/gomega v1.4.2
golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2 // indirect

This comment has been minimized.

Copy link
@Adirio

Adirio Nov 11, 2019

Contributor

Same as above.

@Adirio

This comment has been minimized.

Copy link
Contributor

Adirio commented Nov 11, 2019

@camilamacedo86 camilamacedo86 deleted the camilamacedo86:go-up branch Nov 11, 2019
@ncdc ncdc referenced this pull request Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.