Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegate go vet and go fmt to golangci-lint #1310

Merged
merged 2 commits into from
Jan 16, 2020
Merged

Delegate go vet and go fmt to golangci-lint #1310

merged 2 commits into from
Jan 16, 2020

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Jan 14, 2020

go vet and go fmt were being called before golangci-lint. The later is able to run those two checks and that will benefit from the speed enhancements golangci-lint does (concurrency, evaluating files only once, building shared caches, etc.)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 14, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @Adirio. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 14, 2020
@Adirio
Copy link
Contributor Author

Adirio commented Jan 14, 2020

@camilamacedo86 Thoughts on this?

@Adirio Adirio closed this Jan 14, 2020
@Adirio Adirio reopened this Jan 14, 2020
@Adirio Adirio mentioned this pull request Jan 14, 2020
Closed
41 tasks
camilamacedo86
camilamacedo86 approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2020
@camilamacedo86
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 15, 2020
@Adirio
Copy link
Contributor Author

Adirio commented Jan 16, 2020

/cc @mengqiy @DirectXMan12

estroz
estroz reviewed Jan 16, 2020
View reviewed changes
scripts/verify.sh
@@ -14,20 +14,14 @@
# See the License for the specific language governing permissions and
# limitations under the License.

set -e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for removing this?

Copy link
Contributor Author

@Adirio Adirio Jan 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set -e makes it return when first fails but there is only 1 test from bash perspective, right?

estroz
estroz reviewed Jan 16, 2020
View reviewed changes
scripts/verify.sh
# --enable=lll
# --enable=goconst
# --enable=gosec
# --enable=maligned

GO111MODULES=on go list -mod=readonly ./...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for removing this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has no need .

Copy link
Contributor Author

@Adirio Adirio Jan 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just listing the modules in Travis, not needed, just consumes resources (I know, its negligible but...)

estroz
estroz reviewed Jan 16, 2020
View reviewed changes
scripts/verify.sh
@@ -37,18 +31,14 @@ golangci-lint run --disable-all \
--enable=ineffassign \
--enable=nakedret \
--enable=interfacer \
--enable=misspell \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for removing this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicated :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, it's a duplicate

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest always sort this list, so dup will be very unlikely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait until all the Golint related PR are merged?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is fine as long as we don't forget to do it.
We can probably track it in the umbrella issue.

mengqiy
mengqiy approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@mengqiy mengqiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9081e5d into kubernetes-sigs:master Jan 16, 2020
@Adirio Adirio deleted the lint branch January 16, 2020 22:35
@Adirio Adirio mentioned this pull request Jan 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@estroz estroz estroz left review comments

@mengqiy mengqiy mengqiy approved these changes

@droot droot Awaiting requested review from droot

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

Assignees

@mengqiy mengqiy

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Adirio @k8s-ci-robot @camilamacedo86 @mengqiy @estroz