-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Umbrella Issue] GolangCI lint #1309
Comments
This comment has been minimized.
This comment has been minimized.
HI @Adirio, I am not sure if we need to use all checks. regards the missing ones, do you think that all would be really valid to be added or could we close this one? |
I don't think we need them all, but this list will keep them tracked to know which ones we have and which we don't. |
Sorry, I am not sure if I understood. So, what is missing to address here for we are able to close this issue? |
The question is, do we really need to close this? If we do we can probably create a tag or any other way to group this kind of issues that track changes so that we can search them easily when needed even if they are closed. |
The tasks represent the needs/requirements that need to be addressed. So, if it has nothing more that should be done because is obsoleted or referred, for example, then the next step would be close it and describe why. See that any task that has no activity for a while will also be closed by the boot. So, why you would like to keep this open? What is missing to be done here? |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/lifecycle frozen |
HI @Adirio, the open issues mean needs/tasks that we need to work on. IMO we have in place all lint checks that we need to. So, could you please clarify what in you POV is missing to get done for we close this one? |
Technically, we haven't added all linting checks, so we can't say it is really closed. Is it really a problem to leave it open and frozen? |
HI @Adirio, Has no problem to leave open any task that has actions that should get done but we should close all tasks which are done, or get outdated, were reject and etc. In this case, would we really like to add all possible lint checks? I do not think so. And then, over the lints checks which follow that were not added in the project has anyone here that you think that should be added? IMO I do see a reason to add none of the following lint checks and then, in this way, this task should be closed. So, if you would like to keep it open what should be addressed here? What lint still required to be added and why? |
I don't see the need to add them right now but we may want want to add some more in the future. This issue just kept track of which were added and in which PR. But if you want we can close this issue. |
GolangCI uses several different linters concurrently to asses the code quality of this repository.
This issue lists which ones are implemented in this project:
Linters descriptions for reference
f
at the endThe text was updated successfully, but these errors were encountered: