-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (declarative/v1) : Update the sigs.k8s.io/kubebuilder-declarative-pattern dep used for projects scaffolded with go/v3 plugin from fea7e5cc701290589ec20ef4d9c0629d08b5307d to d0f104b6a96e152043e9c2d76229373a981ac96a #2682
✨ (declarative/v1) : Update the sigs.k8s.io/kubebuilder-declarative-pattern dep used for projects scaffolded with go/v3 plugin from fea7e5cc701290589ec20ef4d9c0629d08b5307d to d0f104b6a96e152043e9c2d76229373a981ac96a #2682
Conversation
3f6e19c
to
c3191e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NikhilSharmaWe thank you for the contribution 🥇
Following its review:
- We need have the title and comment with the info for the changelogs
See that
Also, we can check the changes by: kubernetes-sigs/kubebuilder-declarative-pattern@fea7e5c...d0f104b
So, could you:
a) Update the title and commit:
✨ (declarative/v1) : Update the sigs.k8s.io/kubebuilder-declarative-pattern dep used for projects scaffolded with go/v3 plugin from fea7e5cc701290589ec20ef4d9c0629d08b5307d to d0f104b6a96e152043e9c2d76229373a981ac96a
b) Could you update the description here with:
Update the sigs.k8s.io/kubebuilder-declarative-pattern dep used for projects scaffolded with go/v3 plugin from fea7e5cc701290589ec20ef4d9c0629d08b5307d to d0f104b6a96e152043e9c2d76229373a981ac96a
And add the link to compare what changed between one version to another?
c3191e9
to
384511c
Compare
…attern dep used for projects scaffolded with go/v3 plugin from fea7e5cc701290589ec20ef4d9c0629d08b5307d to d0f104b6a96e152043e9c2d76229373a981ac96a
384511c
to
38823f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That shows nice 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, everettraven, NikhilSharmaWe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -32,7 +32,7 @@ import ( | |||
const ( | |||
// kbDeclarativePattern is the sigs.k8s.io/kubebuilder-declarative-pattern version | |||
kbDeclarativePatternForV2 = "v0.0.0-20200522144838-848d48e5b073" | |||
kbDeclarativePatternForV3 = "fea7e5cc701290589ec20ef4d9c0629d08b5307d" | |||
kbDeclarativePatternForV3 = "d0f104b6a96e152043e9c2d76229373a981ac96a" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camilamacedo86 Can we merge this one.
And could you please take a look at kubernetes-sigs/kubebuilder-declarative-pattern#217 which bumps versions of k8s dependencies and controller-runtime and k8s dependencies in kubebuilder-declarative-pattern
. It is showing breaking API changes in kubectl / cli-utils similar to what we get in #2679.
I think we can move forward with this one 👍 |
/lgtm |
/test pull-kubebuilder-e2e-k8s-1-14-10 |
Description
Update the sigs.k8s.io/kubebuilder-declarative-pattern dep used for projects scaffolded with go/v3 plugin from
fea7e5cc701290589ec20ef4d9c0629d08b5307d
tod0f104b6a96e152043e9c2d76229373a981ac96a
See the comparison between the two versions: kubernetes-sigs/kubebuilder-declarative-pattern@fea7e5c...d0f104b