🐛 Upgrade envtest from 0.28.0 to 0.28.3 to ensure that versions used are aligned #3680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/S
camilamacedo86
changed the title
camilamacedo86
changed the title
Kavinjsir
reviewed
Nov 8, 2023
test/common.sh
Outdated
| @@ -50,7 +50,7 @@ if [ -n "$TRACE" ]; then | |||
| set -x | |||
| fi | |||
|
|
|||
| export KIND_K8S_VERSION="${KIND_K8S_VERSION:-"v1.28.0"}" | |||
| export KIND_K8S_VERSION="${KIND_K8S_VERSION:-"v1.28.3"}" | |||
There was a problem hiding this comment.
It seems like the latest kind node image remains 1.28.0:
https://github.com/kubernetes-sigs/kind/releases .
There was a problem hiding this comment.
Terrific good catcher I will revert this one
There was a problem hiding this comment.
Can we merge this one now?
WDYT? Could you LGTM this one?
camilamacedo86
force-pushed
the
env-test
branch
from
192682f
to
3ffcdfb
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, everettraven The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We upgrade the k8s version from 1.28.0 to 1.28.3 but we did not bumped the envtest. More info, check the PR to generate the artifacts: #3679