Update job-uid label validation

* Replace len label check with IsValidLabelValue from k8s
  apimachinery, which is used on the server side to
  validate the label values.

* Add a log message, for the case, when UID label
  validation returns any errors.

pkg/controller/constants/constants.go

@@ -34,6 +34,6 @@ const (
 	ParentWorkloadAnnotation = "kueue.x-k8s.io/parent-workload"
 
 	// JobUIDLabel is the label key in the workload resource, that holds the UID of
-	// a parent job.
+	// the owner job.
 	JobUIDLabel = "kueue.x-k8s.io/job-uid"
 )

pkg/controller/jobframework/reconciler.go

@@ -24,6 +24,7 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/apimachinery/pkg/util/sets"
+	"k8s.io/apimachinery/pkg/util/validation"
 	"k8s.io/client-go/tools/record"
 	"k8s.io/utils/pointer"
 	ctrl "sigs.k8s.io/controller-runtime"
@@ -456,6 +457,8 @@ func (r *JobReconciler) stopJob(ctx context.Context, job GenericJob, object clie
 
 // constructWorkload will derive a workload from the corresponding job.
 func (r *JobReconciler) constructWorkload(ctx context.Context, job GenericJob, object client.Object) (*kueue.Workload, error) {
+	log := ctrl.LoggerFrom(ctx)
+
 	podSets := job.PodSets()
 
 	wl := &kueue.Workload{
@@ -470,8 +473,15 @@ func (r *JobReconciler) constructWorkload(ctx context.Context, job GenericJob, o
 		},
 	}
 
-	if uid := string(job.Object().GetUID()); len(uid) < 64 && uid != "" {
-		wl.Labels[controllerconsts.JobUIDLabel] = uid
+	jobUid := string(job.Object().GetUID())
+	if errs := validation.IsValidLabelValue(jobUid); len(errs) == 0 {
+		wl.Labels[controllerconsts.JobUIDLabel] = jobUid
+	} else {
+		log.V(2).Info(
+			"Validation of the owner job UID label has failed. Creating workload without the label.",
+			"ValidationErrors", errs,
+			"LabelValue", jobUid,
+		)
 	}
 
 	priorityClassName, p, err := r.extractPriority(ctx, podSets, job)

pkg/controller/jobs/job/job_controller_test.go

@@ -441,7 +441,7 @@ func TestReconciler(t *testing.T) {
 					PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()).
 					Queue("test-queue").
 					Priority(0).
-					SetLabels(map[string]string{
+					Labels(map[string]string{
 						controllerconsts.JobUIDLabel: "test-uid",
 					}).
 					Obj(),
@@ -464,7 +464,7 @@ func TestReconciler(t *testing.T) {
 					PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()).
 					Queue("test-queue").
 					Priority(0).
-					SetLabels(map[string]string{}).
+					Labels(map[string]string{}).
 					Obj(),
 			},
 		},

pkg/util/testing/wrappers.go

@@ -165,8 +165,8 @@ func (w *WorkloadWrapper) ReclaimablePods(rps ...kueue.ReclaimablePod) *Workload
 	return w
 }
 
-func (w *WorkloadWrapper) SetLabels(l map[string]string) *WorkloadWrapper {
-	w.Labels = l
+func (w *WorkloadWrapper) Labels(l map[string]string) *WorkloadWrapper {
+	w.ObjectMeta.Labels = l
 	return w
 }