Dereference StopPolicy before equality check (#1897)

* Dereference StopPolicy before equality check * Update pkg/controller/core/workload_controller.go Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Update pkg/controller/core/workload_controller.go Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> --------- Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
kubernetes-sigs · Mar 26, 2024 · 70e1b52 · 70e1b52
1 parent 2c16bbb
commit 70e1b52
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/controller/core/workload_controller.go b/pkg/controller/core/workload_controller.go
@@ -750,7 +750,7 @@ func (w *workloadCqHandler) Update(ctx context.Context, ev event.UpdateEvent, wq
 
 	if !newCq.DeletionTimestamp.IsZero() ||
 		!slices.CmpNoOrder(oldCq.Spec.AdmissionChecks, newCq.Spec.AdmissionChecks) ||
-		oldCq.Spec.StopPolicy != newCq.Spec.StopPolicy {
+		!ptr.Equal(oldCq.Spec.StopPolicy, newCq.Spec.StopPolicy) {
 		w.queueReconcileForWorkloads(ctx, newCq.Name, wq)
 	}
 }