Dereference StopPolicy before equality check

[gabesaba]

What type of PR is this?

What this PR does / why we need it:

I was investigating why we were doing a large amount of workload reconciles, and found that this equality check wasn't working as intended.

Compare workload reconciles before/after (1k jobs, 10k pods)

Does this PR introduce a user-facing change?

Reduce number of Workload reconciliations due to wrong equality check.

[k8s-ci-robot]

Hi @gabesaba. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	c242f4b
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6602a31a474abf0008659031

[tenzen-y]

/ok-to-test

[tenzen-y]

Great catch!

[mimowo]

LGTM, I'm wondering if we should follow up with a unit test. WDYT @tenzen-y @gabesaba ?

[tenzen-y]

LGTM, I'm wondering if we should follow up with a unit test. WDYT @tenzen-y @gabesaba ?

@mimowo I agree with you. But I'm not sure how to implement any unit tests against event handlers.
Anyway, this PR is already mergeable.

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 4c0c2e50539778cdef176c49209910a383ada99e

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabesaba, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/controller/OWNERS [tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alculquicondor]

/lgtm
/approve

[alculquicondor]

I meant to say
/cherry-pick release-0.6
:)

[alculquicondor]

/cherry-pick release-0.6

[k8s-infra-cherrypick-robot]

@alculquicondor: new pull request created: #1917

In response to this:

I meant to say
/cherry-pick release-0.6
:)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@alculquicondor: new pull request could not be created: failed to create pull request against kubernetes-sigs/kueue#release-0.6 from head k8s-infra-cherrypick-robot:cherry-pick-1897-to-release-0.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for k8s-infra-cherrypick-robot:cherry-pick-1897-to-release-0.6."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alculquicondor]

/release-note-edit

Reduce number of Workload reconciliations

[alculquicondor]

/kind bug