remove unnecessary WithExternalFrameworks option

kubernetes-sigs · Apr 26, 2024 · bbb905f · bbb905f
1 parent b16ba15
commit bbb905f
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 16 deletions.
diff --git a/cmd/kueue/main.go b/cmd/kueue/main.go
@@ -220,7 +220,6 @@ func setupIndexes(ctx context.Context, mgr ctrl.Manager, cfg *configapi.Configur
 
 	opts := []jobframework.Option{
 		jobframework.WithEnabledFrameworks(cfg.Integrations),
-		jobframework.WithExternalFrameworks(cfg.Integrations),
 	}
 	return jobframework.SetupIndexes(ctx, mgr.GetFieldIndexer(), opts...)
 }
@@ -272,7 +271,6 @@ func setupControllers(mgr ctrl.Manager, cCache *cache.Cache, queues *queue.Manag
 		jobframework.WithKubeServerVersion(serverVersionFetcher),
 		jobframework.WithIntegrationOptions(corev1.SchemeGroupVersion.WithKind("Pod").String(), cfg.Integrations.PodOptions),
 		jobframework.WithEnabledFrameworks(cfg.Integrations),
-		jobframework.WithExternalFrameworks(cfg.Integrations),
 		jobframework.WithManagerName(constants.KueueName),
 		jobframework.WithLabelKeysToCopy(cfg.Integrations.LabelKeysToCopy),
 	}

diff --git a/pkg/controller/jobframework/reconciler.go b/pkg/controller/jobframework/reconciler.go
@@ -76,7 +76,6 @@ type Options struct {
 	// IntegrationOptions key is "$GROUP/$VERSION, Kind=$KIND".
 	IntegrationOptions map[string]any
 	EnabledFrameworks  sets.Set[string]
-	ExternalFrameworks sets.Set[string]
 	ManagerName        string
 	LabelKeysToCopy    []string
 }
@@ -136,16 +135,6 @@ func WithEnabledFrameworks(i *configapi.Integrations) Option {
 	}
 }
 
-// WithExternalFrameworks adds external framework names from the ConfigAPI.
-func WithExternalFrameworks(i *configapi.Integrations) Option {
-	return func(o *Options) {
-		if i == nil || len(i.ExternalFrameworks) == 0 {
-			return
-		}
-		o.ExternalFrameworks = sets.New(i.ExternalFrameworks...)
-	}
-}
-
 // WithManagerName adds the kueue's manager name.
 func WithManagerName(n string) Option {
 	return func(o *Options) {

diff --git a/pkg/controller/jobframework/setup_test.go b/pkg/controller/jobframework/setup_test.go
@@ -54,9 +54,6 @@ func TestSetupControllers(t *testing.T) {
 				WithEnabledFrameworks(&configapi.Integrations{
 					Frameworks: []string{"batch/job", "kubeflow.org/mpijob"},
 				}),
-				WithExternalFrameworks(&configapi.Integrations{
-					ExternalFrameworks: []string{"workload.codeflare.dev/v1beta2, Kind=AppWrapper"},
-				}),
 			},
 			mapperGVKs: []schema.GroupVersionKind{
 				batchv1.SchemeGroupVersion.WithKind("Job"),