Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info to Queue status #5

Closed
ahg-g opened this issue Feb 17, 2022 · 9 comments
Closed

Add info to Queue status #5

ahg-g opened this issue Feb 17, 2022 · 9 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Comments

@ahg-g
Copy link
Contributor

ahg-g commented Feb 17, 2022

Suggestions:

  • Number of pending jobs
  • Number of started jobs
  • Resources currently used by the queue.

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 17, 2022
@ahg-g
Copy link
Contributor Author

ahg-g commented Feb 18, 2022

/size M
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 18, 2022
@ahg-g ahg-g added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 18, 2022
@ArangoGutierrez
Copy link
Contributor

/assign

@alculquicondor
Copy link
Contributor

The way we can do this is using the regular reconciler pattern in pkg/controller/core. The internal work queue would allow us to potentially do less API calls than the events we receive.

Implementation-wise, you just need to return true from the event handlers, so that the reconciler starts being called.

@ArangoGutierrez
Copy link
Contributor

ArangoGutierrez commented Mar 2, 2022

Target:

  • Number of pending jobs
  • Number of assigned jobs
  • Resources currently used by the queue.

@alculquicondor
Copy link
Contributor

s/started/assigned

@ArangoGutierrez
Copy link
Contributor

ArangoGutierrez commented Mar 11, 2022

I think after #114, we can close this , now that AdmittedWorkloads will be tracked at the ClusterQueue lvl for now

@ArangoGutierrez
Copy link
Contributor

Now that #114 is merged, I think we can close this issue

Thoughts otherwise? (@alculquicondor @ahg-g )

@alculquicondor
Copy link
Contributor

We could still add the others, but maybe it will make more sense when there is support for Queue limits

/close

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: Closing this issue.

In response to this:

We could still add the others, but maybe it will make more sense when there is support for Queue limits

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

No branches or pull requests

4 participants