Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info to ClusterQueue status #7

Closed
4 tasks done
ahg-g opened this issue Feb 17, 2022 · 19 comments · Fixed by #57
Closed
4 tasks done

Add info to ClusterQueue status #7

ahg-g opened this issue Feb 17, 2022 · 19 comments · Fixed by #57
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Comments

@ahg-g
Copy link
Contributor

ahg-g commented Feb 17, 2022

Suggestions:

  • admitted workloads
  • pending workloads
  • Capacity allocated
  • Capacity borrowed

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 17, 2022
@ahg-g ahg-g added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 18, 2022
@alculquicondor
Copy link
Contributor

/assign

@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 1, 2022

Should we add pending workloads to capacity as well?

@alculquicondor
Copy link
Contributor

Aggregating the sizes of all the queues pointing to it? We should be able to implement that efficiently, but could it be confusing?

@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 1, 2022

Why would it be confusing? The pending workloads at a queue level isn't really that useful i would say for an admin to look at compared to an aggregated view at the capacity level

@alculquicondor
Copy link
Contributor

/reopen

Sounds good. Although I will tackle this after #80 (comment)

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: Reopened this issue.

In response to this:

/reopen

Sounds good. Although I will tackle this after #80 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ArangoGutierrez
Copy link
Contributor

I strongly disagree with

The pending workloads at a queue level isn't really that useful

For users, is the most important after deploying, if queues are going to be a user managed object, we need to provide as much valuable information to them at the namespace lvl.

As an admin all I care is big numbers and usage. I think we are looking at this with an admin/cloud provider point of view and not from the end user.

we need to think as a cascade here

CQ -> Q -> QW

@ArangoGutierrez
Copy link
Contributor

pending workloads at a queue level are one of THE most important reasons why people want to have a queuing mechanism in kubernetes.

@ArangoGutierrez
Copy link
Contributor

/retitle Add info to ClusterQueue status

@k8s-ci-robot k8s-ci-robot changed the title Add info to Capacity status Add info to ClusterQueue status Mar 8, 2022
@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 8, 2022

sg, I already proposed a way to track the number of admitted workloads at Q level

@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 8, 2022

oh, you are referring to the count of pending workloads; I guess I agree in general the the more info we can surface the better

@xieydd
Copy link

xieydd commented Mar 9, 2022

I agree with the comment from @ArangoGutierrez .
Considering the cascade of CQ, Q and QW, we need the more info we can of workload , we can aggregate some info for Q and CQ.

@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 9, 2022

sg, then with regards to this issue we need two things in CQ status:

  • Rename AssignedWorkloads to AdmittedWorkloads
  • Pending workloads

/help
/unassign @alculquicondor

@k8s-ci-robot
Copy link
Contributor

@ahg-g:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

sg, then with regards to this issue we need two things in CQ status:

  • Rename AssignedWorkloads to AdmittedWorkloads
  • Pending workloads

/help
/unassign @alculquicondor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 9, 2022
@ArangoGutierrez
Copy link
Contributor

sg, then with regards to this issue we need two things in CQ status:

  • Rename AssignedWorkloads to AdmittedWorkloads
  • Pending workloads

/help /unassign @alculquicondor

Check first one #110

@ArangoGutierrez
Copy link
Contributor

For Pending workloads do we still want to track that on kueue.clusterqueue.Status?
as it is right now, a workload has to be admitted into a clusterqueue, so to the eyes of clusterqueue it is never pending, pending feels better at the kueue.queue lvl, tracking workloads that have not yet been admitted, right?
if yes we can close this issue as done, and focus on #5 only

@alculquicondor
Copy link
Contributor

Pending workloads are the workloads that are still in the heap, so they haven't been admitted.

Yes, we should add that field to clusterQueue.status

@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 11, 2022

/close

@k8s-ci-robot
Copy link
Contributor

@ahg-g: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants