generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jobset] Partial-Admission KEP #1001
Open
trasc
wants to merge
1
commit into
kubernetes-sigs:main
Choose a base branch
from
epam:jobset-partial-admission-kep
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,7 @@ | |
- [Jobframework](#jobframework) | ||
- [batch/Job controller](#batchjob-controller) | ||
- [kubeflow/MPIJob controller](#kubeflowmpijob-controller) | ||
- [kubernetes-sigs/jobset](#kubernetes-sigsjobset) | ||
- [Test Plan](#test-plan) | ||
- [Unit Tests](#unit-tests) | ||
- [Integration tests](#integration-tests) | ||
|
@@ -70,6 +71,14 @@ type PodSet struct { | |
// enabled. | ||
// +optional | ||
MinCount *int32 `json:"minCount,omitempty"` | ||
|
||
// partialAdmissionDecrementStep is the step in which partialadmission will decremet the admission count. | ||
// | ||
// If this is provided, both minCount and count should be a multiple of it. | ||
// If not provided and partial admission for the current PodSet is enabled this will be considered 1. | ||
// This field is ignored if partial admission is not enabled (minCount == nil) | ||
// +optional | ||
PartialAdmissionDecrementStep *int32 `json:"partialAdmissionDecrementStep,omitempty"` | ||
} | ||
|
||
``` | ||
|
@@ -80,6 +89,8 @@ In case the workload proposed for the current scheduling cycle, does not fit, wi | |
|
||
The search should be optimized (binary search) and preserve the proportion of pods lost across the variable count PodSets. | ||
|
||
If `partialAdmissionDecrementStep` is provided, the returned acceptable count will be rounded down to the closest multiple of `partialAdmissionDecrementStep`. | ||
|
||
The accepted number of pods in each PodSet are recorded in `workload.Status.Admission.PodSetAssignments[*].ResourceUsage.Count` | ||
|
||
In order to evaluate the potential success of the preemption, the preemption process should be split in: | ||
|
@@ -144,6 +155,21 @@ In case of MPIJob `j.Spec.RunPolicy.SchedulingPolicy.MinAvailable` can be used t | |
Whether an MPIJob supports partial admission or not can be deduced based on `MinAvailable` without the need of a dedicated annotation. | ||
Additional research is needed into the potential usage of multiple variable count PodSets. | ||
|
||
### kubernetes-sigs/jobset | ||
|
||
Besides adapting `RunWithPodSetsInfo` and `RestorePodSetsInfo` it should also: | ||
|
||
- rework `PodSets()` to populate `MinCount` and `PartialAdmissionDecrementStep` if the jobset is marked to support partial admission. | ||
* jobsets supporting partial admission should have a dedicated annotation. eg. `kueue.x-k8s.io/jobset-min-replicas`, indicating the index of the replicated job that supports partial admission as well as the minimum `replicas` acceptable. | ||
|
||
``` | ||
MinCount = minimumReplicas * replicatedJobParallelism | ||
PartialAdmissionDecrementStep = replicatedJobParallelism | ||
``` | ||
|
||
NOTE: Currently jobset is not supporting `replicas` updates, this needs to be implemented on the jobset side. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you post this on Jobset repo? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we are going ahead with this, I'll open an issue on jobset side and try to provide the implementation. |
||
|
||
|
||
### Test Plan | ||
|
||
No regressions in the current test should be observed. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of another annotation, would it make sense for JobSet to have a
minReplicas
field in their PodSet definition?@ahg-g
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @ahg-g