Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for registering externally managed frameworks #2059

Merged
merged 6 commits into from Apr 26, 2024
Merged

Add support for registering externally managed frameworks #2059

merged 6 commits into from Apr 26, 2024

Conversation

dgrove-oss
Copy link
Contributor

@dgrove-oss dgrove-oss commented Apr 24, 2024 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds the ability to register GroupVersionKinds as being managed by an external Kueue workload controller.
This allows instances of these GVKs to be properly recognized as being managed by Kueue and
enables the instance's owned Jobs to be recognized as being child Jobs.

Which issue(s) this PR fixes:

Fixes #2003

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add configuration to register Kinds as being managed by an external Kueue-compatible controller

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. labels Apr 24, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 24, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @dgrove-oss!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 24, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @dgrove-oss. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 24, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 24, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit bbb905f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/662bd5da8a0e9e00082d293a

@alculquicondor
Copy link
Contributor

/ok-to-test

As a user-facing change, please add a release note.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 25, 2024
alculquicondor
alculquicondor reviewed Apr 25, 2024
View reviewed changes
apis/config/v1beta1/configuration_types.go Outdated Show resolved Hide resolved
config/components/manager/controller_manager_config.yaml Outdated Show resolved Hide resolved
pkg/controller/jobframework/integrationmanager.go Outdated Show resolved Hide resolved
pkg/controller/jobframework/integrationmanager.go Outdated Show resolved Hide resolved
cmd/kueue/main.go Show resolved Hide resolved
pkg/controller/jobframework/setup.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 25, 2024
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 25, 2024
@dgrove-oss
Copy link
Contributor Author

Updated to address review comments.

alculquicondor
alculquicondor reviewed Apr 25, 2024
View reviewed changes
cmd/kueue/main.go Show resolved Hide resolved
pkg/controller/jobframework/integrationmanager.go Outdated Show resolved Hide resolved
pkg/controller/jobframework/integrationmanager.go Outdated Show resolved Hide resolved
pkg/controller/jobframework/integrationmanager_test.go Outdated Show resolved Hide resolved
pkg/controller/jobframework/integrationmanager_test.go Outdated Show resolved Hide resolved
dgrove-oss
dgrove-oss commented Apr 25, 2024
View reviewed changes
Copy link
Contributor Author

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback; hopefully all addressed.

cmd/kueue/main.go Show resolved Hide resolved
pkg/controller/jobframework/integrationmanager.go Outdated Show resolved Hide resolved
pkg/controller/jobframework/integrationmanager_test.go Outdated Show resolved Hide resolved
pkg/controller/jobframework/integrationmanager_test.go Outdated Show resolved Hide resolved
@dgrove-oss
Copy link
Contributor Author

/test pull-kueue-test-unit-main

@dgrove-oss
allow RegisterExternalJobType to be called multiple times with same kind
b16ba15 
The operation of parsing a kindArg into a GVK is deterministic. Since
unit tests run multiple times, flagging these as errors will result
in spurious failures in main_test's TestValidateIntegrationsName.
@alculquicondor
Copy link
Contributor

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 33f774c54cffa429a94882bc2a061f4136fb6bc3

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, dgrove-oss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 44b3055 into kubernetes-sigs:main Apr 26, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone Apr 26, 2024
@dgrove-oss dgrove-oss deleted the external-framework branch April 26, 2024 17:41
@dgrove-oss dgrove-oss mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@kerthcet kerthcet Awaiting requested review from kerthcet

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

Enhance integration manager to enable external controllers to provide Kueue integrations
3 participants
@dgrove-oss @k8s-ci-robot @alculquicondor