-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add field AssumedWorkloads
to cache.ClusterQueue
#268
Add field AssumedWorkloads
to cache.ClusterQueue
#268
Conversation
389a1f5
to
14520c2
Compare
@ahg-g can you help to review this, but I found you're still on vacation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
pkg/cache/cache_test.go
Outdated
{ | ||
name: "assume error clusterQueue doesn't exist", | ||
operation: func(cache *Cache) error { | ||
w := utiltesting.MakeWorkload("d", "").PodSets(podSets).Admit(&kueue.Admission{ | ||
w := utiltesting.MakeWorkload("a", "").PodSets(podSets).Admit(&kueue.Admission{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted.
thanks, pls squash |
Signed-off-by: kerthcet <kerthcet@gmail.com>
1b32529
to
f9e7a83
Compare
squashed @ahg-g |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, kerthcet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: kerthcet kerthcet@gmail.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #267
Special notes for your reviewer: