Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump GO to 1.20 #675

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Bump GO to 1.20 #675

merged 2 commits into from
Apr 11, 2023

Conversation

ArangoGutierrez
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

With the upcoming #659 release, is always good to revisit dependencies

Special notes for your reviewer:

make build image-build test test-integration
run to completion after this change

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 5, 2023
@netlify
Copy link

netlify bot commented Apr 5, 2023 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 86928b3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/643577a16e00ec00089fe05f

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 5, 2023
@ArangoGutierrez
Copy link
Contributor Author

Depends on kubernetes/test-infra#29225
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2023
@alculquicondor
Copy link
Contributor

let's leave this for next week, after the release

@ArangoGutierrez
Copy link
Contributor Author

/retest

@ArangoGutierrez
Bump GO to 1.20
14ac280 
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
@ArangoGutierrez
Copy link
Contributor Author

A soft rebase is all it needed :)

@ArangoGutierrez
Bump golangci-lint to 1.52.2
86928b3 
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
@ArangoGutierrez
Copy link
Contributor Author

Yay!
/woof

@k8s-ci-robot
Copy link
Contributor

@ArangoGutierrez: dog image

In response to this:

Yay!
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor alculquicondor added this to the v0.4 milestone Apr 11, 2023
alculquicondor
alculquicondor reviewed Apr 11, 2023
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, ArangoGutierrez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2023
@ArangoGutierrez
Copy link
Contributor Author

Depends on kubernetes/test-infra#29225
/hold

/Unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit dc1bed4 into kubernetes-sigs:main Apr 11, 2023
4 checks passed
@tenzen-y tenzen-y mentioned this pull request Apr 24, 2023
Closed
@tenzen-y
Copy link
Member

/cherrypick release-0.3

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 24, 2023
Closed
@k8s-infra-cherrypick-robot
Copy link

@tenzen-y: new pull request created: #719

In response to this:

/cherrypick release-0.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ArangoGutierrez @alculquicondor @k8s-ci-robot @tenzen-y @k8s-infra-cherrypick-robot