[release-0.3] Update the queue name in workload only when the job is standalone

[k8s-infra-cherrypick-robot]

This is an automated cherry-pick of #713

/assign tenzen-y

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign alculquicondor for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tenzen-y]

/lgtm
/assign @alculquicondor

[tenzen-y]

Oh, prow seems to be very heavy...

go: downloading github.com/prometheus/procfs v0.7.3
go: downloading google.golang.org/protobuf v1.28.0
go: downloading github.com/mattn/go-runewidth v0.0.9
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
/home/prow/go/src/sigs.k8s.io/kueue/bin/golangci-lint run --timeout 7m0s
make: *** [Makefile:158: ci-lint] Killed

[tenzen-y]

/test pull-kueue-verify-main

[k8s-ci-robot]

@k8s-infra-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kueue-verify-main	95dda14	link	true	/test pull-kueue-verify-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[tenzen-y]

I found the causes.

We are using the golangci-lint v1.48.0 which doesn't support Go v1.20 in the release-0.3 branch, even though we are using Go 1.20 CI.

https://github.com/kubernetes/test-infra/blob/cd2ed1fcffe20602f568502945428474b0a0351b/config/jobs/kubernetes-sigs/kueue/kueue-presubmits.yaml#L114-L128

So, we should update the golangci-lint version in release-0.3 branch or add a task like the below to prow config:

  - name: pull-kueue-verify-main-release-0-3
    always_run: true
    decorate: true
    path_alias: sigs.k8s.io/kueue
    annotations:
      testgrid-dashboards: sig-scheduling
      testgrid-tab-name: pull-kueue-verify-main
      description: "Run kueue verify checks"
    branches:
    - ^release-0.3$    
    spec:
      containers:
      - image: golang:1.19
        command:
        - make
        args:
        - verify

@alculquicondor Which options do you prefer?

[tenzen-y]

IMO, I'd like to add a new task to the prow config.

[alculquicondor]

In kubernetes, we actually bump the go version in the release branches, but more so when it's about to reach end-of-support kubernetes/kubernetes#113956

I think it should be fine to bump golangci-lint, if everything continues passing.

[tenzen-y]

In kubernetes, we actually bump the go version in the release branches, but more so when it's about to reach end-of-support kubernetes/kubernetes#113956

I think it should be fine to bump golangci-lint, if everything continues passing.

Ah, I see. I will create a PR to cherry-pick 86928b3 on release-0.3 branch.

[tenzen-y]

Actually, I will create a PR to cherry-pick #675 :)

[ArangoGutierrez]

kubernetes/test-infra#29362 <- this PR could fix the presubmits for release-03 branch

[ArangoGutierrez]

In kubernetes, we actually bump the go version in the release branches, but more so when it's about to reach end-of-support kubernetes/kubernetes#113956

I think it should be fine to bump golangci-lint, if everything continues passing.

To Aldo's comment, 1.19 is still support(and has still some lifecycle to run) and release-03 was just released, a dependency change like this is not a good practice unless is required to fix a critical bug (security or functional)

[ArangoGutierrez]

/retest

[ArangoGutierrez]

/test all

[ArangoGutierrez]

/override pull-kueue-verify-main

[alculquicondor]

/close

Let's try creating a new PR

[k8s-ci-robot]

@alculquicondor: Closed this PR.

In response to this:

/close

Let's try creating a new PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alculquicondor]

/milestone clear