[Cache] Sort resourceUsages according to resourceName

[tenzen-y]

What type of PR is this?

/kind bug

What this PR does / why we need it:

The resourceUsages should be in a stable order to avoid endless creation of update events.
So, I added processes to sort resourceUsages according to resourceName in ClusterQueue and LocalQueue.

Which issue(s) this PR fixes:

Fixes #902

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix a bug that updates events for clusterQueues are created endlessly.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	7131a1c
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/649b22772a1c3e00087b88e3

[tenzen-y]

Before I added sort, this tests failed:

$ go test -run 'TestClusterQueueUsage' ./pkg/cache/...
go: downloading k8s.io/apiextensions-apiserver v0.26.6
--- FAIL: TestClusterQueueUsage (0.01s)
    --- FAIL: TestClusterQueueUsage/clusterQueue_without_cohort;_single_no_borrowing (0.01s)
        cache_test.go:1490: Unexpected used resources (-want,+got):
              []v1beta1.FlavorUsage{
                {Name: "default", Resources: {{Name: s"cpu", Total: {i: {...}, Format: "DecimalSI"}}}},
                {Name: "model_a", Resources: {{Name: s"example.com/gpu", Total: {i: {...}, Format: "DecimalSI"}}}},
                {Name: "model_b", Resources: {{Name: s"example.com/gpu"}}},
                {
                        Name: "interconnect_a",
                        Resources: []v1beta1.ResourceUsage{
            +                   {Name: s"example.com/vf-2", Total: resource.Quantity{Format: "DecimalSI"}},
                                {Name: s"example.com/vf-0"},
                                {Name: s"example.com/vf-1"},
            -                   {Name: s"example.com/vf-2"},
                        },
                },
              }
        cache_test.go:1490: Unexpected used resources (-want,+got):
              []v1beta1.FlavorUsage{
                {Name: "default", Resources: {{Name: s"cpu", Total: {i: {...}, Format: "DecimalSI"}}}},
                {Name: "model_a", Resources: {{Name: s"example.com/gpu", Total: {i: {...}, Format: "DecimalSI"}}}},
                {Name: "model_b", Resources: {{Name: s"example.com/gpu"}}},
                {
                        Name: "interconnect_a",
                        Resources: []v1beta1.ResourceUsage{
            -                   {Name: s"example.com/vf-0"},
                                {Name: s"example.com/vf-1"},
                                {Name: s"example.com/vf-2"},
            +                   {Name: s"example.com/vf-0", Total: resource.Quantity{Format: "DecimalSI"}},
                        },
                },
              }
        cache_test.go:1490: Unexpected used resources (-want,+got):
              []v1beta1.FlavorUsage{
                {Name: "default", Resources: {{Name: s"cpu", Total: {i: {...}, Format: "DecimalSI"}}}},
                {Name: "model_a", Resources: {{Name: s"example.com/gpu", Total: {i: {...}, Format: "DecimalSI"}}}},
                {Name: "model_b", Resources: {{Name: s"example.com/gpu"}}},
                {
                        Name: "interconnect_a",
                        Resources: []v1beta1.ResourceUsage{
            +                   {Name: s"example.com/vf-2", Total: resource.Quantity{Format: "DecimalSI"}},
                                {Name: s"example.com/vf-0"},
                                {Name: s"example.com/vf-1"},
            -                   {Name: s"example.com/vf-2"},
                        },
                },
              }
    --- FAIL: TestClusterQueueUsage/clusterQueue_with_cohort;_multiple_borrowing (0.00s)
        cache_test.go:1490: Unexpected used resources (-want,+got):
              []v1beta1.FlavorUsage{
                {Name: "default", Resources: {{Name: s"cpu", Total: {i: {...}, Format: "DecimalSI"}, Borrowed: {i: {...}, Format: "DecimalSI"}}}},
                {Name: "model_a", Resources: {{Name: s"example.com/gpu", Total: {i: {...}, Format: "DecimalSI"}}}},
                {Name: "model_b", Resources: {{Name: s"example.com/gpu", Total: {i: {...}, Format: "DecimalSI"}, Borrowed: {i: {...}, Format: "DecimalSI"}}}},
                {
                        Name: "interconnect_a",
                        Resources: []v1beta1.ResourceUsage{
            -                   {Name: s"example.com/vf-0"},
                                {Name: s"example.com/vf-1"},
                                {Name: s"example.com/vf-2"},
            +                   {Name: s"example.com/vf-0", Total: resource.Quantity{Format: "DecimalSI"}},
                        },
                },
              }
        cache_test.go:1490: Unexpected used resources (-want,+got):
              []v1beta1.FlavorUsage{
                {Name: "default", Resources: {{Name: s"cpu", Total: {i: {...}, Format: "DecimalSI"}, Borrowed: {i: {...}, Format: "DecimalSI"}}}},
                {Name: "model_a", Resources: {{Name: s"example.com/gpu", Total: {i: {...}, Format: "DecimalSI"}}}},
                {Name: "model_b", Resources: {{Name: s"example.com/gpu", Total: {i: {...}, Format: "DecimalSI"}, Borrowed: {i: {...}, Format: "DecimalSI"}}}},
                {
                        Name: "interconnect_a",
                        Resources: []v1beta1.ResourceUsage{
            +                   {Name: s"example.com/vf-2", Total: resource.Quantity{Format: "DecimalSI"}},
                                {Name: s"example.com/vf-0"},
                                {Name: s"example.com/vf-1"},
            -                   {Name: s"example.com/vf-2"},
                        },
                },
              }
    --- FAIL: TestClusterQueueUsage/clusterQueue_without_cohort;_multiple_borrowing (0.00s)
        cache_test.go:1490: Unexpected used resources (-want,+got):
              []v1beta1.FlavorUsage{
                {Name: "default", Resources: {{Name: s"cpu", Total: {i: {...}, Format: "DecimalSI"}}}},
                {Name: "model_a", Resources: {{Name: s"example.com/gpu", Total: {i: {...}, Format: "DecimalSI"}}}},
                {Name: "model_b", Resources: {{Name: s"example.com/gpu", Total: {i: {...}, Format: "DecimalSI"}}}},
                {
                        Name: "interconnect_a",
                        Resources: []v1beta1.ResourceUsage{
            +                   {Name: s"example.com/vf-2", Total: resource.Quantity{Format: "DecimalSI"}},
                                {Name: s"example.com/vf-0"},
                                {Name: s"example.com/vf-1"},
            -                   {Name: s"example.com/vf-2"},
                        },
                },
              }
FAIL
FAIL    sigs.k8s.io/kueue/pkg/cache     0.640s
FAIL

[tenzen-y]

/assign @alculquicondor

[alculquicondor]

/approve
I would just remove the loops

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alculquicondor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alculquicondor]

/lgtm

[alculquicondor]

let's cherry-pick as well.
I think we can do a last patch release of 0.3 along with 0.4

[tenzen-y]

let's cherry-pick as well.
I think we can do a last patch release of 0.3 along with 0.4

That's great!

/cherrypick release-0.3

[k8s-infra-cherrypick-robot]

@tenzen-y: once the present PR merges, I will cherry-pick it on top of release-0.3 in a new PR and assign it to you.

In response to this:

let's cherry-pick as well.
I think we can do a last patch release of 0.3 along with 0.4

That's great!

/cherrypick release-0.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@tenzen-y: #907 failed to apply on top of branch "release-0.3":

Applying: Sort resourceUsages according to resourceName
Using index info to reconstruct a base tree...
M	pkg/cache/cache.go
M	pkg/cache/cache_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/cache/cache_test.go
CONFLICT (content): Merge conflict in pkg/cache/cache_test.go
Auto-merging pkg/cache/cache.go
CONFLICT (content): Merge conflict in pkg/cache/cache.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Sort resourceUsages according to resourceName
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

let's cherry-pick as well.
I think we can do a last patch release of 0.3 along with 0.4

That's great!

/cherrypick release-0.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.