Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pod/node labels #347

Closed
benjaminjb opened this issue Nov 5, 2019 · 3 comments
Closed

Add pod/node labels #347

benjaminjb opened this issue Nov 5, 2019 · 3 comments

Comments

@benjaminjb
Copy link

I'm using metrics-server to keep track of certain CPU/memory usage, but I'd like to aggregate on pod labels. Any reason why we couldn't add labels to this section?

Name: pod.Name,
Namespace: pod.Namespace,
CreationTimestamp: metav1.NewTime(time.Now()),

@serathius
Copy link
Contributor

Changes to API exposed by metrics server should be proposed in https://github.com/kubernetes/metrics feel free to open issue there
Overall metrics-server API was not designed to do any aggregation.

@benjaminjb
Copy link
Author

Is this technically an API change since PodMetrics uses the standard Meta, which includes Name, Namespace, and Labels?

@serathius
Copy link
Contributor

Yes, currently metrics API doesn't specify that Metrics object need to have same labels as object they represent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants